pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] mail: fix race condition in "make voice message in chat"

Browse Source 
runbot-46626

closes odoo/odoo#144901

Signed-off-by: Didier Debondt (did) <did@odoo.com>
This commit is contained in:
Sébastien Theys
2023-12-05 21:15:22 +00:00
parent 34bd5d5655
commit 4d00cedaca
2 changed files with 20 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/mail/static/tests/discuss/voice_message/voice_message_tests.js
+17 -4
View File
@@ -141,7 +141,6 @@ QUnit.test("make voice message in chat", async () => {
return super.fetchFile(url("/mail/static/src/audio/call_02_in_.mp3"));
},
});
patchDate(2023, 6, 31, 13, 0, 0);
mockGetMedia();
const cleanUp = patchAudio();
const pyEnv = await startServer();
@@ -155,11 +154,25 @@ QUnit.test("make voice message in chat", async () => {
});
const { openDiscuss } = await start();
openDiscuss(channelId);
await contains("button[title='Voice Message']");
patchDate(2023, 6, 31, 13, 0, 0, 0);
await click("button[title='Voice Message']");
await contains(".o-mail-VoiceRecorder", { text: "00 : 00" });
await Promise.resolve();
// simulate 10 sec elapsed
patchDate(2023, 6, 31, 13, 0, 11); // +1 so exactly 10 sec elapsed
/**
* Simulate 10 sec elapsed.
* `patchDate` does not freeze the time, it merely changes the value of "now" at the time it was
* called. The code of click following the first `patchDate` doesn't actually happen at the time
* that was specified, but few miliseconds later (8 ms on my machine).
* The process following the next `patchDate` is intended to be between 10s and 11s later than
* the click, because the test wants to assert a 10 sec counter, and the two dates are
* substracted and then rounded down in the code (it means absolute values are irrelevant here).
* The problem with aiming too close to a 10s difference is that if the click is longer than
* the following process, it will round down to 9s.
* The problem with aiming too close to a 11s difference is that if the click is shorter than
* the following process, it will round down to 11s.
* The best bet is therefore to use 10s + 500ms difference.
*/
patchDate(2023, 6, 31, 13, 0, 10, 500);
// simulate some microphone data
audioProcessor.process([[new Float32Array(128)]]);
await contains(".o-mail-VoiceRecorder", { text: "00 : 10" });
addons/web/static/tests/helpers/utils.js
+3 -2
View File
@@ -48,13 +48,14 @@ import {
* @param {number} [hours]
* @param {number} [minutes]
* @param {number} [seconds]
* @param {number} [ms=0]
*/
export function patchDate(year, month, day, hours, minutes, seconds) {
export function patchDate(year, month, day, hours, minutes, seconds, ms = 0) {
var RealDate = window.Date;
var actualDate = new RealDate();
// By default, RealDate uses the browser offset, so we must replace it with the offset fixed in luxon.
var fakeDate = new RealDate(year, month, day, hours, minutes, seconds);
var fakeDate = new RealDate(year, month, day, hours, minutes, seconds, ms);
if (!(luxon.Settings.defaultZone instanceof luxon.FixedOffsetZone)) {
throw new Error("luxon.Settings.defaultZone must be a FixedOffsetZone");
}