[FIX] mrp_subcontracting: relax constraint on subcontracting location

Some people want to manage the subcontractor stock the same way than a
classic stock. It will then impact the on hand value but it's the
behavior they want.

I keep the constraint on internal location since it will impact
valuation.

closes odoo/odoo#163262

X-original-commit: be8e1da9d9dc3b82479b1560c9d5e780c8ecb36b
Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>

addons/mrp_subcontracting/i18n/mrp_subcontracting.pot

@@ -166,7 +166,7 @@ msgstr ""
 #, python-format
 msgid ""
 "In order to manage stock accurately, subcontracting locations must be type "
-"Internal, linked to the appropriate company and not specific to a warehouse."
+"Internal, linked to the appropriate company."
 msgstr ""
 
 #. module: mrp_subcontracting

addons/mrp_subcontracting/models/stock_location.py

@@ -20,8 +20,8 @@ class StockLocation(models.Model):
         for location in self:
             if location == location.company_id.subcontracting_location_id:
                 raise ValidationError(_("You cannot alter the company's subcontracting location"))
-            if location.is_subcontracting_location and (location.usage != 'internal' or location.warehouse_id):
-                raise ValidationError(_("In order to manage stock accurately, subcontracting locations must be type Internal, linked to the appropriate company and not specific to a warehouse."))
+            if location.is_subcontracting_location and location.usage != 'internal':
+                raise ValidationError(_("In order to manage stock accurately, subcontracting locations must be type Internal, linked to the appropriate company."))
 
     @api.model_create_multi
     def create(self, vals_list):