[FIX] website_sale: not use t-if on attribute of snippet section

Before this commit the default product category was set on the product
snippet by a wrong use of qweb's <attribute> tag, trying to use t-if to
only apply the change for product snippet.
This actually was ignored and the attribute was appearing on all dropped
dynamic snippets (including blogs).

After this commit the default product category is set on the product
snippet from javascript.

https://github.com/odoo/odoo/pull/68529

addons/website_sale/static/src/snippets/s_dynamic_snippet_products/options.js

@@ -63,7 +63,14 @@ const dynamicSnippetProductsOptions = s_dynamic_snippet_carousel_options.extend(
         const productCategoriesSelectorEl = uiFragment.querySelector('[data-name="product_category_opt"]');
         return this._renderSelectUserValueWidgetButtons(productCategoriesSelectorEl, this.productCategories);
     },
-
+    /**
+     * @override
+     * @private
+     */
+    _setOptionsDefaultValues: function () {
+        this._setOptionValue('productCategoryId', 'all');
+        this._super.apply(this, arguments);
+    },
 });
 
 options.registry.dynamic_snippet_products = dynamicSnippetProductsOptions;

addons/website_sale/views/snippets/s_dynamic_snippet_products.xml

@@ -5,11 +5,6 @@
             <t t-set="snippet_name" t-value="'s_dynamic_snippet_products'"/>
         </t>
     </template>
-    <template id="s_dynamic_snippet_template" inherit_id="website.s_dynamic_snippet_template">
-        <xpath expr="section" position="attributes">
-            <attribute t-if="snippet_name == 's_dynamic_snippet_products'" name="data-product-category-id">all</attribute>
-        </xpath>
-    </template>
     <template id="s_dynamic_snippet_products_options" inherit_id="website.snippet_options">
         <xpath expr="." position="inside">
             <t t-call="website.dynamic_snippet_carousel_options_template">