[FIX] payment_ogone: swap SHA-IN key with SHA-OUT in signature check

The key that should be used to check the signature of incoming (Ogone to
Odoo) communication should be `ogone_shakey_out`. For an outgoing
communication, the signature should be generated with `ogone_shakey_in`.

This commit swaps the IN key with the OUT key in signature calculations
to use the appropriate key for a given communication.

The opportunity is also taken to go back to using SHA1 for signature
computation rather than SHA256 that was introduced with 61a02a73 in
order to ease the migration of existing users. Keeping SHA256 would have
required users to make the switch on Ogone's backend.

task-2494916

closes odoo/odoo#70280

X-original-commit: 91782fa29ce597d3985221b76a0d16993facb53e
Signed-off-by: Antoine Vandevenne (anv) <AntoineVDV@users.noreply.github.com>

addons/payment_ogone/models/payment_acquirer.py

@@ -1,7 +1,7 @@
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
 import logging
-from hashlib import sha256
+from hashlib import sha1
 
 import requests
 
@@ -85,14 +85,14 @@ class PaymentAcquirer(models.Model):
         def _filter_key(_key):
             return not incoming or _key in VALID_KEYS
 
-        key = self.ogone_shakey_in if incoming else self.ogone_shakey_out
+        key = self.ogone_shakey_out if incoming else self.ogone_shakey_in  # Swapped for Ogone's POV
         if format_keys:
             formatted_items = [(k.upper().replace('_', '.'), v) for k, v in values.items()]
         else:
             formatted_items = [(k.upper(), v) for k, v in values.items()]
         sorted_items = sorted(formatted_items)
         signing_string = ''.join(f'{k}={v}{key}' for k, v in sorted_items if _filter_key(k) and v)
-        shasign = sha256(signing_string.encode("utf-8")).hexdigest()
+        shasign = sha1(signing_string.encode()).hexdigest()
         return shasign
 
     def _ogone_make_request(self, api_key, payload=None, method='POST'):