[FIX] sale_coupon: Select only customers on coupon programs

models/sale_coupon_rules.py

@@ -12,7 +12,7 @@ class SaleCouponRule(models.Model):
 
     rule_date_from = fields.Datetime(string="Start Date", help="Coupon program start date")
     rule_date_to = fields.Datetime(string="End Date", help="Coupon program end date")
-    rule_partners_domain = fields.Char(string="Based on Customers", help="Coupon program will work for selected customers only")
+    rule_partners_domain = fields.Char(string="Based on Customers", default=[['customer', '=', True]], help="Coupon program will work for selected customers only")
     rule_partner_ids = fields.Many2many('res.partner', 'rule_partner_rel', 'rule_id', 'partner_id',
         string="Related Partners", compute='_compute_rule_partner_ids', store=True)
     rule_products_domain = fields.Char(string="Based on Products", help="On Purchase of selected product, reward will be given")

tests/common.py

@@ -12,6 +12,7 @@ class TestSaleCouponCommon(common.TransactionCase):
         # create partner for sale order.
         self.steve = self.env['res.partner'].create({
             'name': 'Steve Bucknor',
+            'customer': True,
             'email': 'steve.bucknor@example.com',
         })
 
@@ -25,11 +26,13 @@ class TestSaleCouponCommon(common.TransactionCase):
         self.product_A = self.env['product.product'].create({
             'name': 'Product A',
             'list_price': 100,
+            'sale_ok': True
         })
 
         self.product_B = self.env['product.product'].create({
             'name': 'Product B',
             'list_price': 5,
+            'sale_ok': True
         })
 
         # Immediate Program By A + B: get B free

tests/test_program_rules.py

@@ -74,7 +74,7 @@ class TestProgramRules(TestSaleCouponCommon):
         ]})
         self.assertEqual(len(order.order_line.ids), 2, "The promo offert shouldn't have been applied as the purchased amount is not enough")
 
-        order = self.env['sale.order'].create({'partner_id': self.env.ref('base.res_partner_1').id})
+        order = self.env['sale.order'].create({'partner_id': self.steve.id})
         order.write({'order_line': [
             (0, False, {
                 'product_id': self.product_A.id,
@@ -121,7 +121,7 @@ class TestProgramRules(TestSaleCouponCommon):
             'rule_date_from': Date.to_string((datetime.now() - timedelta(days=7))),
             'rule_date_to': Date.to_string((datetime.now() + timedelta(days=2))),
         })
-        order = self.env['sale.order'].create({'partner_id': self.env.ref('base.res_partner_1').id})
+        order = self.env['sale.order'].create({'partner_id': self.steve.id})
         order.write({'order_line': [
             (0, False, {
                 'product_id': self.product_A.id,