pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] web: SampleServer: fix randomly failing test

Browse Source 
Commit [1] recently tweaked the way floats are generated in the
SampleServer, as they are now rounded to 2 decimals. As a
consequence it sometimes generates integers for float fields (e.g.
5 for 5.00). This is also what the real server does, so it's fine.
However, a test was asserting that float fields were floats, so
this test sometimes failed and thus needed to be adapted.

[1] https://github.com/odoo/odoo/commit/81f2bc7

closes odoo/odoo#63992

Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
This commit is contained in:
Aaron Bohy
2021-01-04 10:37:54 +00:00
parent a85f46df96
commit 338e276fc9
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web/static/tests/views/sample_server_tests.js
+5 -7
View File
@@ -105,13 +105,11 @@ odoo.define('web.sample_server_tests', function (require) {
);
}
}
function assertBetween(fieldName, min, max, decimal = 1) {
function assertBetween(fieldName, min, max, isFloat = false) {
const val = rec[fieldName];
assert.ok(
min <= rec[fieldName] && rec[fieldName] < max &&
rec[fieldName].toString().split(".").length === decimal,
`Field "${fieldName}" is between ${min} and ${max} and is ${
decimal === 1 ? "an integer" : "a float number"
}`
min <= val && val < max && (isFloat || parseInt(val, 10) === val),
`Field "${fieldName}" is between ${min} and ${max} ${!isFloat ? 'and is an integer ' : ''}: ${val}`
);
}
@@ -129,7 +127,7 @@ odoo.define('web.sample_server_tests', function (require) {
assert.ok(SAMPLE_TEXTS.includes(rec.description));
assertFormat('birthday', /\d{4}-\d{2}-\d{2}/);
assertFormat('arrival_date', /\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/);
assertBetween('height', 0, MAX_FLOAT, 2);
assertBetween('height', 0, MAX_FLOAT, true);
assertBetween('color', 0, MAX_COLOR_INT);
assertBetween('age', 0, MAX_INTEGER);
assertBetween('salary', 0, MAX_MONETARY);