[FIX] core: fetch method on compute do not check depends available

Calling `fetch` with computed fields will also check that the dependencies
of those fields are fetched, which is good.
This commit adds a check that verifies that all the dependencies are already
fetched before re-fetching them.

closes odoo/odoo#119247

X-original-commit: 7ab724450c9aa29ad6c1739cff1e928d79666dac
Signed-off-by: Rémy Voet <ryv@odoo.com>
Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>

odoo/addons/test_performance/tests/test_performance.py

@@ -141,6 +141,10 @@ class TestPerformance(SavepointCaseWithUserDemo):
             # 'id' should not be fetched
             records.fetch(['id', 'name', 'partner_id'])
 
+        with self.assertQueryCount(0):
+            # 'display_name' depends on name that should already be fetched
+            records.fetch(['id', 'display_name'])
+
     @warmup
     def test_search_fetch(self):
         """ Search and fetch all at once. """

odoo/models.py

@@ -3411,8 +3411,7 @@ class BaseModel(metaclass=MetaModel):
             return
 
         # determine fields to fetch
-        fields_to_fetch = OrderedSet()
-        cache = self.env.cache
+        fields_to_verify = OrderedSet()
         field_names = self.check_field_access_rights('read', field_names)
         for field_name in field_names:
             if field_name == 'id':
@@ -3420,16 +3419,21 @@ class BaseModel(metaclass=MetaModel):
             field = self._fields.get(field_name)
             if not field:
                 raise ValueError(f"Invalid field {field_name!r} on model {self._name!r}")
-            if not any(cache.get_missing_ids(self, field)):
-                continue
             if field.store:
-                fields_to_fetch.add(field)
+                fields_to_verify.add(field)
             elif field.compute:
                 # optimization: fetch direct field dependencies
                 for dotname in self.pool.field_depends[field]:
                     dep = self._fields[dotname.split('.', 1)[0]]
                     if dep.prefetch is True and (not dep.groups or self.user_has_groups(dep.groups)):
-                        fields_to_fetch.add(dep)
+                        fields_to_verify.add(dep)
+
+        # verifies only once for each stored field or dependency if they are already in cache
+        cache = self.env.cache
+        fields_to_fetch = [
+            field for field in fields_to_verify
+            if any(cache.get_missing_ids(self, field))
+        ]
 
         if not fields_to_fetch:
             # there is nothing to fetch, but we expect an error anyway in case