pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] mail: move field listener code outside of loop when possible

Browse Source 
Some decently costly operations (especially when repeated many times) where done
inside a loop for no reason.

task-2702450

closes odoo/odoo#81187

X-original-commit: c6e4ddf531d29ca1693cc6139b81cea3f5b78fdf
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
This commit is contained in:
Sébastien Theys
2021-12-10 09:39:46 +00:00
parent 97e027f9ff
commit 19996306ec
1 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/mail/static/src/model/model_manager.js
+19 -19
View File
@@ -1224,30 +1224,30 @@ export class ModelManager {
for (const field of Model.__fieldList) {
Object.defineProperty(Model.prototype, field.fieldName, {
get: function getFieldValue() { // this is bound to record
for (const listener of this.modelManager._listeners) {
listener.lastObservedLocalIds.add(this.localId);
if (this.modelManager._listeners.size) {
if (!this.modelManager._listenersObservingLocalId.has(this.localId)) {
this.modelManager._listenersObservingLocalId.set(this.localId, new Map());
}
const entryLocalId = this.modelManager._listenersObservingLocalId.get(this.localId);
const info = {
listener,
reason: `getField - ${field} of ${this}`,
};
if (entryLocalId.has(listener)) {
entryLocalId.get(listener).push(info);
} else {
entryLocalId.set(listener, [info]);
}
const reason = `getField - ${field} of ${this}`;
const entryField = this.modelManager._listenersObservingFieldOfLocalId.get(this.localId).get(field);
if (!listener.lastObservedFieldsByLocalId.has(this.localId)) {
listener.lastObservedFieldsByLocalId.set(this.localId, new Set());
}
listener.lastObservedFieldsByLocalId.get(this.localId).add(field);
if (entryField.has(listener)) {
entryField.get(listener).push(info);
} else {
entryField.set(listener, [info]);
for (const listener of this.modelManager._listeners) {
listener.lastObservedLocalIds.add(this.localId);
const info = { listener, reason };
if (entryLocalId.has(listener)) {
entryLocalId.get(listener).push(info);
} else {
entryLocalId.set(listener, [info]);
}
if (!listener.lastObservedFieldsByLocalId.has(this.localId)) {
listener.lastObservedFieldsByLocalId.set(this.localId, new Set());
}
listener.lastObservedFieldsByLocalId.get(this.localId).add(field);
if (entryField.has(listener)) {
entryField.get(listener).push(info);
} else {
entryField.set(listener, [info]);
}
}
}
return field.get(this);