[FIX] sale: reference in down payment

Make the reference at down payment creation in line with regular invoice
creation as done in:

https://github.com/odoo/odoo/blob/387969f16a60c72d2a85a6df1aea7a04acda5c9f/addons/sale/models/sale.py#L526-L547

opw-2215124

closes odoo/odoo#47633

X-original-commit: aa98750fa4f9b1278eaf7d656c0c1a8c81f86325
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

addons/sale/wizard/sale_make_invoice_advance.py

@@ -72,6 +72,7 @@ class SaleAdvancePaymentInv(models.TransientModel):
 
     def _prepare_invoice_values(self, order, name, amount, so_line):
         invoice_vals = {
+            'ref': order.client_order_ref,
             'move_type': 'out_invoice',
             'invoice_origin': order.name,
             'invoice_user_id': order.user_id.id,
@@ -80,7 +81,7 @@ class SaleAdvancePaymentInv(models.TransientModel):
             'fiscal_position_id': (order.fiscal_position_id or order.fiscal_position_id.get_fiscal_position(order.partner_id.id)).id,
             'partner_shipping_id': order.partner_shipping_id.id,
             'currency_id': order.pricelist_id.currency_id.id,
-            'invoice_payment_ref': order.client_order_ref,
+            'invoice_payment_ref': order.reference,
             'invoice_payment_term_id': order.payment_term_id.id,
             'invoice_partner_bank_id': order.company_id.partner_id.bank_ids[:1].id,
             'team_id': order.team_id.id,