pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] pos_restaurant: selectedTable can change during user input

Browse Source 
In this commit, we make sure that the selectedTable doesn't change
even during the popup is shown to the user. During testing, there might
be rouge clicks that click the .floor-map element which deselects the
selected floor, making the value of this.selectedTable to be false,
causing runtime error.
This commit is contained in:
Joseph Caburnay
2020-08-19 07:34:04 +00:00
parent e2cac83394
commit 18651864dd
1 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/pos_restaurant/static/src/js/Screens/FloorScreen/FloorScreen.js
+13 -11
View File
@@ -87,17 +87,18 @@ odoo.define('pos_restaurant.FloorScreen', function (require) {
}
}
async _changeSeatsNum() {
if (!this.selectedTable) return;
const selectedTable = this.selectedTable
if (!selectedTable) return;
const { confirmed, payload: inputNumber } = await this.showPopup('NumberPopup', {
startingValue: this.selectedTable.seats,
startingValue: selectedTable.seats,
cheap: true,
title: this.env._t('Number of Seats ?'),
});
if (!confirmed) return;
const newSeatsNum = parseInt(inputNumber, 10) || this.selectedTable.seats;
if (newSeatsNum !== this.selectedTable.seats) {
this.selectedTable.seats = newSeatsNum;
await this._save(this.selectedTable);
const newSeatsNum = parseInt(inputNumber, 10) || selectedTable.seats;
if (newSeatsNum !== selectedTable.seats) {
selectedTable.seats = newSeatsNum;
await this._save(selectedTable);
}
}
async _changeShape() {
@@ -107,15 +108,16 @@ odoo.define('pos_restaurant.FloorScreen', function (require) {
await this._save(this.selectedTable);
}
async _renameTable() {
if (!this.selectedTable) return;
const selectedTable = this.selectedTable;
if (!selectedTable) return;
const { confirmed, payload: newName } = await this.showPopup('TextInputPopup', {
startingValue: this.selectedTable.name,
startingValue: selectedTable.name,
title: this.env._t('Table Name ?'),
});
if (!confirmed) return;
if (newName !== this.selectedTable.name) {
this.selectedTable.name = newName;
await this._save(this.selectedTable);
if (newName !== selectedTable.name) {
selectedTable.name = newName;
await this._save(selectedTable);
}
}
async _setTableColor({ detail: color }) {