pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] hr_holidays: incorrect number_of_hours_display

Browse Source 
- Go to Settings > Technical > Resource > Working Times
- Have a Resource Calendar RC with Average hour per day != 8.00
- Have an Employee E with Working Hours == RC
- Leaves > Configuration > Leave Types
- Have a Leave Type LT with Take Leaves in Hours
- Leaves > Managers > All > Allocations
- Create an Allocation A with Employee E and Leave Type LT
- Enter any number in Duration

The number of hours entered changes as we leave the field.

Being totally honest, what happens here is not clear at all, but using
the corresponding `resource_id.calendar_id` field seems to fix the
problem.

opw-2191795

closes odoo/odoo#44903

X-original-commit: e239b354da9fa072e03e4d1186927fa3d74bcfe6
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
This commit is contained in:
Nicolas Martinelli
2020-02-07 17:15:29 +00:00
parent 73c6863d3a
commit 16525d5b56
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/hr_holidays/models/hr_leave_allocation.py
+1 -1
View File
@@ -257,7 +257,7 @@ class HolidaysAllocation(models.Model):
if allocation.parent_id and allocation.parent_id.type_request_unit == "hour":
allocation.number_of_hours_display = allocation.number_of_days * HOURS_PER_DAY
else:
allocation.number_of_hours_display = allocation.number_of_days * (allocation.employee_id.sudo().resource_calendar_id.hours_per_day or HOURS_PER_DAY)
allocation.number_of_hours_display = allocation.number_of_days * (allocation.employee_id.sudo().resource_id.calendar_id.hours_per_day or HOURS_PER_DAY)
@api.depends('number_of_hours_display', 'number_of_days_display')
def _compute_duration_display(self):