[FIX] spreadsheet_dashboard: unskip expense dashboard test

The test was skipped because the expense dashboard was broken when
the test was merged.
See https://github.com/odoo/odoo/commit/17afe2987e4146b85187b31a34caf7146d5a7cf2

closes odoo/odoo#109033

X-original-commit: 4d4c192e0994ff7849641499b728fe228ae66a4d
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

addons/spreadsheet_dashboard/tests/test_dashboard_data.py

@@ -10,12 +10,5 @@ class TestSpreadsheetDashboardData(ValidateSpreadsheetData):
         """validate fields and models used in dashboards"""
         dashboards = self.env["spreadsheet.dashboard"].search([])
         for dashboard in dashboards:
-            # this dashboard is skipped because it's currently broken
-            # but I still want to merge this test right now to avoid other broken dashboards
-            if dashboard == self.env.ref(
-                "spreadsheet_dashboard_hr_expense.spreadsheet_dashboard_expense",
-                raise_if_not_found=False,
-            ):
-                continue
             with self.subTest(dashboard.name):
                 self.validate_spreadsheet_data(dashboard.raw, dashboard.name)

addons/spreadsheet_dashboard_hr_expense/data/files/expense_dashboard.json

@@ -1233,10 +1233,6 @@
                 "8": {
                     "field": "product_id",
                     "type": "many2one"
-                },
-                "9": {
-                    "field": "product_id",
-                    "type": "many2one"
                 }
             },
             "listFields": {
@@ -1337,10 +1333,6 @@
                 "8": {
                     "field": "employee_id",
                     "type": "many2one"
-                },
-                "9": {
-                    "field": "employee_id",
-                    "type": "many2one"
                 }
             },
             "listFields": {