pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[REV] Revert "[FIX] web: add access group to the pdf js template."

Browse Source 
This reverts commit odoo/odoo@681306d4e7.

Adding groups on assets parts is not a good idea. Indeed as assets are
compiled and optimized we do not want to serve different assets to different
users.

For example if you have several users in parallel on several workers those
could try to regenerate assets for their users. As each user has different
assets this could lead to big performance issue.

As original commit tried to solve a race condition we can safely remove the
assets fix to avoid issues and work on a cleaner solution.

See original ref odoo/odoo#51804 and odoo/enterprise#10737

This also solves an issue notably in website_slides where access to pdfjs
library was depending on connected users, due to assets mismatch. See
task ID-2352391 .

closes odoo/odoo#59610

X-original-commit: 000af2688e32d19b1874df2e909ccf0ddf636b91
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
This commit is contained in:
Thibault Delavallée
2020-10-09 11:17:29 +00:00
parent d2e6015ce0
commit 131cc12227
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web/views/webclient_templates.xml
+1 -1
View File
@@ -891,7 +891,7 @@
For now, it is only use to display the PDF slide Viewer during an embed.
Bundlized, the size is reduced to 5300≈ lines.
-->
<template id="pdf_js_lib" groups="base.group_user" name="PDF JS Library">
<template id="pdf_js_lib" name="PDF JS Library">
<script type="text/javascript" src="/web/static/lib/pdfjs/build/pdf.js"></script>
<script type="text/javascript" src="/web/static/lib/pdfjs/build/pdf.worker.js"></script>
</template>