[FIX] microsoft_account: raise the Badrequest if the post data doesn't available

[FIX] microsoft_account: accessing the url without any post data
When a user tries to access the URL directly, at that time the value of
dictionary `kw` is not available. So the error will be generated.

Error : KeyError: `state`

This commit will solve the above issue by raising the `BadRequest` if the value
of dictionary `kw` does not available.

sentry-4377121133

closes odoo/odoo#157720

X-original-commit: 382b64c2f14073cfff1a8ef9290b5c7834d52188
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
This commit is contained in:
Archana Vaghasiya
2024-03-15 06:12:46 +00:00
committed by Mahamadasif Ansari
parent 5921dc9c8c
commit 114f09ba98
+4 -2
View File
@@ -2,6 +2,7 @@
# Part of Odoo. See LICENSE file for full copyright and licensing details.
import json
from werkzeug.exceptions import BadRequest
from odoo import http
from odoo.http import request
@@ -12,10 +13,11 @@ class MicrosoftAuth(http.Controller):
@http.route('/microsoft_account/authentication', type='http', auth="public")
def oauth2callback(self, **kw):
""" This route/function is called by Microsoft when user Accept/Refuse the consent of Microsoft """
state = json.loads(kw['state'])
dbname = state.get('d')
state = json.loads(kw.get('state', '{}'))
service = state.get('s')
url_return = state.get('f')
if (not service or (kw.get('code') and not url_return)):
raise BadRequest()
if kw.get('code'):
access_token, refresh_token, ttl = request.env['microsoft.service']._get_microsoft_tokens(kw['code'], service)