pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] payment: various fixes related to payment tokens

Browse Source 
- The name of the field `provider_id` on `payment.token` should not be
  "provider Account" but "Provider".
- The computation of the display name of tokens crashed when the field
  `payment_details` was empty.
- The form view of tokens missed a <group/> element to better display
  the fields.

closes odoo/odoo#103621

X-original-commit: ae4079807d29996f4edfd295dcfa194973ada8db
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
This commit is contained in:
Antoine Vandevenne (anv)
2022-10-20 16:15:54 +02:00
parent b7dfc7f71c
commit 107de3fceb
2 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/payment/models/payment_token.py
+2 -3
View File
@@ -11,8 +11,7 @@ class PaymentToken(models.Model):
_order = 'partner_id, id desc'
_description = 'Payment Token'
provider_id = fields.Many2one(
string="provider Account", comodel_name='payment.provider', required=True)
provider_id = fields.Many2one(string="Provider", comodel_name='payment.provider', required=True)
provider_code = fields.Selection(related='provider_id.code')
payment_details = fields.Char(
string="Payment Details", help="The clear part of the payment method's payment details.",
@@ -113,7 +112,7 @@ class PaymentToken(models.Model):
"""
self.ensure_one()
padding_length = max_length - len(self.payment_details)
padding_length = max_length - len(self.payment_details or '')
if not self.payment_details:
create_date_str = self.create_date.strftime('%Y/%m/%d')
display_name = _("Payment details saved on %(date)s", date=create_date_str)
addons/payment/views/payment_token_views.xml
+10 -8
View File
@@ -15,14 +15,16 @@
</button>
</div>
<widget name="web_ribbon" title="Archived" bg_color="bg-danger" attrs="{'invisible': [('active', '=', True)]}"/>
<group name="general_information">
<field name="payment_details"/>
<field name="partner_id" />
</group>
<group name="technical_information">
<field name="provider_id"/>
<field name="provider_ref"/>
<field name="company_id" groups="base.group_multi_company"/>
<group>
<group name="general_information">
<field name="payment_details"/>
<field name="partner_id" />
</group>
<group name="technical_information">
<field name="provider_id"/>
<field name="provider_ref"/>
<field name="company_id" groups="base.group_multi_company"/>
</group>
</group>
</sheet>
</form>