[FIX] sms: do not display popover for void notification

PURPOSE

Improve SMS UX integration. Followup of merge 4287481 .

SPECIFICATIONS

Fix recent SMS merge: do not display tooltip / popover about SMS information
in chatter if there was no recipients linked to the SMS message.

LINKS

Task 1922187
This commit is contained in:
Thibault Delavallée
2019-07-23 08:29:15 +00:00
parent 7ef11e3c96
commit 0cc6390db5
2 changed files with 9 additions and 1 deletions
+8
View File
@@ -32,6 +32,14 @@ Message.include({
});
return this._smsStatus;
},
/**
* Whether message has nay SMS-related notification
*
* @returns {boolean}
*/
hasSmsData: function () {
return !!(this._smsIds && (this._smsIds.length > 0));
},
/**
* Does the message contains at least one SMS failure
*
+1 -1
View File
@@ -3,7 +3,7 @@
<t t-extend="mail.widget.Thread.Message">
<t t-jquery=".o_thread_tooltip_container" t-operation="after">
<span t-if="message.getType() === 'sms' and options.displaySmsIcons" class="o_thread_sms_tooltip_container">
<span t-if="message.getType() === 'sms' and message.hasSmsData() and options.displaySmsIcons" class="o_thread_sms_tooltip_container">
<t t-set="thread_icon_class" t-value="'o_thread_sms_tooltip o_thread_message_sms o_thread_message_sms_' + message.getSmsStatus()" />
<i t-attf-class="o_thread_sms_tooltip o_thread_message_sms o_thread_message_sms_#{message.getSmsStatus()} #{message.isError() ? 'o_thread_message_sms_error' : ''} fa fa-comment"
t-att-data-message-id="message.getID()"/>