[FIX] web_editor: do not call onBlur/onFocus on active snippet click

Before this commit, when clicking inside a snippet which is already
enabled, it was disabled then re-enabled... which had the side effect
of calling onBlur/onFocus methods. This can be a problem with some
onFocus/onBlur implementation relying on the old behavior.

Note: this commit restores the exact same behavior as before. If an
internal snippet of the active one is clicked, then we still call the
onBlur then onFocus for the old active one (the parent) as the actual
enabled snippet changed (even if it is simply a child snippet).

closes odoo/odoo#39261

X-original-commit: 076992bdf099f3a645c9a1ef6df2cdcccbf1c2b2
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

addons/web_editor/static/src/js/editor/snippets.editor.js

@@ -1039,23 +1039,34 @@ var SnippetsMenu = Widget.extend({
      */
     _activateSnippet: function ($snippet, previewMode) {
         return this._activateSnippetMutex.exec(() => {
-            // First disable all editors if necessary
-            this.snippetEditors.forEach(editor => {
-                editor.toggleFocus(false, previewMode);
-            });
-            // Take the first parent of the provided DOM (or itself) which
-            // should have an associated snippet editor and create + enable it.
-            if ($snippet && $snippet.length) {
-                $snippet = globalSelector.closest($snippet);
-                if (!$snippet.length) {
-                    return Promise.resolve(null);
+            return new Promise(resolve => {
+                // Take the first parent of the provided DOM (or itself) which
+                // should have an associated snippet editor and create + enable it.
+                if ($snippet && $snippet.length) {
+                    $snippet = globalSelector.closest($snippet);
+                    if ($snippet.length) {
+                        return this._createSnippetEditor($snippet).then(resolve);
+                    }
                 }
-                return this._createSnippetEditor($snippet).then(editor => {
-                    editor.toggleFocus(true, previewMode);
-                    return editor;
+                resolve(null);
+            }).then(editorToEnable => {
+                // First disable all editors...
+                this.snippetEditors.forEach(editor => {
+                    if (editor === editorToEnable) {
+                        // Avoid disable -> enable of an editor (the toggleFocus
+                        // method is in charge of doing nothing is nothing has
+                        // to be done but if we explicitly ask for disable then
+                        // enable... it will disable then enable).
+                        return;
+                    }
+                    editor.toggleFocus(false, previewMode);
                 });
-            }
-            return Promise.resolve(null);
+                // ... then enable the right editor
+                if (editorToEnable) {
+                    editorToEnable.toggleFocus(true, previewMode);
+                }
+                return editorToEnable;
+            });
         });
     },
     /**