pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] web: bad conversion from ES6 to ES5

Browse Source 
We had to manually convert the unhandled-rejection-polyfill lib,
and we forgot to replace this by self in two arrow functions.
This was causing crashes e.g. on Firefox.

We also forgot some uses of const, which is not really an issue as
const is supported on all browsers, but it is not ES5.

Issue reported on the jquery update pad.

closes odoo/odoo#31658

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
This commit is contained in:
Aaron Bohy
2019-03-07 10:44:20 +00:00
parent fc60c49ba3
commit 0bae5e2402
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web/static/lib/unhandled-rejection-polyfill/unhandled-rejection-polyfill.js
+9 -7
View File
@@ -2,11 +2,11 @@
(function () {
"use strict";
const self = window;
const OriginalPromise = self.Promise;
var self = window;
var OriginalPromise = self.Promise;
function dispatchUnhandledRejectionEvent(promise, reason) {
const event = document.createEvent('Event');
var event = document.createEvent('Event');
Object.defineProperties(event, {
promise: {
value: promise,
@@ -25,8 +25,8 @@ function MyPromise(resolver) {
if (!(this instanceof MyPromise)) {
throw new TypeError('Cannot call a class as a function');
}
const promise = new OriginalPromise(function (resolve, reject) {
const customReject = function (reason) {
var promise = new OriginalPromise(function (resolve, reject) {
var customReject = function (reason) {
// macro-task (setTimeout) will execute after micro-task (promise)
setTimeout(function () {
if (promise.handled !== true) {
@@ -50,15 +50,17 @@ MyPromise.prototype.__proto__ = OriginalPromise.prototype;
MyPromise.prototype.then = function (resolve, reject) {
var self = this;
return OriginalPromise.prototype.then.call(this, resolve, reject && (function reason() {
this.handled = true;
self.handled = true;
return reject(reason);
}));
};
MyPromise.prototype.catch = function (reject) {
var self = this;
return OriginalPromise.prototype.catch.call(this, reject && (function reason() {
this.handled = true;
self.handled = true;
return reject(reason);
}));
};