pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] sales: set invoice company to so one in sale.advance.payment.inv

Browse Source 
Prior to this commit, the company of the invoices generated through the use
of the `sale.advance.payment.inv` wizzard were not forced to the one of the
related sales orders. From the compute method on account.move the company would
then be either the one of the journal or the current company.

It seems that context_keys were used 'at least in industry_fsm_sale' in order
to ensure that the company was correctly set (although the one of the task
was used instead of the one of the SO).

This commit ensures that invoices created through the wizzard now takes the company
of the SO they are generated from.

Finaly this commit adds a multicompany test in the sale module in order to ensure
that the `sale.advance.payment.inv` wizzard is not impacted by the multicompany.

task-2608812
Closes: #79926
This commit is contained in:
Laurent Stukkens (LTU)
2022-01-03 18:11:00 +00:00
parent dd493cd6c4
commit 04f8b7dfa9
1 changed files with 35 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/sale/tests/test_sale_to_invoice.py
+35
View File
@@ -370,3 +370,38 @@ class TestSaleToInvoice(TestSaleCommon):
qty_invoiced_field = sol_prod_deliver._fields.get('qty_invoiced')
sol_prod_deliver.env.add_to_compute(qty_invoiced_field, sol_prod_deliver)
self.assertEqual(sol_prod_deliver.qty_invoiced, expected_qty)
def test_multi_company_invoice(self):
"""Checks that the company of the invoices generated in a multi company environment using the
'sale.advance.payment.inv' wizard fit with the company of the SO and not with the current company.
"""
so_company_id = self.sale_order.company_id.id
yet_another_company_id = self.company_data_2['company'].id
so_for_downpayment = self.sale_order.copy()
self.context.update(allowed_company_ids=[yet_another_company_id, self.env.company.id], company_id=yet_another_company_id)
context_for_downpayment = self.context.copy()
context_for_downpayment.update(active_ids=[so_for_downpayment.id], active_id=so_for_downpayment.id)
# Make sure the invoice is not created with a journal in the context
# Because it makes the test always succeed (by using the journal company instead of the env company)
no_journal_ctxt = dict(self.context)
no_journal_ctxt.pop('default_journal_id', None)
no_journal_ctxt.pop('journal_id', None)
self.sale_order.with_context(self.context).action_confirm()
payment = self.env['sale.advance.payment.inv'].with_context(no_journal_ctxt).create({
'advance_payment_method': 'percentage',
'amount': 50,
})
payment.create_invoices()
self.assertEqual(self.sale_order.invoice_ids[0].company_id.id, so_company_id, "The company of the invoice should be the same as the one from the SO")
so_for_downpayment.with_context(context_for_downpayment).action_confirm()
downpayment = self.env['sale.advance.payment.inv'].with_context(context_for_downpayment).create({
'advance_payment_method': 'fixed',
'fixed_amount': 50,
'deposit_account_id': self.company_data['default_account_revenue'].id
})
downpayment.create_invoices()
self.assertEqual(so_for_downpayment.invoice_ids[0].company_id.id, so_company_id, "The company of the downpayment invoice should be the same as the one from the SO")