pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] mail: new messages extra domain

Browse Source 
A default MAX(id) was added in the extraDomain when there are no messages
to create it. This validation already existed but was omitted in the
refactoring - https://github.com/odoo/odoo/pull/57061

Current behavior before PR:

If there are no messageIds, the method loadNewMessages returns id > null
and this domain returns 0 records

https://github.com/odoo/odoo/blob/7d992af9561c499ef1912453f3b697bad18e441f/addons/mail/static/src/models/thread_cache/thread_cache.js#L55

Desired behavior after PR is merged:

Create the extraDomain with a default MAX(id) when there are no messages
to create it and continue with the normal flow of loadMessages

closes odoo/odoo#91701

X-original-commit: dad6595ab08ccacefa1373a3fc97a729907d7d32
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
This commit is contained in:
imanie383
2022-05-18 22:56:40 +02:00
committed by Alexandre Kühn
parent 3303afec66
commit 003ff45f75
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/mail/static/src/models/thread_cache.js
+1 -1
View File
@@ -53,7 +53,7 @@ registerModel({
return;
}
const messageIds = this.fetchedMessages.map(message => message.id);
const fetchedMessages = this._loadMessages({ minId: Math.max(...messageIds) });
const fetchedMessages = this._loadMessages({ minId: Math.max(...messageIds, 0) });
if (!fetchedMessages || fetchedMessages.length === 0) {
return;
}