Aaron Bohy
f31214aeaa
Those fields are no longer used since all client actions and the studio report editor have been converted to owl. Part of task~3439226 closes odoo/odoo#130462 Related: odoo/enterprise#45015 Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>
65 lines
2.9 KiB
JavaScript
65 lines
2.9 KiB
JavaScript
/** @odoo-module **/
|
|
|
|
/**
|
|
* @param {string} folder folder that can only import from `allowedFolders`
|
|
* @param {string[]} allowedFolders folders from which `folder` can import
|
|
* @returns {{[key: string]: string[]}} an object where the keys are modules and
|
|
* the values are an array of imports that the module is not allowed to import
|
|
*/
|
|
function invalidImportsFrom(folder, allowedFolders) {
|
|
// modules within a folder can always depend on one another
|
|
allowedFolders.push(folder);
|
|
const modulesToCheck = Object.keys(odoo.__DEBUG__.services).filter((module) =>
|
|
module.startsWith(`@web/${folder}/`)
|
|
);
|
|
const invalidDeps = {};
|
|
for (const module of modulesToCheck) {
|
|
const invalid = odoo.__DEBUG__.getDependencies(module).filter((dep) => {
|
|
// owl and @web/session are allowed everywhere
|
|
if (dep === "@odoo/owl" || dep === "@web/session") {
|
|
return false;
|
|
}
|
|
return !allowedFolders.some((allowed) => dep.startsWith(`@web/${allowed}/`));
|
|
});
|
|
if (invalid.length) {
|
|
invalidDeps[module] = invalid;
|
|
}
|
|
}
|
|
return invalidDeps;
|
|
}
|
|
|
|
QUnit.module("module dependencies", {}, () => {
|
|
QUnit.test("modules only import from allowed folders", (assert) => {
|
|
// Using deepEqual with {} in this test to get a good diff view when failing
|
|
assert.deepEqual(
|
|
invalidImportsFrom("core", []),
|
|
// FIXME: this dependency should not exist. Temporarily whitelist it so we don't add more, and remove ASAP
|
|
{ "@web/core/utils/hooks": ["@web/env"] },
|
|
"Core modules don't depend on any other folder"
|
|
);
|
|
assert.deepEqual(
|
|
invalidImportsFrom("search", ["core"]),
|
|
// FIXME: this dependency should not exist. Temporarily whitelist it so we don't add more, and remove ASAP
|
|
{ "@web/search/with_search/with_search": ["@web/webclient/actions/action_hook"] },
|
|
"Search modules only depend on core"
|
|
);
|
|
assert.deepEqual(
|
|
invalidImportsFrom("model", ["core", "search"]),
|
|
// FIXME: this dependency should not exist. Temporarily whitelist it so we don't add more, and remove ASAP
|
|
{ "@web/model/model": ["@web/views/view_hook"] },
|
|
"Model modules only depend on core and search"
|
|
);
|
|
assert.deepEqual(
|
|
invalidImportsFrom("views", ["core", "search", "model"]),
|
|
// FIXME: these dependencies should not exist. Temporarily whitelist them so we don't add more, and remove ASAP
|
|
{
|
|
"@web/views/fields/many2one/many2one_field": [
|
|
"@web/webclient/barcode/barcode_scanner",
|
|
],
|
|
"@web/views/view_hook": ["@web/webclient/actions/action_hook"],
|
|
},
|
|
"View modules only depend on core, search and model"
|
|
);
|
|
});
|
|
});
|