Benjamin Vray
aca20be33f
After the following steps, snippets overlays are not properly removed from the DOM: - In edit mode, drop 2-3 snippets in the page. - Click on these snippets to activate their overlays. - Drag and drop a popup in the page. - Drag and drop a snippet in the popup. - Move this snippet inside the popup thanks to the move handle button. - Click on the "eye" button to hide the popup. - Click on snippets of the page, the overlays are no longer removed when they should. It was because since commit [1], it is allowed to define an element in which '_destroyEditors' destroys the editors but we forgot not to completely empty the array that contains them. But anyway, the editors list does not need to be updated in '_destroyEditors' since commit [2] as it is already done in the 'destroy' method of 'SnippetEditor'. [1]: https://github.com/odoo/odoo/commit/b7d522e9e7e31ac6bf926aae65e58d9f6cfa8903 [2]: https://github.com/odoo/odoo/commit/2a19a83762c1bc74dd7336378d254ab6da8e3a22 task-2799602 closes odoo/odoo#96267 X-original-commit: 0e97847cf42db935522f5f834f6fcb86de02eae3 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>