arsi
42859bed9c
Traceback when computing taxes using TaxCloud.
Steps to reproduce:
-Activate TaxCloud in accounting settings, with valids "API ID" and
"API KEY".
-Create an invoice for a USA customer with an invoice line and
"Fiscal Position" set to "Automatic Tax Mapping (TaxCloud)" (in the
"Other Info" tab).
-Confirm
-->Traceback
Traceback:
File
"/src/enterprise/16.0/account_taxcloud/models/taxcloud_request.py",
line 136, in get_all_taxes_values
for item in response.CartItemsResponse.CartItemResponse:
AttributeError: 'NoneType' object has no attribute 'CartItemResponse
Explanation:
-There's a traceback when CartItem is empty (like if there are no move
lines).
-It is empty because of the filter in the function
'_process_lines(self, lines)'.
--> 'lines.filtered(lambda l: not l.display_type)'.
-The goal is to take only move lines that are not Notes or Sections.
-This worked in v15 because display_type was defined as:
display_type = fields.Selection([
('line_section', 'Section'),
('line_note', 'Note'),
], default=False, help="Technical field for UX purpose.")
-But now in v16 it is defined as:
display_type = fields.Selection(
selection=[
('product', 'Product'),
('cogs', 'Cost of Goods Sold'),
('tax', 'Tax'),
('rounding', "Rounding"),
('payment_term', 'Payment Term'),
('line_section', 'Section'),
('line_note', 'Note'),
('epd', 'Early Payment Discount'),
],
compute='_compute_display_type', store=True, readonly=False,
precompute=True, required=True,
)
-The display_type=False does not corresponds anymore to move lines
that are not Sections or Notes, but it corresponds to no move lines at
all.
The fix:
Will filter move lines that are not of type 'line_section' or
'line_note'.
Discussion:
Do I fix the traceback that we get when there a no move lines? This
'issue' is present since at least v14 and it seems like nobody ever
complained.
+:
I've applied the similar change to some lines in the code that also
check if 'display_type' is False for some 'account.move.line' records.
++:
The fix revealed an other issue in the function
'_inter_company_create_invoices' of the file
enterprise/account_inter_company_rules/models/account_move.py:
There's a call on a function that doesn't exist anymore
'line._set_price_and_tax_after_fpos()'. I've deleted the line.
opw-3064174
closes odoo/odoo#106452
X-original-commit: 8bfca5832adaf9e147f2443d0bf56cf921f9ff0c
Related: odoo/enterprise#34352
Signed-off-by: William André (wan) <wan@odoo.com>
94 lines
3.8 KiB
Python
94 lines
3.8 KiB
Python
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
import base64
|
|
import io
|
|
import re
|
|
import xlwt
|
|
|
|
from odoo import fields, models
|
|
from odoo.tools.misc import format_date
|
|
|
|
|
|
COLUMN_HEADER_MAP = {
|
|
"Reporting_Month": "invoice_date",
|
|
"Vendor_TIN": "vat",
|
|
"branchCode": "branch_code",
|
|
"companyName": "company_name",
|
|
"surName": "last_name",
|
|
"firstName": "first_name",
|
|
"middleName": "middle_name",
|
|
"address": "address",
|
|
"nature": "product_name",
|
|
"ATC": "atc",
|
|
"income_payment": "price_subtotal",
|
|
"ewt_rate": "amount",
|
|
"tax_amount": "tax_amount",
|
|
}
|
|
|
|
class Generate2307Wizard(models.TransientModel):
|
|
_name = "l10n_ph_2307.wizard"
|
|
_description = "Exports 2307 data to a XLS file."
|
|
|
|
moves_to_export = fields.Many2many("account.move", string="Joural To Include")
|
|
generate_xls_file = fields.Binary(
|
|
"Generated file",
|
|
help="Technical field used to temporarily hold the generated XLS file before its downloaded."
|
|
)
|
|
|
|
def _write_single_row(self, worksheet, worksheet_row, values):
|
|
for index, field in enumerate(COLUMN_HEADER_MAP.values()):
|
|
worksheet.write(worksheet_row, index, label=values[field])
|
|
|
|
def _write_rows(self, worksheet, moves):
|
|
worksheet_row = 0
|
|
for move in moves:
|
|
worksheet_row += 1
|
|
partner = move.partner_id
|
|
partner_address_info = [partner.street, partner.street2, partner.city, partner.state_id.name, partner.country_id.name]
|
|
values = {
|
|
'invoice_date': format_date(self.env, move.invoice_date, date_format="MM/dd/yyyy"),
|
|
'vat': re.sub(r'\-', '', partner.vat)[:9] if partner.vat else '',
|
|
'branch_code': partner.branch_code or '000',
|
|
'company_name': partner.commercial_partner_id.name,
|
|
'first_name': partner.first_name or '',
|
|
'middle_name': partner.middle_name or '',
|
|
'last_name': partner.last_name or '',
|
|
'address': ', '.join([val for val in partner_address_info if val])
|
|
}
|
|
for invoice_line in move.invoice_line_ids.filtered(lambda l: l.display_type not in ('line_note', 'line_section')):
|
|
for tax in invoice_line.tax_ids.filtered(lambda x: x.l10n_ph_atc):
|
|
values['product_name'] = re.sub(r'[\(\)]', '', invoice_line.product_id.name)
|
|
values['atc'] = tax.l10n_ph_atc
|
|
values['price_subtotal'] = invoice_line.price_subtotal
|
|
values['amount'] = tax.amount
|
|
values['tax_amount'] = tax._compute_amount(invoice_line.price_subtotal, invoice_line.price_unit)
|
|
self._write_single_row(worksheet, worksheet_row, values)
|
|
worksheet_row += 1
|
|
|
|
def action_generate(self):
|
|
""" Generate a xls format file for importing to
|
|
https://bir-excel-uploader.com/excel-file-to-bir-dat-format/#bir-form-2307-settings.
|
|
This website will then generate a BIR 2307 format excel file for uploading to the
|
|
PH government.
|
|
"""
|
|
self.ensure_one()
|
|
|
|
file_data = io.BytesIO()
|
|
workbook = xlwt.Workbook(encoding='utf-8')
|
|
worksheet = workbook.add_sheet('Form2307')
|
|
|
|
for index, col_header in enumerate(COLUMN_HEADER_MAP.keys()):
|
|
worksheet.write(0, index, label=col_header)
|
|
|
|
self._write_rows(worksheet, self.moves_to_export)
|
|
|
|
workbook.save(file_data)
|
|
file_data.seek(0)
|
|
self.generate_xls_file = base64.b64encode(file_data.read())
|
|
|
|
return {
|
|
"type": "ir.actions.act_url",
|
|
"target": "self",
|
|
"url": "/web/content?model=l10n_ph_2307.wizard&download=true&field=generate_xls_file&filename=Form_2307.xls&id={}".format(self.id),
|
|
}
|