Files
odoo_source/addons/hr_expense/models/res_config_settings.py
T
Thibault Delavallée 5eca7b7378 [REF] hr_expense: cleanup alias management
Purpose of this commit is to cleanup alias usage in hr_expense. Indeed it
is currently used as a master data without being cleanly supported.

In this commit we

  * globally avoid crashes if the alias data has been removed;
  * recreate Xml ID record if it has been removed as it is considered as
    being a master data;
  * avoid issues when trying to configure the expense alias in settings if
    alias has been manually removed. Setting a name now creates the alias
    and an XmlID if it has been removed;
  * rename a generic 'use_mail_gateway' field into 'expense_use_mail_gateway'
    in order to avoid conflicts with future changes in generic settings linked
    to email gateway and configuration
  * fix empty list helper: it is now translated and correctly encode parameters
    given to 'mailto';

Task-2710804 (Mail: Clean MailThread Posting API)
Prepares Task-36879 (Mail: Support MultiCompany Aliases)

Part-of: odoo/odoo#105992
2022-11-18 13:59:53 +01:00

53 lines
2.4 KiB
Python

# -*- coding: utf-8 -*-
from odoo import api, fields, models
class ResConfigSettings(models.TransientModel):
_inherit = 'res.config.settings'
hr_expense_alias_prefix = fields.Char(
'Default Alias Name for Expenses',
compute='_compute_hr_expense_alias_prefix',
store=True,
readonly=False)
hr_expense_use_mailgateway = fields.Boolean(string='Let your employees record expenses by email',
config_parameter='hr_expense.use_mailgateway')
module_hr_payroll_expense = fields.Boolean(string='Reimburse Expenses in Payslip')
module_hr_expense_extract = fields.Boolean(string='Send bills to OCR to generate expenses')
expense_journal_id = fields.Many2one('account.journal', related='company_id.expense_journal_id', readonly=False)
company_expense_journal_id = fields.Many2one('account.journal', related='company_id.company_expense_journal_id', readonly=False)
@api.model
def get_values(self):
res = super(ResConfigSettings, self).get_values()
expense_alias = self.env.ref('hr_expense.mail_alias_expense', raise_if_not_found=False)
res.update(
hr_expense_alias_prefix=expense_alias.alias_name if expense_alias else False,
)
return res
def set_values(self):
super().set_values()
expense_alias = self.env.ref('hr_expense.mail_alias_expense', raise_if_not_found=False)
if not expense_alias and self.hr_expense_alias_prefix:
# create data again
alias = self.env['mail.alias'].sudo().create({
'alias_contact': 'employees',
'alias_model_id': self.env['ir.model']._get_id('hr.expense'),
'alias_name': self.hr_expense_alias_prefix,
})
self.env['ir.model.data'].sudo().create({
'name': 'mail_alias_expense',
'module': 'hr_expense',
'model': 'mail.alias',
'noupdate': True,
'res_id': alias.id,
})
elif expense_alias and expense_alias.alias_name != self.hr_expense_alias_prefix:
expense_alias.alias_name = self.hr_expense_alias_prefix
@api.depends('hr_expense_use_mailgateway')
def _compute_hr_expense_alias_prefix(self):
self.filtered(lambda w: not w.hr_expense_use_mailgateway).hr_expense_alias_prefix = False