Denis Ledoux
3752b3166e
There are three rationales behind this change to set USD as default currency and to enable it in the demo data, from the beginning. With a demo database, before this revision: 1. On runbot, with all modules installed, it's already USD the default company currency. It's only when you install a module not depending on account that it's EUR the company currency by default (e.g. CRM) 2. in the base demo data, the company is set in the United States but with the currency EUR, 3. before installing account, the company currency is EUR, after installing account, the company currency is USD, this is due to the fact as the company is in the United States, the US Chart Of Account is installed, switching the company currency to USD. 4. when you install a demo database with a module not depending on account, you are left with a database without any active currency, and the monetary fields therefore do not show any currency. For instance, install only CRM with demo, you have no currency symbol before or after the expected revenue, which is not the best user friendly experience. On runbot you do not feel it because all modules are installed, therefore with account installed, which activated the USD currency. Additional weird thing with point 2.: - Unit tests in modules not dependent on account with the post-install tag had to handle this sudden change of currency change before and after installing account. For instance, when running their unit tests with only their module, but not account, the company currency is EUR, but when executing the same unit test with all modules installed, the company currency is USD. The unit tests had to handle this sudden change within the unit test, for instance by setting a 1.0 rate for their own company currency, which shouldn't be the case: the rate of your own currency should always be 1.0. closes odoo/odoo#107113 Related: odoo/enterprise#34613 Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>
304 lines
13 KiB
Python
304 lines
13 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
from odoo.tests import common, Form
|
|
from odoo.tools import float_compare
|
|
|
|
|
|
@common.tagged('post_install', '-at_install')
|
|
class TestDeliveryCost(common.TransactionCase):
|
|
|
|
def setUp(self):
|
|
super(TestDeliveryCost, self).setUp()
|
|
self.SaleOrder = self.env['sale.order']
|
|
self.SaleOrderLine = self.env['sale.order.line']
|
|
self.AccountAccount = self.env['account.account']
|
|
self.SaleConfigSetting = self.env['res.config.settings']
|
|
self.Product = self.env['product.product']
|
|
|
|
self.partner_18 = self.env['res.partner'].create({'name': 'My Test Customer'})
|
|
self.pricelist = self.env.ref('product.list0')
|
|
self.product_4 = self.env['product.product'].create({'name': 'A product to deliver'})
|
|
self.product_uom_unit = self.env.ref('uom.product_uom_unit')
|
|
self.product_delivery_normal = self.env['product.product'].create({
|
|
'name': 'Normal Delivery Charges',
|
|
'type': 'service',
|
|
'list_price': 10.0,
|
|
'categ_id': self.env.ref('delivery.product_category_deliveries').id,
|
|
})
|
|
self.normal_delivery = self.env['delivery.carrier'].create({
|
|
'name': 'Normal Delivery Charges',
|
|
'fixed_price': 10,
|
|
'delivery_type': 'fixed',
|
|
'product_id': self.product_delivery_normal.id,
|
|
})
|
|
self.partner_4 = self.env['res.partner'].create({'name': 'Another Customer'})
|
|
self.partner_address_13 = self.env['res.partner'].create({
|
|
'name': "Another Customer's Address",
|
|
'parent_id': self.partner_4.id,
|
|
})
|
|
self.product_uom_hour = self.env.ref('uom.product_uom_hour')
|
|
self.account_tag_operating = self.env.ref('account.account_tag_operating')
|
|
self.product_2 = self.env['product.product'].create({'name': 'Zizizaproduct'})
|
|
self.product_category = self.env.ref('product.product_category_all')
|
|
self.free_delivery = self.env.ref('delivery.free_delivery_carrier')
|
|
# as the tests hereunder assume all the prices in USD, we must ensure
|
|
# that the company actually uses USD
|
|
# We do an invalidation so the cache is aware of it too.
|
|
self.env.company.invalidate_recordset()
|
|
self.env.cr.execute(
|
|
"UPDATE res_company SET currency_id = %s WHERE id = %s",
|
|
[self.env.ref('base.USD').id, self.env.company.id])
|
|
self.pricelist.currency_id = self.env.ref('base.USD').id
|
|
self.env.user.groups_id |= self.env.ref('uom.group_uom')
|
|
|
|
def test_00_delivery_cost(self):
|
|
# In order to test Carrier Cost
|
|
# Create sales order with Normal Delivery Charges
|
|
|
|
self.sale_normal_delivery_charges = self.SaleOrder.create({
|
|
'partner_id': self.partner_18.id,
|
|
'partner_invoice_id': self.partner_18.id,
|
|
'partner_shipping_id': self.partner_18.id,
|
|
'pricelist_id': self.pricelist.id,
|
|
'order_line': [(0, 0, {
|
|
'name': 'PC Assamble + 2GB RAM',
|
|
'product_id': self.product_4.id,
|
|
'product_uom_qty': 1,
|
|
'product_uom': self.product_uom_unit.id,
|
|
'price_unit': 750.00,
|
|
})],
|
|
})
|
|
# I add delivery cost in Sales order
|
|
|
|
self.a_sale = self.AccountAccount.create({
|
|
'code': 'X2020',
|
|
'name': 'Product Sales - (test)',
|
|
'account_type': 'income',
|
|
'tag_ids': [(6, 0, {
|
|
self.account_tag_operating.id
|
|
})]
|
|
})
|
|
|
|
self.product_consultant = self.Product.create({
|
|
'sale_ok': True,
|
|
'list_price': 75.0,
|
|
'standard_price': 30.0,
|
|
'uom_id': self.product_uom_hour.id,
|
|
'uom_po_id': self.product_uom_hour.id,
|
|
'name': 'Service',
|
|
'categ_id': self.product_category.id,
|
|
'type': 'service'
|
|
})
|
|
|
|
# I add delivery cost in Sales order
|
|
delivery_wizard = Form(self.env['choose.delivery.carrier'].with_context({
|
|
'default_order_id': self.sale_normal_delivery_charges.id,
|
|
'default_carrier_id': self.normal_delivery.id
|
|
}))
|
|
choose_delivery_carrier = delivery_wizard.save()
|
|
choose_delivery_carrier.button_confirm()
|
|
|
|
# I check sales order after added delivery cost
|
|
|
|
line = self.SaleOrderLine.search([('order_id', '=', self.sale_normal_delivery_charges.id),
|
|
('product_id', '=', self.normal_delivery.product_id.id)])
|
|
self.assertEqual(len(line), 1, "Delivery cost is not Added")
|
|
|
|
zin = str(delivery_wizard.display_price) + " " + str(delivery_wizard.delivery_price) + ' ' + line.company_id.country_id.code + line.company_id.name
|
|
self.assertEqual(float_compare(line.price_subtotal, 10.0, precision_digits=2), 0,
|
|
"Delivery cost does not correspond to 10.0. %s %s" % (line.price_subtotal, zin))
|
|
|
|
# I confirm the sales order
|
|
|
|
self.sale_normal_delivery_charges.action_confirm()
|
|
|
|
# Create one more sales order with Free Delivery Charges
|
|
|
|
self.delivery_sale_order_cost = self.SaleOrder.create({
|
|
'partner_id': self.partner_4.id,
|
|
'partner_invoice_id': self.partner_address_13.id,
|
|
'partner_shipping_id': self.partner_address_13.id,
|
|
'pricelist_id': self.pricelist.id,
|
|
'order_line': [(0, 0, {
|
|
'name': 'Service on demand',
|
|
'product_id': self.product_consultant.id,
|
|
'product_uom_qty': 24,
|
|
'product_uom': self.product_uom_hour.id,
|
|
'price_unit': 75.00,
|
|
}), (0, 0, {
|
|
'name': 'On Site Assistance',
|
|
'product_id': self.product_2.id,
|
|
'product_uom_qty': 30,
|
|
'product_uom': self.product_uom_unit.id,
|
|
'price_unit': 38.25,
|
|
})],
|
|
})
|
|
|
|
# I add free delivery cost in Sales order
|
|
delivery_wizard = Form(self.env['choose.delivery.carrier'].with_context({
|
|
'default_order_id': self.delivery_sale_order_cost.id,
|
|
'default_carrier_id': self.free_delivery.id
|
|
}))
|
|
choose_delivery_carrier = delivery_wizard.save()
|
|
choose_delivery_carrier.button_confirm()
|
|
|
|
# I check sales order after adding delivery cost
|
|
line = self.SaleOrderLine.search([('order_id', '=', self.delivery_sale_order_cost.id),
|
|
('product_id', '=', self.free_delivery.product_id.id)])
|
|
|
|
self.assertEqual(len(line), 1, "Delivery cost is not Added")
|
|
self.assertEqual(float_compare(line.price_subtotal, 0, precision_digits=2), 0,
|
|
"Delivery cost is not correspond.")
|
|
|
|
# I set default delivery policy
|
|
|
|
self.default_delivery_policy = self.SaleConfigSetting.create({})
|
|
|
|
self.default_delivery_policy.execute()
|
|
|
|
def test_01_delivery_cost_from_pricelist(self):
|
|
""" This test aims to validate the use of a pricelist to compute the delivery cost in the case the associated
|
|
product of the shipping method is defined in the pricelist """
|
|
|
|
# Create pricelist with a custom price for the standard shipping method
|
|
my_pricelist = self.env['product.pricelist'].create({
|
|
'name': 'shipping_cost_change',
|
|
'item_ids': [(0, 0, {
|
|
'compute_price': 'fixed',
|
|
'fixed_price': 5,
|
|
'applied_on': '0_product_variant',
|
|
'product_id': self.normal_delivery.product_id.id,
|
|
})],
|
|
})
|
|
|
|
# Create sales order with Normal Delivery Charges
|
|
sale_pricelist_based_delivery_charges = self.SaleOrder.create({
|
|
'partner_id': self.partner_18.id,
|
|
'pricelist_id': my_pricelist.id,
|
|
'order_line': [(0, 0, {
|
|
'name': 'PC Assamble + 2GB RAM',
|
|
'product_id': self.product_4.id,
|
|
'product_uom_qty': 1,
|
|
'product_uom': self.product_uom_unit.id,
|
|
'price_unit': 750.00,
|
|
})],
|
|
})
|
|
|
|
# Add of delivery cost in Sales order
|
|
delivery_wizard = Form(self.env['choose.delivery.carrier'].with_context({
|
|
'default_order_id': sale_pricelist_based_delivery_charges.id,
|
|
'default_carrier_id': self.normal_delivery.id
|
|
}))
|
|
self.assertEqual(delivery_wizard.delivery_price, 5.0, "Delivery cost does not correspond to 5.0 in wizard")
|
|
delivery_wizard.save().button_confirm()
|
|
|
|
line = self.SaleOrderLine.search([('order_id', '=', sale_pricelist_based_delivery_charges.id),
|
|
('product_id', '=', self.normal_delivery.product_id.id)])
|
|
self.assertEqual(len(line), 1, "Delivery cost hasn't been added to SO")
|
|
self.assertEqual(line.price_subtotal, 5.0, "Delivery cost does not correspond to 5.0")
|
|
|
|
def test_02_delivery_cost_from_different_currency(self):
|
|
""" This test aims to validate the use of a pricelist using a different currency to compute the delivery cost in
|
|
the case the associated product of the shipping method is defined in the pricelist """
|
|
|
|
# Create pricelist with a custom price for the standard shipping method
|
|
my_pricelist = self.env['product.pricelist'].create({
|
|
'name': 'shipping_cost_change',
|
|
'item_ids': [(0, 0, {
|
|
'compute_price': 'fixed',
|
|
'fixed_price': 5,
|
|
'applied_on': '0_product_variant',
|
|
'product_id': self.normal_delivery.product_id.id,
|
|
})],
|
|
'currency_id': self.env.ref('base.EUR').id,
|
|
})
|
|
|
|
# Create sales order with Normal Delivery Charges
|
|
sale_pricelist_based_delivery_charges = self.SaleOrder.create({
|
|
'partner_id': self.partner_18.id,
|
|
'pricelist_id': my_pricelist.id,
|
|
'order_line': [(0, 0, {
|
|
'name': 'PC Assamble + 2GB RAM',
|
|
'product_id': self.product_4.id,
|
|
'product_uom_qty': 1,
|
|
'product_uom': self.product_uom_unit.id,
|
|
'price_unit': 750.00,
|
|
})],
|
|
})
|
|
|
|
# Add of delivery cost in Sales order
|
|
delivery_wizard = Form(self.env['choose.delivery.carrier'].with_context({
|
|
'default_order_id': sale_pricelist_based_delivery_charges.id,
|
|
'default_carrier_id': self.normal_delivery.id
|
|
}))
|
|
self.assertEqual(delivery_wizard.delivery_price, 5.0, "Delivery cost does not correspond to 5.0 in wizard")
|
|
delivery_wizard.save().button_confirm()
|
|
|
|
line = self.SaleOrderLine.search([('order_id', '=', sale_pricelist_based_delivery_charges.id),
|
|
('product_id', '=', self.normal_delivery.product_id.id)])
|
|
self.assertEqual(len(line), 1, "Delivery cost hasn't been added to SO")
|
|
self.assertEqual(line.price_subtotal, 5.0, "Delivery cost does not correspond to 5.0")
|
|
|
|
def test_01_taxes_on_delivery_cost(self):
|
|
|
|
# Creating taxes and fiscal position
|
|
|
|
tax_price_include = self.env['account.tax'].create({
|
|
'name': '10% inc',
|
|
'type_tax_use': 'sale',
|
|
'amount_type': 'percent',
|
|
'amount': 10,
|
|
'price_include': True,
|
|
'include_base_amount': True,
|
|
})
|
|
tax_price_exclude = self.env['account.tax'].create({
|
|
'name': '15% exc',
|
|
'type_tax_use': 'sale',
|
|
'amount_type': 'percent',
|
|
'amount': 15,
|
|
})
|
|
|
|
fiscal_position = self.env['account.fiscal.position'].create({
|
|
'name': 'fiscal_pos_a',
|
|
'tax_ids': [
|
|
(0, None, {
|
|
'tax_src_id': tax_price_include.id,
|
|
'tax_dest_id': tax_price_exclude.id,
|
|
}),
|
|
],
|
|
})
|
|
|
|
# Setting tax on delivery product
|
|
self.normal_delivery.product_id.taxes_id = tax_price_include
|
|
|
|
# Create sales order
|
|
# Required to see `pricelist_id` in the view
|
|
self.env.user.groups_id += self.env.ref('product.group_product_pricelist')
|
|
order_form = Form(self.env['sale.order'].with_context(tracking_disable=True))
|
|
order_form.partner_id = self.partner_18
|
|
order_form.pricelist_id = self.pricelist
|
|
order_form.fiscal_position_id = fiscal_position
|
|
|
|
# Try adding delivery product as a normal product
|
|
with order_form.order_line.new() as line:
|
|
line.product_id = self.normal_delivery.product_id
|
|
line.product_uom_qty = 1.0
|
|
line.product_uom = self.product_uom_unit
|
|
sale_order = order_form.save()
|
|
|
|
self.assertRecordValues(sale_order.order_line, [{'price_subtotal': 9.09, 'price_total': 10.45}])
|
|
|
|
# Now trying to add the delivery line using the delivery wizard, the results should be the same as before
|
|
delivery_wizard = Form(self.env['choose.delivery.carrier'].with_context(default_order_id=sale_order.id,
|
|
default_carrier_id=self.normal_delivery.id))
|
|
choose_delivery_carrier = delivery_wizard.save()
|
|
choose_delivery_carrier.button_confirm()
|
|
|
|
line = self.SaleOrderLine.search([
|
|
('order_id', '=', sale_order.id),
|
|
('product_id', '=', self.normal_delivery.product_id.id),
|
|
('is_delivery', '=', True)
|
|
])
|
|
|
|
self.assertRecordValues(line, [{'price_subtotal': 9.09, 'price_total': 10.45}])
|