Denis Ledoux
0501bbd62e
This revision is to make uniform the behavior of the `groups` attribute on the Python model fields and on the node in the view architecture. In both cases, remove the node from the view completely. Before this revision, in a back-end view: - In the Python model, if a field has the `groups` attribute set and the user is not part of the groups, the field is removed, completely, from the view. - In the view architecture, if a node has the `groups` attribute set and the user is not part of the groups, the node is made invisible (not completely removed, just made invisible). in a front-end view: - if a node has a "groups" or "t-groups" set and the user is not part of the groups, the node is removed from the view. So it's 2/3 cases removing nodes restricted to a group. and 1/3 case making invisible nodes restricted to a group. It's simpler to have a uniform behavior for the 3 cases, simpler to understandard for developers. In addition, this will help for the goal to cache back-end views. It makes possible to convert views using the `groups_id` field by moving the content of these views directly in the view to which they add content which is suppose to be completely removed when the user has not the according group. By getting rid of the `groups_id` many2many field on `ir.ui.view`, it makes possible to cache the view architecture without requiring to use the groups in the cache key. Currently, if we want to cache the view architecture, it would be required to use the intersection of the user groups with the `groups_id` groups of the view, making it costly to compute the cache key, therefore altering the performance point to cache the view architectures. closes odoo/odoo#95729 Related: odoo/enterprise#29592 Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>
72 lines
3.0 KiB
Python
72 lines
3.0 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo.addons.crm.tests.common import TestCrmCommon
|
|
from odoo.tests.common import Form
|
|
from odoo.tests import tagged, users
|
|
|
|
|
|
@tagged('res_partner')
|
|
class TestPartner(TestCrmCommon):
|
|
|
|
@users('user_sales_leads')
|
|
def test_parent_sync_sales_rep(self):
|
|
""" Test team_id / user_id sync from parent to children if the contact
|
|
is a person. Company children are not updated. """
|
|
contact_company = self.contact_company.with_env(self.env)
|
|
contact_company_1 = self.contact_company_1.with_env(self.env)
|
|
self.assertFalse(contact_company.team_id)
|
|
self.assertFalse(contact_company.user_id)
|
|
self.assertFalse(contact_company_1.team_id)
|
|
self.assertFalse(contact_company_1.user_id)
|
|
|
|
child = self.contact_1.with_env(self.env)
|
|
self.assertEqual(child.parent_id, self.contact_company_1)
|
|
self.assertFalse(child.team_id)
|
|
self.assertFalse(child.user_id)
|
|
|
|
# update comppany sales rep info
|
|
contact_company.user_id = self.env.uid
|
|
contact_company.team_id = self.sales_team_1.id
|
|
|
|
# change child parent: shold update sales rep info
|
|
child.parent_id = contact_company.id
|
|
self.assertEqual(child.user_id, self.env.user)
|
|
|
|
# test form tool
|
|
# <field name="team_id" groups="base.group_no_one"/>
|
|
with self.debug_mode():
|
|
partner_form = Form(self.env['res.partner'], 'base.view_partner_form')
|
|
partner_form.parent_id = contact_company
|
|
partner_form.company_type = 'person'
|
|
partner_form.name = 'Hermes Conrad'
|
|
self.assertEqual(partner_form.team_id, self.sales_team_1)
|
|
self.assertEqual(partner_form.user_id, self.env.user)
|
|
partner_form.parent_id = contact_company_1
|
|
self.assertEqual(partner_form.team_id, self.sales_team_1)
|
|
self.assertEqual(partner_form.user_id, self.env.user)
|
|
|
|
# test form tool
|
|
# <field name="team_id" groups="base.group_no_one"/>
|
|
with self.debug_mode():
|
|
partner_form = Form(self.env['res.partner'], 'base.view_partner_form')
|
|
# `parent_id` is invisible when `is_company` is True (`company_type == 'company'`)
|
|
# and parent_id is not set
|
|
# So, set a temporary `parent_id` before setting the contact as company
|
|
# to make `parent_id` visible in the interface while being a company
|
|
# <field name="parent_id"
|
|
# attrs="{
|
|
# 'invisible': [
|
|
# '|',
|
|
# '&', ('is_company','=', True),('parent_id', '=', False),
|
|
# ('company_name', '!=', False),('company_name', '!=', '')
|
|
# ]
|
|
# }"
|
|
# />
|
|
partner_form.parent_id = contact_company_1
|
|
partner_form.company_type = 'company'
|
|
partner_form.parent_id = contact_company
|
|
partner_form.name = 'Mom Corp'
|
|
self.assertFalse(partner_form.team_id)
|
|
self.assertFalse(partner_form.user_id)
|