Julien Castiaux
f003eaf884
Install mass_mailing with demo data, send a mailing using the "Thank you for joining us" template. Inside your mail client, click on the LOGIN button, this open your web browser on a link-tracker URL but the page fails to load because "The page isn't redirecting properly". Inside the template of that "Thank you for joining us" mail, the logging button is basically defined as follow: `<a href="#">LOGIN</a>`, a URL with a fragment that is empty, a redirection to the current page. Upon rendering that template and send it to the recipients, all links are wrapped inside a link-tracker for well tracking purpose, this created a link `/r/xyz` targeting `#`. Upon accessing that `/r/xyz` URL the client would be redirected to `#` which in that context is actually `/r/xyz#`: the link-tracker itself. The browser detects that there is a redirecting loop and show an error instead. The problem is solved by saving an absolute link with the link-tracker instead of a relative one. Task-3603607 closes odoo/odoo#150678 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com> Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
89 lines
3.9 KiB
Python
89 lines
3.9 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
import re
|
|
|
|
import markupsafe
|
|
from html import unescape
|
|
from werkzeug import urls
|
|
|
|
from odoo import api, models, tools
|
|
|
|
|
|
class MailRenderMixin(models.AbstractModel):
|
|
_inherit = "mail.render.mixin"
|
|
|
|
# ------------------------------------------------------------
|
|
# TOOLS
|
|
# ------------------------------------------------------------
|
|
|
|
@api.model
|
|
def _shorten_links(self, html, link_tracker_vals, blacklist=None, base_url=None):
|
|
""" Shorten links in an html content. It uses the '/r' short URL routing
|
|
introduced in this module. Using the standard Odoo regex local links are
|
|
found and replaced by global URLs (not including mailto, tel, sms).
|
|
|
|
TDE FIXME: could be great to have a record to enable website-based URLs
|
|
|
|
:param link_tracker_vals: values given to the created link.tracker, containing
|
|
for example: campaign_id, medium_id, source_id, and any other relevant fields
|
|
like mass_mailing_id in mass_mailing;
|
|
:param list blacklist: list of (local) URLs to not shorten (e.g.
|
|
'/unsubscribe_from_list')
|
|
:param str base_url: either given, either based on config parameter
|
|
|
|
:return: updated html
|
|
"""
|
|
base_url = base_url or self.env['ir.config_parameter'].sudo().get_param('web.base.url')
|
|
short_schema = base_url + '/r/'
|
|
for match in set(re.findall(tools.HTML_TAG_URL_REGEX, html)):
|
|
long_url = match[1]
|
|
# Make relative links absolute
|
|
if long_url.startswith(('/', '?', '#')):
|
|
long_url = base_url + long_url
|
|
# Don't shorten already-shortened links
|
|
if long_url.startswith(short_schema):
|
|
continue
|
|
# Don't shorten urls present in blacklist (aka to skip list)
|
|
if blacklist and any(s in long_url for s in blacklist):
|
|
continue
|
|
label = (match[3] or '').strip()
|
|
|
|
create_vals = dict(link_tracker_vals, url=unescape(long_url), label=unescape(label))
|
|
link = self.env['link.tracker'].search_or_create(create_vals)
|
|
if link.short_url:
|
|
# `str` manipulation required to support replacing "&" characters, common in urls
|
|
new_href = match[0].replace(match[1], link.short_url)
|
|
html = html.replace(markupsafe.Markup(match[0]), markupsafe.Markup(new_href))
|
|
|
|
return html
|
|
|
|
@api.model
|
|
def _shorten_links_text(self, content, link_tracker_vals, blacklist=None, base_url=None):
|
|
""" Shorten links in a string content. Works like ``_shorten_links`` but
|
|
targeting string content, not html.
|
|
|
|
:return: updated content
|
|
"""
|
|
if not content:
|
|
return content
|
|
base_url = base_url or self.env['ir.config_parameter'].sudo().get_param('web.base.url')
|
|
shortened_schema = base_url + '/r/'
|
|
unsubscribe_schema = base_url + '/sms/'
|
|
for original_url in set(re.findall(tools.TEXT_URL_REGEX, content)):
|
|
# don't shorten already-shortened links or links towards unsubscribe page
|
|
if original_url.startswith(shortened_schema) or original_url.startswith(unsubscribe_schema):
|
|
continue
|
|
# support blacklist items in path, like /u/
|
|
parsed = urls.url_parse(original_url, scheme='http')
|
|
if blacklist and any(item in parsed.path for item in blacklist):
|
|
continue
|
|
|
|
create_vals = dict(link_tracker_vals, url=unescape(original_url))
|
|
link = self.env['link.tracker'].search_or_create(create_vals)
|
|
if link.short_url:
|
|
# Ensures we only replace the same link and not a subpart of a longer one, multiple times if applicable
|
|
content = re.sub(re.escape(original_url) + r'(?![\w@:%.+&~#=/-])', link.short_url, content)
|
|
|
|
return content
|