Toufik Benjaa
6ed44181d0
This commit aims to improve the user experience when using payment acquirers. There currently are no error feedback with some acquirers, which leaves the user wondering what is going on and what is the real status of its payment. In some cases, the user is currently being redirected to the home page even though the payment has failed. We want to make it more obvious to the user that something unexpected has happened by redirecting to an intermediate page that will provide good feedback on payments status. Another goal of this commit is to order acquirers by sequence instead of by flow and to select the first acquirer by default. This feature was already implmented in commit fe294fd43e521bd2d339e962f43acf46c3d4cb97, some UI adaptations were needed though. Related to task #36680 Closes #26958
127 lines
5.1 KiB
Python
127 lines
5.1 KiB
Python
# -*- coding: utf-8 -*-
|
|
import logging
|
|
import pprint
|
|
import werkzeug
|
|
from werkzeug.urls import url_unquote_plus
|
|
|
|
from odoo import http
|
|
from odoo.http import request
|
|
from odoo.addons.payment.models.payment_acquirer import ValidationError
|
|
from odoo.addons.payment.controllers.portal import PaymentProcessing
|
|
|
|
_logger = logging.getLogger(__name__)
|
|
|
|
|
|
class OgoneController(http.Controller):
|
|
_accept_url = '/payment/ogone/test/accept'
|
|
_decline_url = '/payment/ogone/test/decline'
|
|
_exception_url = '/payment/ogone/test/exception'
|
|
_cancel_url = '/payment/ogone/test/cancel'
|
|
|
|
@http.route([
|
|
'/payment/ogone/accept', '/payment/ogone/test/accept',
|
|
'/payment/ogone/decline', '/payment/ogone/test/decline',
|
|
'/payment/ogone/exception', '/payment/ogone/test/exception',
|
|
'/payment/ogone/cancel', '/payment/ogone/test/cancel',
|
|
], type='http', auth='none')
|
|
def ogone_form_feedback(self, **post):
|
|
""" Ogone contacts using GET, at least for accept """
|
|
_logger.info('Ogone: entering form_feedback with post data %s', pprint.pformat(post)) # debug
|
|
request.env['payment.transaction'].sudo().form_feedback(post, 'ogone')
|
|
return werkzeug.utils.redirect("/payment/process")
|
|
|
|
@http.route(['/payment/ogone/s2s/create_json'], type='json', auth='public', csrf=False)
|
|
def ogone_s2s_create_json(self, **kwargs):
|
|
if not kwargs.get('partner_id'):
|
|
kwargs = dict(kwargs, partner_id=request.env.user.partner_id.id)
|
|
new_id = request.env['payment.acquirer'].browse(int(kwargs.get('acquirer_id'))).s2s_process(kwargs)
|
|
return new_id.id
|
|
|
|
@http.route(['/payment/ogone/s2s/create_json_3ds'], type='json', auth='public', csrf=False)
|
|
def ogone_s2s_create_json_3ds(self, verify_validity=False, **kwargs):
|
|
if not kwargs.get('partner_id'):
|
|
kwargs = dict(kwargs, partner_id=request.env.user.partner_id.id)
|
|
token = False
|
|
error = None
|
|
|
|
try:
|
|
token = request.env['payment.acquirer'].browse(int(kwargs.get('acquirer_id'))).s2s_process(kwargs)
|
|
except Exception as e:
|
|
error = str(e)
|
|
|
|
if not token:
|
|
res = {
|
|
'result': False,
|
|
'error': error,
|
|
}
|
|
return res
|
|
|
|
res = {
|
|
'result': True,
|
|
'id': token.id,
|
|
'short_name': token.short_name,
|
|
'3d_secure': False,
|
|
'verified': False,
|
|
}
|
|
|
|
if verify_validity != False:
|
|
baseurl = request.env['ir.config_parameter'].sudo().get_param('web.base.url')
|
|
params = {
|
|
'accept_url': baseurl + '/payment/ogone/validate/accept',
|
|
'decline_url': baseurl + '/payment/ogone/validate/decline',
|
|
'exception_url': baseurl + '/payment/ogone/validate/exception',
|
|
'return_url': kwargs.get('return_url', baseurl)
|
|
}
|
|
tx = token.validate(**params)
|
|
res['verified'] = token.verified
|
|
|
|
if tx and tx.html_3ds:
|
|
res['3d_secure'] = tx.html_3ds
|
|
|
|
return res
|
|
|
|
@http.route(['/payment/ogone/s2s/create'], type='http', auth='public', methods=["POST"], csrf=False)
|
|
def ogone_s2s_create(self, **post):
|
|
error = ''
|
|
acq = request.env['payment.acquirer'].browse(int(post.get('acquirer_id')))
|
|
try:
|
|
token = acq.s2s_process(post)
|
|
except Exception as e:
|
|
# synthax error: 'CHECK ERROR: |Not a valid date\n\n50001111: None'
|
|
token = False
|
|
error = str(e).splitlines()[0].split('|')[-1] or ''
|
|
|
|
if token and post.get('verify_validity'):
|
|
baseurl = request.env['ir.config_parameter'].sudo().get_param('web.base.url')
|
|
params = {
|
|
'accept_url': baseurl + '/payment/ogone/validate/accept',
|
|
'decline_url': baseurl + '/payment/ogone/validate/decline',
|
|
'exception_url': baseurl + '/payment/ogone/validate/exception',
|
|
'return_url': post.get('return_url', baseurl)
|
|
}
|
|
tx = token.validate(**params)
|
|
if tx and tx.html_3ds:
|
|
return tx.html_3ds
|
|
# add the payment transaction into the session to let the page /payment/process to handle it
|
|
PaymentProcessing.add_payment_transaction(tx)
|
|
return werkzeug.utils.redirect("/payment/process")
|
|
|
|
@http.route([
|
|
'/payment/ogone/validate/accept',
|
|
'/payment/ogone/validate/decline',
|
|
'/payment/ogone/validate/exception',
|
|
], type='http', auth='none')
|
|
def ogone_validation_form_feedback(self, **post):
|
|
""" Feedback from 3d secure for a bank card validation """
|
|
request.env['payment.transaction'].sudo().form_feedback(post, 'ogone')
|
|
return werkzeug.utils.redirect("/payment/process")
|
|
|
|
@http.route(['/payment/ogone/s2s/feedback'], auth='none', csrf=False)
|
|
def feedback(self, **kwargs):
|
|
try:
|
|
tx = request.env['payment.transaction'].sudo()._ogone_form_get_tx_from_data(kwargs)
|
|
tx._ogone_s2s_validate_tree(kwargs)
|
|
except ValidationError:
|
|
return 'ko'
|
|
return 'ok'
|