Thibault Delavallée
eb228ac373
Some tests are updated to lessen diff in future tests, especially about aliases. Some tests are fixed as they are somehow incorrect (notably in gateway testing) but currently passing as mail gateway is quite permissive. Add some tests preparing MC / alias domains configuration notably about company / alias synchronization, which is currently only based on config parameters. Also update some tests by using fstrings which are generally more readable. Finally move some tests to their right file / main testing class to keep them ordered by main topic. Prepares Task-36879 (Mail: Support MultiCompany Aliases) closes odoo/odoo#136318 X-original-commit: odoo/odoo@c18300e225 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
366 lines
15 KiB
Python
366 lines
15 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
import base64
|
|
import socket
|
|
|
|
from itertools import product
|
|
from unittest.mock import patch
|
|
from werkzeug.urls import url_parse, url_decode
|
|
|
|
from odoo.addons.mail.models.mail_message import Message
|
|
from odoo.addons.mail.tests.common import MailCommon
|
|
from odoo.addons.test_mail.tests.common import TestRecipients
|
|
from odoo.exceptions import AccessError
|
|
from odoo.tests import tagged, users, HttpCase
|
|
from odoo.tools import mute_logger
|
|
|
|
|
|
class TestMailMCCommon(MailCommon, TestRecipients):
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super().setUpClass()
|
|
|
|
cls.test_model = cls.env['ir.model']._get('mail.test.gateway')
|
|
cls.email_from = '"Sylvie Lelitre" <test.sylvie.lelitre@agrolait.com>'
|
|
|
|
cls.test_record = cls.env['mail.test.gateway'].with_context(cls._test_context).create({
|
|
'name': 'Test',
|
|
'email_from': 'ignasse@example.com',
|
|
}).with_context({})
|
|
cls.test_records_mc = cls.env['mail.test.multi.company'].create([
|
|
{'name': 'Test Company1',
|
|
'company_id': cls.user_employee.company_id.id},
|
|
{'name': 'Test Company2',
|
|
'company_id': cls.user_employee_c2.company_id.id},
|
|
])
|
|
|
|
cls.partner_1 = cls.env['res.partner'].with_context(cls._test_context).create({
|
|
'name': 'Valid Lelitre',
|
|
'email': 'valid.lelitre@agrolait.com',
|
|
})
|
|
# groups@.. will cause the creation of new mail.test.gateway
|
|
cls.mail_alias = cls.env['mail.alias'].create({
|
|
'alias_contact': 'everyone',
|
|
'alias_model_id': cls.test_model.id,
|
|
'alias_name': 'groups',
|
|
'alias_user_id': False,
|
|
})
|
|
|
|
# Set a first message on public group to test update and hierarchy
|
|
cls.fake_email = cls.env['mail.message'].create({
|
|
'model': 'mail.test.gateway',
|
|
'res_id': cls.test_record.id,
|
|
'subject': 'Public Discussion',
|
|
'message_type': 'email',
|
|
'subtype_id': cls.env.ref('mail.mt_comment').id,
|
|
'author_id': cls.partner_1.id,
|
|
'message_id': '<123456-openerp-%s-mail.test.gateway@%s>' % (cls.test_record.id, socket.gethostname()),
|
|
})
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
# patch registry to simulate a ready environment
|
|
self.patch(self.env.registry, 'ready', True)
|
|
self.flush_tracking()
|
|
|
|
|
|
@tagged('multi_company')
|
|
class TestMultiCompanySetup(TestMailMCCommon):
|
|
|
|
@users('employee_c2')
|
|
@mute_logger('odoo.addons.base.models.ir_rule')
|
|
def test_post_with_read_access(self):
|
|
""" Check that with readonly access, a message with attachment can be
|
|
posted on a model with the attribute _mail_post_access = 'read'. """
|
|
test_record_c1_su = self.env['mail.test.multi.company.read'].sudo().create([
|
|
{
|
|
'company_id': self.user_employee.company_id.id,
|
|
'name': 'MC Readonly',
|
|
}
|
|
])
|
|
test_record_c1 = test_record_c1_su.with_env(self.env)
|
|
self.assertFalse(test_record_c1.message_main_attachment_id)
|
|
|
|
self.assertEqual(test_record_c1.name, 'MC Readonly')
|
|
with self.assertRaises(AccessError):
|
|
test_record_c1.write({'name': 'Cannot Write'})
|
|
|
|
first_attachment = self.env['ir.attachment'].create({
|
|
'company_id': self.user_employee_c2.company_id.id,
|
|
'datas': base64.b64encode(b'First attachment'),
|
|
'mimetype': 'text/plain',
|
|
'name': 'TestAttachmentIDS.txt',
|
|
'res_model': 'mail.compose.message',
|
|
'res_id': 0,
|
|
})
|
|
|
|
message = test_record_c1.message_post(
|
|
attachments=[('testAttachment', b'First attachment')],
|
|
attachment_ids=first_attachment.ids,
|
|
body='My Body',
|
|
message_type='comment',
|
|
subtype_xmlid='mail.mt_comment',
|
|
)
|
|
self.assertTrue('testAttachment' in message.attachment_ids.mapped('name'))
|
|
self.assertEqual(test_record_c1.message_main_attachment_id, first_attachment)
|
|
|
|
new_attach = self.env['ir.attachment'].create({
|
|
'company_id': self.user_employee_c2.company_id.id,
|
|
'datas': base64.b64encode(b'Second attachment'),
|
|
'mimetype': 'text/plain',
|
|
'name': 'TestAttachmentIDS.txt',
|
|
'res_model': 'mail.compose.message',
|
|
'res_id': 0,
|
|
})
|
|
message = test_record_c1.message_post(
|
|
attachments=[('testAttachment', b'Second attachment')],
|
|
attachment_ids=new_attach.ids,
|
|
body='My Body',
|
|
message_type='comment',
|
|
subtype_xmlid='mail.mt_comment',
|
|
)
|
|
self.assertEqual(
|
|
sorted(message.attachment_ids.mapped('name')),
|
|
['TestAttachmentIDS.txt', 'testAttachment'],
|
|
)
|
|
self.assertEqual(test_record_c1.message_main_attachment_id, first_attachment)
|
|
|
|
@users('employee_c2')
|
|
@mute_logger('odoo.addons.base.models.ir_rule')
|
|
def test_post_wo_access(self):
|
|
test_records_mc_c1, test_records_mc_c2 = self.test_records_mc.with_env(self.env)
|
|
attachments_data = [
|
|
('ReportLike1', 'AttContent1'),
|
|
('ReportLike2', 'AttContent2'),
|
|
]
|
|
|
|
# ------------------------------------------------------------
|
|
# Other company (no access)
|
|
# ------------------------------------------------------------
|
|
|
|
_original_car = Message.check_access_rule
|
|
with patch.object(Message, 'check_access_rule',
|
|
autospec=True, side_effect=_original_car) as mock_msg_car:
|
|
with self.assertRaises(AccessError):
|
|
test_records_mc_c1.message_post(
|
|
body='<p>Hello</p>',
|
|
message_type='comment',
|
|
record_name='CustomName', # avoid ACL on display_name
|
|
reply_to='custom.reply.to@test.example.com', # avoid ACL in notify_get_reply_to
|
|
subtype_xmlid='mail.mt_comment',
|
|
)
|
|
self.assertEqual(mock_msg_car.call_count, 1,
|
|
'Purpose is to raise at msg check access level')
|
|
with self.assertRaises(AccessError):
|
|
_name = test_records_mc_c1.name
|
|
|
|
# no access to company1, access to post through being notified of parent
|
|
with self.assertRaises(AccessError):
|
|
_subject = test_records_mc_c1.message_ids.subject
|
|
self.assertEqual(len(self.test_records_mc[0].message_ids), 1)
|
|
initial_message = self.test_records_mc[0].message_ids
|
|
|
|
self.env['mail.notification'].sudo().create({
|
|
'mail_message_id': initial_message.id,
|
|
'notification_status': 'sent',
|
|
'res_partner_id': self.user_employee_c2.partner_id.id,
|
|
})
|
|
# additional: works only if in partner_ids, not notified via followers
|
|
initial_message.write({
|
|
'partner_ids': [(4, self.user_employee_c2.partner_id.id)],
|
|
})
|
|
# now able to post as was notified of parent message
|
|
test_records_mc_c1.message_post(
|
|
body='<p>Hello</p>',
|
|
message_type='comment',
|
|
parent_id=initial_message.id,
|
|
record_name='CustomName', # avoid ACL on display_name
|
|
reply_to='custom.reply.to@test.example.com', # avoid ACL in notify_get_reply_to
|
|
subtype_xmlid='mail.mt_comment',
|
|
)
|
|
|
|
# now able to post as was notified of parent message
|
|
attachments = self.env['ir.attachment'].create(
|
|
self._generate_attachments_data(
|
|
2, 'mail.compose.message', 0,
|
|
prefix='Other'
|
|
)
|
|
)
|
|
# record_name and reply_to may generate ACLs issues when computed by
|
|
# 'message_post' but should not, hence not specifying them to be sure
|
|
# testing the complete flow
|
|
test_records_mc_c1.message_post(
|
|
attachments=attachments_data,
|
|
attachment_ids=attachments.ids,
|
|
body='<p>Hello</p>',
|
|
message_type='comment',
|
|
parent_id=initial_message.id,
|
|
subtype_xmlid='mail.mt_comment',
|
|
)
|
|
|
|
# ------------------------------------------------------------
|
|
# User company (access granted)
|
|
# ------------------------------------------------------------
|
|
|
|
# can effectively link attachments with message to record of writable record
|
|
attachments = self.env['ir.attachment'].create(
|
|
self._generate_attachments_data(
|
|
2, 'mail.compose.message', 0,
|
|
prefix='Same'
|
|
)
|
|
)
|
|
message = test_records_mc_c2.message_post(
|
|
attachments=attachments_data,
|
|
attachment_ids=attachments.ids,
|
|
body='<p>Hello</p>',
|
|
message_type='comment',
|
|
record_name='CustomName', # avoid ACL on display_name
|
|
reply_to='custom.reply.to@test.example.com', # avoid ACL in notify_get_reply_to
|
|
subtype_xmlid='mail.mt_comment',
|
|
)
|
|
self.assertTrue(attachments < message.attachment_ids)
|
|
self.assertEqual(
|
|
sorted(message.attachment_ids.mapped('name')),
|
|
['ReportLike1', 'ReportLike2', 'SameAttFileName_00.txt', 'SameAttFileName_01.txt'],
|
|
)
|
|
self.assertEqual(
|
|
message.attachment_ids.mapped('res_id'),
|
|
[test_records_mc_c2.id] * 4,
|
|
)
|
|
self.assertEqual(
|
|
message.attachment_ids.mapped('res_model'),
|
|
[test_records_mc_c2._name] * 4,
|
|
)
|
|
|
|
# cannot link attachments of unreachable records when posting on a document
|
|
# they can access (aka no access delegation through posting message)
|
|
attachments = self.env['ir.attachment'].sudo().create(
|
|
self._generate_attachments_data(
|
|
1,
|
|
test_records_mc_c1._name,
|
|
test_records_mc_c1.id,
|
|
prefix='NoAccessMC'
|
|
)
|
|
)
|
|
with self.assertRaises(AccessError):
|
|
message = test_records_mc_c2.message_post(
|
|
attachments=attachments_data,
|
|
attachment_ids=attachments.ids,
|
|
body='<p>Hello</p>',
|
|
message_type='comment',
|
|
record_name='CustomName', # avoid ACL on display_name
|
|
reply_to='custom.reply.to@test.example.com', # avoid ACL in notify_get_reply_to
|
|
subtype_xmlid='mail.mt_comment',
|
|
)
|
|
|
|
def test_systray_get_activities(self):
|
|
self.env["mail.activity"].search([]).unlink()
|
|
user_admin = self.user_admin.with_user(self.user_admin)
|
|
test_records = self.env["mail.test.multi.company.with.activity"].create(
|
|
[
|
|
{"name": "Test1", "company_id": user_admin.company_id.id},
|
|
{"name": "Test2", "company_id": self.company_2.id},
|
|
]
|
|
)
|
|
test_records[0].activity_schedule("test_mail.mail_act_test_todo", user_id=user_admin.id)
|
|
test_records[1].activity_schedule("test_mail.mail_act_test_todo", user_id=user_admin.id)
|
|
test_activity = next(
|
|
a for a in user_admin.systray_get_activities()
|
|
if a['model'] == 'mail.test.multi.company.with.activity'
|
|
)
|
|
self.assertEqual(
|
|
test_activity,
|
|
{
|
|
"actions": [{"icon": "fa-clock-o", "name": "Summary"}],
|
|
"icon": "/base/static/description/icon.png",
|
|
"id": self.env["ir.model"]._get_id("mail.test.multi.company.with.activity"),
|
|
"model": "mail.test.multi.company.with.activity",
|
|
"name": "Test Multi Company Mail With Activity",
|
|
"overdue_count": 0,
|
|
"planned_count": 0,
|
|
"today_count": 2,
|
|
"total_count": 2,
|
|
"type": "activity",
|
|
}
|
|
)
|
|
|
|
test_activity = next(
|
|
a for a in user_admin.with_context(allowed_company_ids=[self.company_2.id]).systray_get_activities()
|
|
if a['model'] == 'mail.test.multi.company.with.activity'
|
|
)
|
|
self.assertEqual(
|
|
test_activity,
|
|
{
|
|
"actions": [{"icon": "fa-clock-o", "name": "Summary"}],
|
|
"icon": "/base/static/description/icon.png",
|
|
"id": self.env["ir.model"]._get_id("mail.test.multi.company.with.activity"),
|
|
"model": "mail.test.multi.company.with.activity",
|
|
"name": "Test Multi Company Mail With Activity",
|
|
"overdue_count": 0,
|
|
"planned_count": 0,
|
|
"today_count": 1,
|
|
"total_count": 1,
|
|
"type": "activity",
|
|
}
|
|
)
|
|
|
|
|
|
@tagged('-at_install', 'post_install', 'multi_company')
|
|
class TestMultiCompanyRedirect(MailCommon, HttpCase):
|
|
|
|
def test_redirect_to_records(self):
|
|
""" Test mail/view redirection in MC environment, notably cids being
|
|
added in redirect if user has access to the record. """
|
|
mc_record_c1, mc_record_c2 = self.env['mail.test.multi.company'].create([
|
|
{
|
|
'company_id': self.user_employee.company_id.id,
|
|
'name': 'Multi Company Record',
|
|
},
|
|
{
|
|
'company_id': self.user_employee_c2.company_id.id,
|
|
'name': 'Multi Company Record',
|
|
}
|
|
])
|
|
|
|
for (login, password), mc_record in product(
|
|
((None, None), # not logged: redirect to web/login
|
|
('employee', 'employee'), # access only main company
|
|
('admin', 'admin'), # access both companies
|
|
),
|
|
(mc_record_c1, mc_record_c2),
|
|
):
|
|
with self.subTest(login=login, mc_record=mc_record):
|
|
self.authenticate(login, password)
|
|
response = self.url_open(
|
|
f'/mail/view?model={mc_record._name}&res_id={mc_record.id}',
|
|
timeout=15
|
|
)
|
|
self.assertEqual(response.status_code, 200)
|
|
|
|
if not login:
|
|
path = url_parse(response.url).path
|
|
self.assertEqual(path, '/web/login')
|
|
else:
|
|
user = self.env['res.users'].browse(self.session.uid)
|
|
self.assertEqual(user.login, login)
|
|
mc_error = login == 'employee' and mc_record == mc_record_c2
|
|
if mc_error:
|
|
# Logged into company main, try accessing record in other
|
|
# company -> _redirect_to_record should redirect to
|
|
# messaging as the user doesn't have any access
|
|
fragment = url_parse(response.url).fragment
|
|
action = url_decode(fragment)['action']
|
|
self.assertEqual(action, 'mail.action_discuss')
|
|
else:
|
|
# Logged into company main, try accessing record in same
|
|
# company -> _redirect_to_record should add company in
|
|
# allowed_company_ids
|
|
fragment = url_parse(response.url).fragment
|
|
cids = url_decode(fragment)['cids']
|
|
if mc_record.company_id == user.company_id:
|
|
self.assertEqual(cids, f'{mc_record.company_id.id}')
|
|
else:
|
|
self.assertEqual(cids, f'{user.company_id.id},{mc_record.company_id.id}')
|