althaf shaik
2d66c22a60
Syntax Error generates when the user gives invalid python code in 'account_tax' module and uses that tax while creating invoice. Steps to produce: * Install 'account_tax_python' module * Go to configuration/taxes and create a new tax. * Select Tax Computation as 'python code' and give some special characters to python code field and save it. * Now create an invoice, add a product and add the above created tax in taxes. * At this moment traceback raises. By applying these changes will resolve this issue. closes odoo/odoo#127919 Sentry: 4060222060 X-original-commit: f42bd9c9fbd9a5e4c3eb127453a38d0c21a9d4fb Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
62 lines
3.5 KiB
Python
62 lines
3.5 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo import models, fields, _
|
|
from odoo.tools.safe_eval import safe_eval
|
|
from odoo.exceptions import UserError
|
|
|
|
|
|
class AccountTaxPython(models.Model):
|
|
_inherit = "account.tax"
|
|
|
|
amount_type = fields.Selection(selection_add=[
|
|
('code', 'Python Code')
|
|
], ondelete={'code': lambda recs: recs.write({'amount_type': 'percent', 'active': False})})
|
|
|
|
python_compute = fields.Text(string='Python Code', default="result = price_unit * 0.10",
|
|
help="Compute the amount of the tax by setting the variable 'result'.\n\n"
|
|
":param base_amount: float, actual amount on which the tax is applied\n"
|
|
":param price_unit: float\n"
|
|
":param quantity: float\n"
|
|
":param company: res.company recordset singleton\n"
|
|
":param product: product.product recordset singleton or None\n"
|
|
":param partner: res.partner recordset singleton or None")
|
|
python_applicable = fields.Text(string='Applicable Code', default="result = True",
|
|
help="Determine if the tax will be applied by setting the variable 'result' to True or False.\n\n"
|
|
":param price_unit: float\n"
|
|
":param quantity: float\n"
|
|
":param company: res.company recordset singleton\n"
|
|
":param product: product.product recordset singleton or None\n"
|
|
":param partner: res.partner recordset singleton or None")
|
|
|
|
def _compute_amount(self, base_amount, price_unit, quantity=1.0, product=None, partner=None, fixed_multiplicator=1):
|
|
self.ensure_one()
|
|
if product and product._name == 'product.template':
|
|
product = product.product_variant_id
|
|
if self.amount_type == 'code':
|
|
company = self.env.company
|
|
localdict = {'base_amount': base_amount, 'price_unit':price_unit, 'quantity': quantity, 'product':product, 'partner':partner, 'company': company}
|
|
try:
|
|
safe_eval(self.python_compute, localdict, mode="exec", nocopy=True)
|
|
except Exception as e:
|
|
raise UserError(_("You entered invalid code %r in %r taxes\n\nError : %s") % (self.python_compute, self.name, e)) from e
|
|
return localdict['result']
|
|
return super(AccountTaxPython, self)._compute_amount(base_amount, price_unit, quantity, product, partner, fixed_multiplicator)
|
|
|
|
def compute_all(self, price_unit, currency=None, quantity=1.0, product=None, partner=None, is_refund=False, handle_price_include=True, include_caba_tags=False, fixed_multiplicator=1):
|
|
if product and product._name == 'product.template':
|
|
product = product.product_variant_id
|
|
|
|
def is_applicable_tax(tax, company=self.env.company):
|
|
if tax.amount_type == 'code':
|
|
localdict = {'price_unit': price_unit, 'quantity': quantity, 'product': product, 'partner': partner, 'company': company}
|
|
try:
|
|
safe_eval(tax.python_applicable, localdict, mode="exec", nocopy=True)
|
|
except Exception as e:
|
|
raise UserError(_("You entered invalid code %r in %r taxes\n\nError : %s") % (tax.python_applicable, tax.name, e)) from e
|
|
return localdict.get('result', False)
|
|
|
|
return True
|
|
|
|
return super(AccountTaxPython, self.filtered(is_applicable_tax)).compute_all(price_unit, currency, quantity, product, partner, is_refund=is_refund, handle_price_include=handle_price_include, include_caba_tags=include_caba_tags, fixed_multiplicator=fixed_multiplicator)
|