Setting a controller URL to a menu which is linked to a page should unset the
m2o relationship to preserve the page URL.
Step to reproduce:
- Create a page (with a menu) and save, eg: "My Page" (url will be /my-page)
- Edit that new menu and change the URL to /shop (or any controller)
Issue:
- The page URL is now /shop, which doesn't have a lot sense if there is a
controller for that URL.
- Unpublishing the website.page will unpublish the menu, as a menu needs its
page to be published in order to be visible.
Note: The flow introduced here is the same as if you choose an URL of an
already existing page, the menu's page will be unlinked from the menu and
left with its original URL.
task-2575974
closes odoo/odoo#74163
X-original-commit: b52a01f76d89ebb7bdd75577e60a09f048c83000
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Signed-off-by: Romain Derie <rdeodoo@users.noreply.github.com>
172 lines
6.9 KiB
Python
172 lines
6.9 KiB
Python
# coding: utf-8
|
|
|
|
import json
|
|
|
|
from odoo.tests import common
|
|
|
|
|
|
class TestMenu(common.TransactionCase):
|
|
def setUp(self):
|
|
super(TestMenu, self).setUp()
|
|
self.nb_website = self.env['website'].search_count([])
|
|
|
|
def test_01_menu_got_duplicated(self):
|
|
Menu = self.env['website.menu']
|
|
total_menu_items = Menu.search_count([])
|
|
|
|
self.menu_root = Menu.create({
|
|
'name': 'Root',
|
|
})
|
|
|
|
self.menu_child = Menu.create({
|
|
'name': 'Child',
|
|
'parent_id': self.menu_root.id,
|
|
})
|
|
|
|
self.assertEqual(total_menu_items + self.nb_website * 2, Menu.search_count([]), "Creating a menu without a website_id should create this menu for every website_id")
|
|
|
|
def test_02_menu_count(self):
|
|
Menu = self.env['website.menu']
|
|
total_menu_items = Menu.search_count([])
|
|
|
|
top_menu = self.env['website'].get_current_website().menu_id
|
|
data = [
|
|
{
|
|
'id': 'new-1',
|
|
'parent_id': top_menu.id,
|
|
'name': 'New Menu Specific 1',
|
|
'url': '/new-specific-1',
|
|
'is_mega_menu': False,
|
|
},
|
|
{
|
|
'id': 'new-2',
|
|
'parent_id': top_menu.id,
|
|
'name': 'New Menu Specific 2',
|
|
'url': '/new-specific-2',
|
|
'is_mega_menu': False,
|
|
}
|
|
]
|
|
Menu.save(1, {'data': data, 'to_delete': []})
|
|
|
|
self.assertEqual(total_menu_items + 2, Menu.search_count([]), "Creating 2 new menus should create only 2 menus records")
|
|
|
|
def test_03_default_menu_for_new_website(self):
|
|
Website = self.env['website']
|
|
Menu = self.env['website.menu']
|
|
total_menu_items = Menu.search_count([])
|
|
|
|
# Simulating website.menu created on module install (blog, shop, forum..) that will be created on default menu tree
|
|
default_menu = self.env.ref('website.main_menu')
|
|
Menu.create({
|
|
'name': 'Sub Default Menu',
|
|
'parent_id': default_menu.id,
|
|
})
|
|
self.assertEqual(total_menu_items + 1 + self.nb_website, Menu.search_count([]), "Creating a default child menu should create it as such and copy it on every website")
|
|
|
|
# Ensure new website got a top menu
|
|
total_menus = Menu.search_count([])
|
|
Website.create({'name': 'new website'})
|
|
self.assertEqual(total_menus + 4, Menu.search_count([]), "New website's bootstraping should have duplicate default menu tree (Top/Home/Contactus/Sub Default Menu)")
|
|
|
|
def test_04_specific_menu_translation(self):
|
|
Translation = self.env['ir.translation']
|
|
Menu = self.env['website.menu']
|
|
existing_menus = Menu.search([])
|
|
|
|
default_menu = self.env.ref('website.main_menu')
|
|
template_menu = Menu.create({
|
|
'parent_id': default_menu.id,
|
|
'name': 'Menu in english',
|
|
'url': 'turlututu',
|
|
})
|
|
new_menus = Menu.search([]) - existing_menus
|
|
specific1, specific2 = new_menus.with_context(lang='fr_FR') - template_menu
|
|
|
|
# create fr_FR translation for template menu
|
|
self.env.ref('base.lang_fr').active = True
|
|
template_menu.with_context(lang='fr_FR').name = 'Menu en français'
|
|
Translation.search([
|
|
('name', '=', 'website.menu,name'), ('res_id', '=', template_menu.id),
|
|
]).module = 'website'
|
|
self.assertEqual(specific1.name, 'Menu in english',
|
|
'Translating template menu does not translate specific menu')
|
|
|
|
# have different translation for specific website
|
|
specific1.name = 'Menu in french'
|
|
|
|
# loading translation add missing specific translation
|
|
Translation._load_module_terms(['website'], ['fr_FR'])
|
|
Menu.invalidate_cache(['name'])
|
|
self.assertEqual(specific1.name, 'Menu in french',
|
|
'Load translation without overwriting keep existing translation')
|
|
self.assertEqual(specific2.name, 'Menu en français',
|
|
'Load translation add missing translation from template menu')
|
|
|
|
# loading translation with overwrite sync all translations from menu template
|
|
Translation._load_module_terms(['website'], ['fr_FR'], overwrite=True)
|
|
Menu.invalidate_cache(['name'])
|
|
self.assertEqual(specific1.name, 'Menu en français',
|
|
'Load translation with overwriting update existing menu from template')
|
|
|
|
def test_05_default_menu_unlink(self):
|
|
Menu = self.env['website.menu']
|
|
total_menu_items = Menu.search_count([])
|
|
|
|
default_menu = self.env.ref('website.main_menu')
|
|
default_menu.child_id[0].unlink()
|
|
self.assertEqual(total_menu_items - 1 - self.nb_website, Menu.search_count([]), "Deleting a default menu item should delete its 'copies' (same URL) from website's menu trees. In this case, the default child menu and its copies on website 1 and website 2")
|
|
|
|
|
|
class TestMenuHttp(common.HttpCase):
|
|
def test_01_menu_page_m2o(self):
|
|
# 1. Create a page with a menu
|
|
Menu = self.env['website.menu']
|
|
Page = self.env['website.page']
|
|
page_url = '/page_specific'
|
|
page = Page.create({
|
|
'url': page_url,
|
|
'website_id': 1,
|
|
# ir.ui.view properties
|
|
'name': 'Base',
|
|
'type': 'qweb',
|
|
'arch': '<div>Specific View</div>',
|
|
'key': 'test.specific_view',
|
|
})
|
|
menu = Menu.create({
|
|
'name': 'Page Specific menu',
|
|
'page_id': page.id,
|
|
'url': page_url,
|
|
'website_id': 1,
|
|
})
|
|
|
|
# 2. Edit the menu URL to a 'reserved' URL
|
|
data = {
|
|
'id': menu.id,
|
|
'parent_id': menu.parent_id.id,
|
|
'name': menu.name,
|
|
'url': '/website/info',
|
|
}
|
|
self.authenticate("admin", "admin")
|
|
# `Menu.save(1, {'data': [data], 'to_delete': []})` would have been
|
|
# ideal but need a full frontend context to generate routing maps,
|
|
# router and registry, even MockRequest is not enough
|
|
self.url_open('/web/dataset/call_kw', data=json.dumps({
|
|
"params": {
|
|
'model': 'website.menu',
|
|
'method': 'save',
|
|
'args': [1, {'data': [data], 'to_delete': []}],
|
|
'kwargs': {},
|
|
},
|
|
}), headers={"Content-Type": "application/json"})
|
|
|
|
self.assertFalse(menu.page_id, "M2o should have been unset as this is a reserved URL.")
|
|
self.assertEqual(menu.url, '/website/info', "Menu URL should have changed.")
|
|
self.assertEqual(page.url, page_url, "Page's URL shouldn't have changed.")
|
|
|
|
# 3. Edit the menu URL back to the page URL
|
|
data['url'] = page_url
|
|
Menu.save(1, {'data': [data], 'to_delete': []})
|
|
self.assertEqual(menu.page_id, page,
|
|
"M2o should have been set back, as there was a page found with the new URL set on the menu.")
|
|
self.assertTrue(page.url == menu.url == page_url)
|