Thibault Delavallée
bbf4783ac6
PURPOSE
Improve modeling and performances of mass mailing by manually updating trace
status instead of using complex computed fields and lessening fields usage.
Remove some fields and keep only relevant metrics to simplify and clean trace
model.
SPECIFICATIONS
In this commit we clean the way trace state is managed. Currently it is a
computed field based on several datetime fields. However this generates a
lot of noise in the table as well as unnecessary computation
* there are several columns (one for each state) storing datetime at
which status was reached. Generally only 2 or 3 contain relevant
information;
* state could be set in code directly to avoid a computed field based on
many triggers;
* recomputing it each time a date changes is not necessarily necessary;
* state value can always be updated manually as this is main done through
some automated server update (mailgateway, link clicks, ...);
As trace states and its triggers should not be updated manually it is better
to synchronize it in code flow. When there is an exception or update done
through sending or gateway status is updated as well accordingly. Various
datetime fields are also updated at the same time. In order to align with
notification model mail and sms trace status are updated to a classic field.
Only last status update is now kept as there is no need to store the entire
history of status change.
We keep only a datetime for relevant metrics: open, reply and click. Other
datetime bring no real value. Knowing when a trace was in error or bounced
is not necessary. Indeed exception generally indicates a server issue (at
sending), cancel indicates a data issue (at sending) and bounce depends on
customer email server.
Status update is removed as using write_date is sufficient. Once created
traces are updated only when an external event occurs (opened, replied, ...).
It allows to simplify trace model.
We also rename ignored field into canceled to match naming use through mail
and sms.
QUERY COUNTERS
This change has some positive update on query counters when sending mailings
as traces have less unnecessary status update compared to priori this change.
LINKS
Task ID-2377974
Community PR odoo/odoo#61467
Enterprise PR odoo/enterprise#14633
Upgrade PR odoo/upgrade#1907
71 lines
2.4 KiB
Python
71 lines
2.4 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo.tests.common import users
|
|
from odoo.addons.test_mass_mailing.tests import common
|
|
|
|
|
|
class TestLinkTracker(common.TestMassMailCommon):
|
|
|
|
def setUp(self):
|
|
super(TestLinkTracker, self).setUp()
|
|
|
|
self.link = self.env['link.tracker'].search_or_create({
|
|
'url': 'https://www.example.com'
|
|
})
|
|
|
|
self.click = self.env['link.tracker.click'].create({
|
|
'link_id': self.link.id,
|
|
'ip': '100.00.00.00',
|
|
'country_id': self.env.ref('base.fr').id,
|
|
})
|
|
|
|
def test_add_link(self):
|
|
code = self.link.code
|
|
self.assertEqual(self.link.count, 1)
|
|
|
|
# click from a new IP should create a new entry
|
|
click = self.env['link.tracker.click'].sudo().add_click(
|
|
code,
|
|
ip='100.00.00.01',
|
|
country_code='BEL'
|
|
)
|
|
self.assertEqual(click.ip, '100.00.00.01')
|
|
self.assertEqual(click.country_id, self.env.ref('base.be'))
|
|
self.assertEqual(self.link.count, 2)
|
|
|
|
# click from same IP (even another country) does not create a new entry
|
|
click = self.env['link.tracker.click'].sudo().add_click(
|
|
code,
|
|
ip='100.00.00.01',
|
|
country_code='FRA'
|
|
)
|
|
self.assertEqual(click, None)
|
|
self.assertEqual(self.link.count, 2)
|
|
|
|
@users('user_marketing')
|
|
def test_add_link_mail_stat(self):
|
|
record = self.env['mailing.test.blacklist'].create({})
|
|
code = self.link.code
|
|
self.assertEqual(self.link.count, 1)
|
|
trace = self.env['mailing.trace'].create({
|
|
'mass_mailing_id': self.mailing_bl.id,
|
|
'model': record._name,
|
|
'res_id': record.id,
|
|
})
|
|
self.assertEqual(trace.trace_status, 'outgoing')
|
|
self.assertFalse(trace.links_click_datetime)
|
|
|
|
# click from a new IP should create a new entry and update stat when provided
|
|
click = self.env['link.tracker.click'].sudo().add_click(
|
|
code,
|
|
ip='100.00.00.01',
|
|
country_code='BEL',
|
|
mailing_trace_id=trace.id
|
|
)
|
|
self.assertEqual(self.link.count, 2)
|
|
self.assertEqual(click.mass_mailing_id, self.mailing_bl)
|
|
self.assertTrue(trace.trace_status, 'open')
|
|
self.assertTrue(trace.links_click_datetime)
|
|
self.assertEqual(trace.links_click_ids, click)
|