William Braeckman
3d10c7c708
* = hr_timesheet, sale_project, test_main_flows Smaller changes: - Projects created on the fly (through `name_create`) will now come with a default `new` stage in order for them to not be empty. - Removed task auto assign upon creation besides in FSM's 'My tasks' menu. - Allow the reordering of projects without needing to group by anything. - Make `project.task`.`description` and `project.tags`.`name` translatable. - Disable the creation of records in the view when clicking on `Tasks in recurrence` stat button. - Track the planned date of the task in the chatter - Disable the creation of records in the view when clicking on 'invoices' stat button and add the kanban view to that action. - Make milestones completely available to regular project users. - Remove the 'Documents' button in the project's kanban settings menu. - Add kanban, pivot and graph views to the 'Hours Recorded' stat button on projects - Add the calendar view on the 'Hours Forecast' stat button on projects - The 'Sales Orders' stat button on the `project.project`'s form view will now display the amount of sales order linked to the whole project. So the one linked to the project itself if it exists + all the tasks. It will also open them, form view if 1 else list view. - Fix a typo in the settings 'projets' => 'projects' - The analytic account of the project will now be assigned to the sales order when a task is created through the 'Create a task in an existing project' option. Changed the portal task view to include a sidebar similar to sales orders, with a simple menu leading to different parts of the screen. Changed the `project.task` 'rating' stat button: - The icon will now represent the latest review. - The action will directly lead to the record's form view if there is only 1 rating. - Make some fields readonly in the form view. - Display the % of satisfaction instead of the number of ratings. Reorder all stat buttons on the `project.task` form view in this order: - Products, Worksheet, Sales Order(s), Invoices, Ratings, Hours Forecast, Parent Task, Tasks in recurrence, Tickets, Quotations and lastly Customer Preview Make the status of the project editable directly through the kanban view. A new widget has been added to handle that properly. When editing the status through that means, a `project.update` will be created with the current date and the appropriate status. In addition to that a new status has been added (only on `project.task`, not `project.status`) namely `to_define` in order to differentiate new and running projects. Projects now start with the `to_define` status. The `project.project`'s rating stat button has been changed in the following ways: - The icon will now change in function of the satisfaction percentage, smile above 66%, meh between 33% and 66% and frown below 33%. - The color will also change depending on the rate, smile is green, meh is orange and frown is red. - The ratings will now be in function of the last 30 days instead of all time and the action will also filter on those 30 days. - Change the action name from 'Rating' to 'Ratings'. `project.project` ticket stat button: - Will now open the form view when there is only one record. - Added the activity view. - Disable the creation of new records. - Rename the action to 'Tickets'. Closes: odoo/odoo#75269 See: odoo/enterprise#20334 Task ID: 2611006 Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
209 lines
12 KiB
Python
209 lines
12 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo import Command
|
|
from odoo.exceptions import AccessError
|
|
from odoo.tests import tagged
|
|
from odoo.tests.common import Form
|
|
|
|
from .test_project_base import TestProjectCommon
|
|
|
|
|
|
class TestProjectSharingCommon(TestProjectCommon):
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super().setUpClass()
|
|
|
|
project_sharing_stages_vals_list = [
|
|
(0, 0, {'name': 'To Do', 'sequence': 1}),
|
|
(0, 0, {'name': 'Done', 'sequence': 10}),
|
|
]
|
|
|
|
cls.partner_portal = cls.env['res.partner'].create({
|
|
'name': 'Chell Gladys',
|
|
'email': 'chell@gladys.portal',
|
|
'company_id': False,
|
|
'user_ids': [Command.link(cls.user_portal.id)]})
|
|
|
|
cls.project_cows = cls.env['project.project'].with_context({'mail_create_nolog': True}).create({
|
|
'name': 'Cows',
|
|
'privacy_visibility': 'portal',
|
|
'alias_name': 'project+cows',
|
|
'type_ids': project_sharing_stages_vals_list,
|
|
})
|
|
cls.project_portal = cls.env['project.project'].with_context({'mail_create_nolog': True}).create({
|
|
'name': 'Portal',
|
|
'privacy_visibility': 'portal',
|
|
'alias_name': 'project+portal',
|
|
'partner_id': cls.user_portal.partner_id.id,
|
|
'type_ids': project_sharing_stages_vals_list,
|
|
})
|
|
|
|
cls.task_cow = cls.env['project.task'].with_context({'mail_create_nolog': True}).create({
|
|
'name': 'Cow UserTask',
|
|
'user_ids': cls.user_projectuser,
|
|
'project_id': cls.project_cows.id,
|
|
})
|
|
cls.task_portal = cls.env['project.task'].with_context({'mail_create_nolog': True}).create({
|
|
'name': 'Portal UserTask',
|
|
'user_ids': cls.user_projectuser,
|
|
'project_id': cls.project_portal.id,
|
|
})
|
|
|
|
def get_project_sharing_form_view(self, record, with_user=None):
|
|
return Form(
|
|
record.with_user(with_user or self.env.user),
|
|
view="project.project_sharing_project_task_view_form"
|
|
)
|
|
|
|
@tagged('project_sharing')
|
|
class TestProjectSharing(TestProjectSharingCommon):
|
|
|
|
def test_project_share_wizard(self):
|
|
""" Test Project Share Wizard
|
|
|
|
Test Cases:
|
|
==========
|
|
1) Create the wizard record
|
|
2) Check if no access rights are given to a portal user
|
|
3) Add access rights to a portal user
|
|
"""
|
|
project_share_wizard = self.env['project.share.wizard'].create({
|
|
'res_model': 'project.project',
|
|
'res_id': self.project_portal.id,
|
|
'access_mode': 'edit',
|
|
})
|
|
self.assertFalse(project_share_wizard.partner_ids, 'No collaborator should be in the wizard.')
|
|
self.assertFalse(self.project_portal.with_user(self.user_portal)._check_project_sharing_access(), 'The portal user should not have accessed in project sharing views.')
|
|
project_share_wizard.write({'partner_ids': [Command.link(self.user_portal.partner_id.id)]})
|
|
project_share_wizard.action_send_mail()
|
|
self.assertEqual(len(self.project_portal.collaborator_ids), 1, 'The access right added in project share wizard should be added in the project when the user confirm the access in the wizard.')
|
|
self.assertDictEqual({
|
|
'partner_id': self.project_portal.collaborator_ids.partner_id,
|
|
'project_id': self.project_portal.collaborator_ids.project_id,
|
|
}, {
|
|
'partner_id': self.user_portal.partner_id,
|
|
'project_id': self.project_portal,
|
|
}, 'The access rights added should be the read access for the portal project for Chell Gladys.')
|
|
self.assertTrue(self.project_portal.with_user(self.user_portal)._check_project_sharing_access(), 'The portal user should have read access to the portal project with project sharing feature.')
|
|
|
|
def test_project_sharing_access(self):
|
|
""" Check if the different user types can access to project sharing feature as expected. """
|
|
with self.assertRaises(AccessError, msg='The public user should not have any access to project sharing feature of the portal project.'):
|
|
self.project_portal.with_user(self.user_public)._check_project_sharing_access()
|
|
self.assertTrue(self.project_portal.with_user(self.user_projectuser)._check_project_sharing_access(), 'The internal user should have all accesses to project sharing feature of the portal project.')
|
|
self.assertFalse(self.project_portal.with_user(self.user_portal)._check_project_sharing_access(), 'The portal user should not have any access to project sharing feature of the portal project.')
|
|
self.project_portal.write({'collaborator_ids': [Command.create({'partner_id': self.user_portal.partner_id.id})]})
|
|
self.assertTrue(self.project_portal.with_user(self.user_portal)._check_project_sharing_access(), 'The portal user can access to project sharing feature of the portal project.')
|
|
|
|
def test_create_task_in_project_sharing(self):
|
|
""" Test when portal user creates a task in project sharing views.
|
|
|
|
Test Cases:
|
|
==========
|
|
1) Give the 'read' access mode to a portal user in a project and try to create task with this user.
|
|
2) Give the 'comment' access mode to a portal user in a project and try to create task with this user.
|
|
3) Give the 'edit' access mode to a portal user in a project and try to create task with this user.
|
|
3.1) Try to change the project of the new task with this user.
|
|
"""
|
|
# 1) Give the 'read' access mode to a portal user in a project and try to create task with this user.
|
|
with self.assertRaises(AccessError, msg="Should not accept the portal user create a task in the project when he has not the edit access right."):
|
|
with self.get_project_sharing_form_view(self.env['project.task'].with_context({'tracking_disable': True, 'default_project_id': self.project_portal.id}), self.user_portal) as form:
|
|
form.name = 'Test'
|
|
task = form.save()
|
|
|
|
self.project_portal.write({
|
|
'collaborator_ids': [
|
|
Command.create({'partner_id': self.user_portal.partner_id.id}),
|
|
],
|
|
})
|
|
with self.get_project_sharing_form_view(self.env['project.task'].with_context({'tracking_disable': True, 'default_project_id': self.project_portal.id, 'default_user_ids': [(4, self.user_portal.id)]}), self.user_portal) as form:
|
|
form.name = 'Test'
|
|
task = form.save()
|
|
self.assertEqual(task.name, 'Test')
|
|
self.assertEqual(task.project_id, self.project_portal)
|
|
self.assertEqual(task.portal_user_names, self.user_portal.name)
|
|
# 3.1) Try to change the project of the new task with this user.
|
|
with self.assertRaises(AssertionError, msg="Should not accept the portal user changes the project of the task."):
|
|
form.project_id = self.project_cows
|
|
task = form.save()
|
|
|
|
def test_edit_task_in_project_sharing(self):
|
|
""" Test when portal user creates a task in project sharing views.
|
|
|
|
Test Cases:
|
|
==========
|
|
1) Give the 'read' access mode to a portal user in a project and try to edit task with this user.
|
|
2) Give the 'comment' access mode to a portal user in a project and try to edit task with this user.
|
|
3) Give the 'edit' access mode to a portal user in a project and try to create task with this user.
|
|
3.1) Try to change the project of the new task with this user.
|
|
"""
|
|
# 1) Give the 'read' access mode to a portal user in a project and try to create task with this user.
|
|
with self.assertRaises(AccessError, msg="Should not accept the portal user create a task in the project when he has not the edit access right."):
|
|
with self.get_project_sharing_form_view(self.task_cow.with_context({'tracking_disable': True, 'default_project_id': self.project_cows.id}), self.user_portal) as form:
|
|
form.name = 'Test'
|
|
task = form.save()
|
|
|
|
project_share_wizard = self.env['project.share.wizard'].create({
|
|
'access_mode': 'edit',
|
|
'res_model': 'project.project',
|
|
'res_id': self.project_cows.id,
|
|
'partner_ids': [
|
|
Command.link(self.user_portal.partner_id.id),
|
|
],
|
|
})
|
|
project_share_wizard.action_send_mail()
|
|
|
|
with self.get_project_sharing_form_view(self.task_cow.with_context({'tracking_disable': True, 'default_project_id': self.project_cows.id, 'uid': self.user_portal.id}), self.user_portal) as form:
|
|
form.name = 'Test'
|
|
task = form.save()
|
|
self.assertEqual(task.name, 'Test')
|
|
self.assertEqual(task.project_id, self.project_cows)
|
|
|
|
# 3.1) Try to change the project of the new task with this user.
|
|
with self.assertRaises(AssertionError, msg="Should not accept the portal user changes the project of the task."):
|
|
with self.get_project_sharing_form_view(task, self.user_portal) as form:
|
|
form.project_id = self.project_portal
|
|
|
|
# 3.2) Create a sub-task
|
|
with self.get_project_sharing_form_view(task, self.user_portal) as form:
|
|
with form.child_ids.new() as subtask_form:
|
|
subtask_form.name = 'Test Subtask'
|
|
with self.assertRaises(AssertionError, msg="Should not accept the portal user changes the project of the task."):
|
|
subtask_form.display_project_id = self.project_portal
|
|
self.assertEqual(task.child_ids.name, 'Test Subtask')
|
|
self.assertEqual(task.child_ids.project_id, self.project_cows)
|
|
self.assertEqual(task.child_ids.portal_user_names, self.user_portal.name)
|
|
self.assertEqual(task.child_ids.user_ids, self.user_portal)
|
|
|
|
def test_portal_user_cannot_see_all_assignees(self):
|
|
""" Test when the portal sees a task he cannot see all the assignees.
|
|
|
|
Because of a ir.rule in res.partner filters the assignees, the portal
|
|
can only see the assignees in the same company than him.
|
|
|
|
Test Cases:
|
|
==========
|
|
1) add many assignees in a task
|
|
2) check the portal user can read no assignee in this task. Should have an AccessError exception
|
|
"""
|
|
self.task_cow.write({'user_ids': [Command.link(self.user_projectmanager.id)]})
|
|
with self.assertRaises(AccessError, msg="Should not accept the portal user to access to a task he does not follow it and its project."):
|
|
self.task_cow.with_user(self.user_portal).read(['portal_user_names'])
|
|
self.assertEqual(len(self.task_cow.user_ids), 2, '2 users should be assigned in this task.')
|
|
|
|
project_share_wizard = self.env['project.share.wizard'].create({
|
|
'access_mode': 'edit',
|
|
'res_model': 'project.project',
|
|
'res_id': self.project_cows.id,
|
|
'partner_ids': [
|
|
Command.link(self.user_portal.partner_id.id),
|
|
],
|
|
})
|
|
project_share_wizard.action_send_mail()
|
|
|
|
self.assertFalse(self.task_cow.with_user(self.user_portal).user_ids, 'the portal user should see no assigness in the task.')
|
|
task_portal_read = self.task_cow.with_user(self.user_portal).read(['portal_user_names'])
|
|
self.assertEqual(self.task_cow.portal_user_names, task_portal_read[0]['portal_user_names'], 'the portal user should see assignees name in the task via the `portal_user_names` field.')
|