Raphael ColletandXavier-Do
6d5da2d2d3
Consider a context-dependent field, and successively access it on a recordset with different contexts. On the first context, the field is correctly computed in batch. After that, the field is always computed one by one. The bug is in the method that determines which records in a given set have no value in cache. On the first context, the cache is empty for the field, so all records are returned. After that, the method considers that all records have a value in cache: they do, but for another context key! Simply using the context key when looking up the cache fixes the issue. closes odoo/odoo#52360 X-original-commit: 35d69589d9b43afe6c6fc9779458323f7180153e Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com> Co-authored-by: Xavier-Do <xdo@odoo.com>
70 lines
2.1 KiB
Python
70 lines
2.1 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo import models, fields, api, tools
|
|
|
|
|
|
class BaseModel(models.Model):
|
|
_name = 'test_performance.base'
|
|
_description = 'Test Performance Base'
|
|
|
|
name = fields.Char()
|
|
value = fields.Integer(default=0)
|
|
value_pc = fields.Float(compute="_value_pc", store=True)
|
|
value_ctx = fields.Float(compute="_value_ctx")
|
|
partner_id = fields.Many2one('res.partner', string='Customer')
|
|
|
|
line_ids = fields.One2many('test_performance.line', 'base_id')
|
|
total = fields.Integer(compute="_total", store=True)
|
|
tag_ids = fields.Many2many('test_performance.tag')
|
|
|
|
@api.depends('value')
|
|
def _value_pc(self):
|
|
for record in self:
|
|
record.value_pc = float(record.value) / 100
|
|
|
|
@api.depends_context('key')
|
|
def _value_ctx(self):
|
|
self.env.cr.execute('SELECT 42') # one dummy query per batch
|
|
for record in self:
|
|
record.value_ctx = self.env.context.get('key')
|
|
|
|
@api.depends('line_ids.value')
|
|
def _total(self):
|
|
for record in self:
|
|
record.total = sum(line.value for line in record.line_ids)
|
|
|
|
|
|
class LineModel(models.Model):
|
|
_name = 'test_performance.line'
|
|
_description = 'Test Performance Line'
|
|
|
|
base_id = fields.Many2one('test_performance.base', required=True, ondelete='cascade')
|
|
value = fields.Integer()
|
|
|
|
def init(self):
|
|
# line values should be unique per "base" - useful for testing corner cases with unique lines
|
|
tools.create_unique_index(self._cr, 'test_performance_line_uniq', self._table, ['base_id', 'value'])
|
|
|
|
|
|
class TagModel(models.Model):
|
|
_name = 'test_performance.tag'
|
|
_description = 'Test Performance Tag'
|
|
|
|
name = fields.Char()
|
|
|
|
|
|
class Bacon(models.Model):
|
|
_name = 'test_performance.bacon'
|
|
_description = 'Test Performance Bacon'
|
|
|
|
property_eggs = fields.Many2one(
|
|
'test_performance.eggs', company_dependent=True, string='Eggs')
|
|
|
|
|
|
class Eggs(models.Model):
|
|
_name = 'test_performance.eggs'
|
|
_description = 'Test Performance Eggs'
|
|
|
|
name = fields.Char()
|