Fanny He
ccb6b26336
One can set a Unit of Measure precision rounding more precise than the overall Decimal Accuracy. This can trigger the error 'It is not possible to unreserve more products', as there will be inconsistencies on reserved quantities due to decimal roundings. We add 2 warnings on Units of Measure and Decimal Accuracy. Therefore, users are warned when their UOM/decimal changes can cause inconsistencies in quants reservation. Also, we want to prevent the issue at the root by ensuring that both the move and the quant have the same reserved quantity. The contrary can happen e.g. when a product is defined in Liters (rounding .001) but used in an operation in ml (rounding .01, so e.g. 187.5ml). The conversions between the 2 UOM can cause the differences of reservations. In _prepare_move_line_vals we make sure uom_quantity_back_to_product_uom is not more precise than the overall Decimal Accuracy. That way, if the reserved quantity changes between UOM conversions, the move line created is in the quant/product UOM, and we do not have move line's reserved quantity > quantity in stock. We do the same for _update_reserved_quantity (stock.move), when updating a move line. In _update_move_lines, because of UOM conversions, new_quantity_done can differ from ml.product_uom_qty, which triggers the creation of an extra move line, leading to reserved quantity > quantity in stock. To prevent that, we compare the reserved quantities in the product UOM. opw 2206902 (Example 1) opw 2171541 opw 2221227 opw 2233937 opw 2198775 and many more closes odoo/odoo#62279 X-original-commit: 478a42beb5876171afeab7df27fa69548edbf849 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
41 lines
1.8 KiB
Python
41 lines
1.8 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo import api, models, tools, _
|
|
from odoo.exceptions import ValidationError
|
|
|
|
|
|
class DecimalPrecision(models.Model):
|
|
_inherit = 'decimal.precision'
|
|
|
|
@api.constrains('digits')
|
|
def _check_main_currency_rounding(self):
|
|
if any(precision.name == 'Account' and
|
|
tools.float_compare(self.env.company.currency_id.rounding, 10 ** - precision.digits, precision_digits=6) == -1
|
|
for precision in self):
|
|
raise ValidationError(_("You cannot define the decimal precision of 'Account' as greater than the rounding factor of the company's main currency"))
|
|
return True
|
|
|
|
@api.onchange('digits')
|
|
def _onchange_digits(self):
|
|
if self.name != "Product Unit of Measure": # precision_get() relies on this name
|
|
return
|
|
# We are changing the precision of UOM fields; check whether the
|
|
# precision is equal or higher than existing units of measure.
|
|
rounding = 1.0 / 10.0**self.digits
|
|
dangerous_uom = self.env['uom.uom'].search([('rounding', '<', rounding)])
|
|
if dangerous_uom:
|
|
uom_descriptions = [
|
|
" - %s (id=%s, precision=%s)" % (uom.name, uom.id, uom.rounding)
|
|
for uom in dangerous_uom
|
|
]
|
|
return {'warning': {
|
|
'title': _('Warning!'),
|
|
'message': _(
|
|
"You are setting a Decimal Accuracy less precise than the UOMs:\n"
|
|
"%s\n"
|
|
"This may cause inconsistencies in computations.\n"
|
|
"Please increase the rounding of those units of measure, or the digits of this Decimal Accuracy."
|
|
) % ('\n'.join(uom_descriptions)),
|
|
}}
|