Aurélien Warnon
1e25946a76
PURPOSE This commit consolidates UTM usage across all applications. Global purpose is to avoid having undesired side-effects, such as unlinking an utm.source/utm.medium/utm.campaign and at the same time cascading the deletion to various records without noticing. SPECS ALLOW MORE PEOPLE TO CLEAN UTM RECORDS Currently, not even the system administrator can delete utm.mediums and utm.sources (he can only delete campaigns). These were considered as "technical records", but allowing some cleanup is a good idea since these records are often automatically generated and can create a lot of unnecessary noise in the database. That's why we now allow the following groups to delete all UTM records (sources, mediums and campaigns): - group_system - group_mass_mailing_user - group_social_manager (enterprise) PREVENT DELETION For some use cases, removing an utm.source/utm.medium/utm.campaign would cascade delete the related record, which was unintended / hidden side effect. These combinations were secured by preventing to unlink: - mailing.mailing source_id field Trying to delete the utm.source will throw an error message - mailing.mailing medium_id field Trying to delete the utm.medium will throw an error message - hr.recruitment.source source_id field Trying to delete the utm.source will throw an error message ADDING CLEAN ERROR MESSAGES When trying to delete an UTM record that is linked with ondelete="restrict", we improved the error message to give a clear explication to the user, e.g: "You can't delete these UTM sources as they are linked to the following mailings in the Mass Mailing APP, and deleting the source would break the statistics: Newsletter" SPECIFY 'ondelete' strategy For a lot of uses of sources/mediums/campaigns, the 'ondelete' strategy was not specified, leading to the confusion of "is this really how we want to handle this?". A lot of ondelete="set null" have been added in various field definitions to ensure that this is the desired and logical strategy we want for that specific model. PREVENT REMOVING HARDCODED UTM RECORDS In some functional flows, UTM records are hardcoded using their direct record reference. This is notably the case for the recruitment process and its creation of aliases, and for the Email / SMS Marketing flows. As deleting them would break these flows, we prevent their deletion in a "api.ondelete" method. ENFORCE NEW RULES WITH TESTS A lot of python tests have been added to make sure we enforce the decisions taken here above. LINKS ENT PR odoo/enterprise#19048 Task-2459480 closes odoo/odoo#72239 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
84 lines
3.3 KiB
Python
84 lines
3.3 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo import _, api, fields, models
|
|
from odoo.exceptions import UserError
|
|
|
|
|
|
class UtmCampaign(models.Model):
|
|
_inherit = 'utm.campaign'
|
|
|
|
mailing_sms_ids = fields.One2many(
|
|
'mailing.mailing', 'campaign_id',
|
|
domain=[('mailing_type', '=', 'sms')],
|
|
string='Mass SMS',
|
|
groups="mass_mailing.group_mass_mailing_user")
|
|
mailing_sms_count = fields.Integer('Number of Mass SMS',
|
|
compute="_compute_mailing_sms_count",
|
|
groups="mass_mailing.group_mass_mailing_user")
|
|
|
|
# A/B Testing
|
|
ab_testing_sms_winner_selection = fields.Selection([
|
|
('manual', 'Manual'),
|
|
('clicks_ratio', 'Highest Click Rate')], string="SMS Winner Selection", default="clicks_ratio")
|
|
|
|
@api.depends('mailing_mail_ids', 'mailing_sms_ids')
|
|
def _compute_ab_testing_total_pc(self):
|
|
super()._compute_ab_testing_total_pc()
|
|
for campaign in self:
|
|
campaign.ab_testing_total_pc += sum([
|
|
mailing.ab_testing_pc for mailing in campaign.mailing_sms_ids.filtered('ab_testing_enabled')
|
|
])
|
|
|
|
@api.depends('mailing_sms_ids')
|
|
def _compute_mailing_sms_count(self):
|
|
for campaign in self:
|
|
campaign.mailing_sms_count = len(campaign.mailing_sms_ids)
|
|
|
|
def action_create_mass_sms(self):
|
|
action = self.env["ir.actions.actions"]._for_xml_id("mass_mailing.action_create_mass_mailings_from_campaign")
|
|
action['context'] = {
|
|
'default_campaign_id': self.id,
|
|
'default_mailing_type': 'sms',
|
|
'search_default_assigned_to_me': 1,
|
|
'search_default_campaign_id': self.id,
|
|
'default_user_id': self.env.user.id,
|
|
}
|
|
return action
|
|
|
|
def action_redirect_to_mailing_sms(self):
|
|
action = self.env["ir.actions.actions"]._for_xml_id("mass_mailing_sms.mailing_mailing_action_sms")
|
|
action['context'] = {
|
|
'default_campaign_id': self.id,
|
|
'default_mailing_type': 'sms',
|
|
'search_default_assigned_to_me': 1,
|
|
'search_default_campaign_id': self.id,
|
|
'default_user_id': self.env.user.id,
|
|
}
|
|
action['domain'] = [('mailing_type', '=', 'sms')]
|
|
return action
|
|
|
|
@api.model
|
|
def _cron_process_mass_mailing_ab_testing(self):
|
|
ab_testing_campaign = super()._cron_process_mass_mailing_ab_testing()
|
|
for campaign in ab_testing_campaign:
|
|
ab_testing_mailings = campaign.mailing_sms_ids.filtered(lambda m: m.ab_testing_enabled)
|
|
if not ab_testing_mailings.filtered(lambda m: m.state == 'done'):
|
|
continue
|
|
ab_testing_mailings.action_send_winner_mailing()
|
|
return ab_testing_campaign
|
|
|
|
|
|
class UtmMedium(models.Model):
|
|
_inherit = 'utm.medium'
|
|
|
|
@api.ondelete(at_uninstall=False)
|
|
def _unlink_except_utm_medium_sms(self):
|
|
utm_medium_sms = self.env.ref('mass_mailing_sms.utm_medium_sms', raise_if_not_found=False)
|
|
if utm_medium_sms and utm_medium_sms in self:
|
|
raise UserError(_(
|
|
"The UTM medium '%s' cannot be deleted as it is used in some main "
|
|
"functional flows, such as the SMS Marketing.",
|
|
utm_medium_sms.name
|
|
))
|