Achraf (abz)
86214d9b6e
What are the steps to reproduce your issue ?
1. Install contacts in a db with demo data
2. Create a contact with complete address
3. Click on Add button (edit mode)
What is currently happening ?
The address get copied but not completely (no zip code, state, street)
What are you expecting to happen ?
The whole address have to be copied
How to fix the bug ?
Don't call the onchange if the record is not yet created
opw-2415891
closes odoo/odoo#64071
X-original-commit: b731afa7918d9d69132af825c414d902aa57541e
Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>
92 lines
3.6 KiB
Python
92 lines
3.6 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from lxml import etree
|
|
|
|
from odoo import api, models, fields
|
|
from odoo.tools.translate import _
|
|
|
|
|
|
class Partner(models.Model):
|
|
_inherit = 'res.partner'
|
|
|
|
country_enforce_cities = fields.Boolean(related='country_id.enforce_cities', readonly=True)
|
|
city_id = fields.Many2one('res.city', string='City of Address')
|
|
|
|
@api.onchange('city_id')
|
|
def _onchange_city_id(self):
|
|
if self.city_id:
|
|
self.city = self.city_id.name
|
|
self.zip = self.city_id.zipcode
|
|
self.state_id = self.city_id.state_id
|
|
elif self._origin:
|
|
self.city = False
|
|
self.zip = False
|
|
self.state_id = False
|
|
|
|
@api.model
|
|
def _fields_view_get_address(self, arch):
|
|
arch = super(Partner, self)._fields_view_get_address(arch)
|
|
# render the partner address accordingly to address_view_id
|
|
doc = etree.fromstring(arch)
|
|
if doc.xpath("//field[@name='city_id']"):
|
|
return arch
|
|
|
|
replacement_xml = """
|
|
<div>
|
|
<field name="country_enforce_cities" invisible="1"/>
|
|
<field name="parent_id" invisible="1"/>
|
|
<field name='city' placeholder="%(placeholder)s" class="o_address_city"
|
|
attrs="{
|
|
'invisible': [('country_enforce_cities', '=', True), '|', ('city_id', '!=', False), ('city', 'in', ['', False ])],
|
|
'readonly': [('type', '=', 'contact')%(parent_condition)s]
|
|
}"
|
|
/>
|
|
<field name='city_id' placeholder="%(placeholder)s" string="%(placeholder)s" class="o_address_city"
|
|
context="{'default_country_id': country_id,
|
|
'default_name': city,
|
|
'default_zipcode': zip,
|
|
'default_state_id': state_id}"
|
|
domain="[('country_id', '=', country_id)]"
|
|
attrs="{
|
|
'invisible': [('country_enforce_cities', '=', False)],
|
|
'readonly': [('type', '=', 'contact')%(parent_condition)s]
|
|
}"
|
|
/>
|
|
</div>
|
|
"""
|
|
|
|
replacement_data = {
|
|
'placeholder': _('City'),
|
|
}
|
|
|
|
def _arch_location(node):
|
|
in_subview = False
|
|
view_type = False
|
|
parent = node.getparent()
|
|
while parent is not None and (not view_type or not in_subview):
|
|
if parent.tag == 'field':
|
|
in_subview = True
|
|
elif parent.tag in ['list', 'tree', 'kanban', 'form']:
|
|
view_type = parent.tag
|
|
parent = parent.getparent()
|
|
return {
|
|
'view_type': view_type,
|
|
'in_subview': in_subview,
|
|
}
|
|
|
|
for city_node in doc.xpath("//field[@name='city']"):
|
|
location = _arch_location(city_node)
|
|
replacement_data['parent_condition'] = ''
|
|
if location['view_type'] == 'form' or not location['in_subview']:
|
|
replacement_data['parent_condition'] = ", ('parent_id', '!=', False)"
|
|
|
|
replacement_formatted = replacement_xml % replacement_data
|
|
for replace_node in etree.fromstring(replacement_formatted).getchildren():
|
|
city_node.addprevious(replace_node)
|
|
parent = city_node.getparent()
|
|
parent.remove(city_node)
|
|
|
|
arch = etree.tostring(doc, encoding='unicode')
|
|
return arch
|