Nicolas (vin)
9e432ed243
There is an issue when computing the suitable payment token ids making it impossible to open a payment for a user without access to payment acquirers. Also, the default computation of payment token was wrong and would never set it correctly. The compute for the method lines in payment would not filter unavailable acquirers line and thus select them by default if they were first in line. Also fix an issue with the ordering of payment method lines X-original-commit: 73410a0fd76a70e1730883d35b79fc603741b59c
140 lines
6.0 KiB
Python
140 lines
6.0 KiB
Python
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo import _, api, Command, fields, models
|
|
from odoo.exceptions import ValidationError
|
|
|
|
|
|
class AccountPayment(models.Model):
|
|
_inherit = 'account.payment'
|
|
|
|
# == Business fields ==
|
|
payment_transaction_id = fields.Many2one(
|
|
string="Payment Transaction", comodel_name='payment.transaction', readonly=True)
|
|
payment_token_id = fields.Many2one(
|
|
string="Saved Payment Token", comodel_name='payment.token', domain="""[
|
|
('id', 'in', suitable_payment_token_ids),
|
|
]""",
|
|
help="Note that only tokens from acquirers allowing to capture the amount are available.")
|
|
|
|
# == Display purpose fields ==
|
|
suitable_payment_token_ids = fields.Many2many(
|
|
comodel_name='payment.token',
|
|
compute='_compute_suitable_payment_token_ids'
|
|
)
|
|
use_electronic_payment_method = fields.Boolean(
|
|
compute='_compute_use_electronic_payment_method',
|
|
help='Technical field used to hide or show the payment_token_id if needed.'
|
|
)
|
|
|
|
@api.depends('payment_method_line_id')
|
|
def _compute_suitable_payment_token_ids(self):
|
|
for payment in self:
|
|
related_partner_ids = (
|
|
payment.partner_id
|
|
| payment.partner_id.commercial_partner_id
|
|
| payment.partner_id.commercial_partner_id.child_ids
|
|
)._origin
|
|
|
|
if payment.use_electronic_payment_method:
|
|
payment.suitable_payment_token_ids = self.env['payment.token'].sudo().search([
|
|
('company_id', '=', payment.company_id.id),
|
|
('acquirer_id.capture_manually', '=', False),
|
|
('partner_id', 'in', related_partner_ids.ids),
|
|
('acquirer_id.journal_id', '=', payment.journal_id.id),
|
|
])
|
|
else:
|
|
payment.suitable_payment_token_ids = [Command.clear()]
|
|
|
|
@api.depends('payment_method_line_id')
|
|
def _compute_use_electronic_payment_method(self):
|
|
for payment in self:
|
|
# Get a list of all electronic payment method codes.
|
|
# These codes are comprised of 'electronic' and the providers of each payment acquirer.
|
|
codes = [key for key in dict(self.env['payment.acquirer']._fields['provider']._description_selection(self.env))]
|
|
payment.use_electronic_payment_method = payment.payment_method_code in codes
|
|
|
|
@api.onchange('partner_id', 'payment_method_line_id', 'journal_id')
|
|
def _onchange_set_payment_token_id(self):
|
|
codes = [key for key in dict(self.env['payment.acquirer']._fields['provider']._description_selection(self.env))]
|
|
if not (self.payment_method_code in codes and self.partner_id and self.journal_id):
|
|
self.payment_token_id = False
|
|
return
|
|
|
|
related_partner_ids = (
|
|
self.partner_id
|
|
| self.partner_id.commercial_partner_id
|
|
| self.partner_id.commercial_partner_id.child_ids
|
|
)._origin
|
|
|
|
self.payment_token_id = self.env['payment.token'].sudo().search([
|
|
('company_id', '=', self.company_id.id),
|
|
('partner_id', 'in', related_partner_ids.ids),
|
|
('acquirer_id.capture_manually', '=', False),
|
|
('acquirer_id.journal_id', '=', self.journal_id.id),
|
|
], limit=1)
|
|
|
|
def _get_payment_chatter_link(self):
|
|
self.ensure_one()
|
|
return f'<a href=# data-oe-model=account.payment data-oe-id={self.id}>{self.name}</a>'
|
|
|
|
def _create_payment_transaction(self, **extra_create_values):
|
|
for payment in self:
|
|
if payment.payment_transaction_id:
|
|
raise ValidationError(_(
|
|
"A payment transaction with reference %s already exists.",
|
|
payment.payment_transaction_id.reference
|
|
))
|
|
elif not payment.payment_token_id:
|
|
raise ValidationError(_("A token is required to create a new payment transaction."))
|
|
|
|
transactions = self.env['payment.transaction']
|
|
for payment in self:
|
|
transaction_vals = payment._prepare_payment_transaction_vals(**extra_create_values)
|
|
transaction = self.env['payment.transaction'].create(transaction_vals)
|
|
transactions += transaction
|
|
payment.payment_transaction_id = transaction # Link the transaction to the payment
|
|
return transactions
|
|
|
|
def _prepare_payment_transaction_vals(self, **extra_create_values):
|
|
self.ensure_one()
|
|
return {
|
|
'acquirer_id': self.payment_token_id.acquirer_id.id,
|
|
'reference': self.ref,
|
|
'amount': self.amount,
|
|
'currency_id': self.currency_id.id,
|
|
'partner_id': self.partner_id.id,
|
|
'token_id': self.payment_token_id.id,
|
|
'operation': 'offline',
|
|
'payment_id': self.id,
|
|
**extra_create_values,
|
|
}
|
|
|
|
def action_post(self):
|
|
# Post the payments "normally" if no transactions are needed.
|
|
# If not, let the acquirer update the state.
|
|
|
|
payments_need_tx = self.filtered(
|
|
lambda p: p.payment_token_id and not p.payment_transaction_id
|
|
)
|
|
# creating the transaction require to access data on payment acquirers, not always accessible to users
|
|
# able to create payments
|
|
transactions = payments_need_tx.sudo()._create_payment_transaction()
|
|
|
|
res = super(AccountPayment, self - payments_need_tx).action_post()
|
|
|
|
for tx in transactions: # Process the transactions with a payment by token
|
|
tx._send_payment_request()
|
|
|
|
# Post payments for issued transactions
|
|
transactions._finalize_post_processing()
|
|
payments_tx_done = payments_need_tx.filtered(
|
|
lambda p: p.payment_transaction_id.state == 'done'
|
|
)
|
|
super(AccountPayment, payments_tx_done).action_post()
|
|
payments_tx_not_done = payments_need_tx.filtered(
|
|
lambda p: p.payment_transaction_id.state != 'done'
|
|
)
|
|
payments_tx_not_done.action_cancel()
|
|
|
|
return res
|