william-andre
9353a6f9ba
Most of the time, rates are computed in a loop by using `<res.currency>._convert`. This leads to a lot of round trips with the database. This PR is caching the value for a whole transaction. In order to do that, the non stored field `rate` has new (missing) contextual dependencies: the arguments of `_get_conversion_rate`. This allows to move the actual computation of the rate to the computed field, and `_get_conversion_rate` is now only a proxy to avoid playing with the context manually; also kept for backward compatibility. Other solutions were considered: * `ormcache`, but we want to avoid creating multiple caches and reduce the possibility to have inter dependent caches. * managing a local cache everywhere, which is cumbersome and error prone * a helper for the previous option by using a converter factory, but it is still an issue when the convert function is called from multiple call functions because the cache isn't shared then. Part-of: odoo/odoo#137609
70 lines
3.0 KiB
Python
70 lines
3.0 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
from lxml import etree
|
|
from odoo import Command
|
|
from odoo.tests.common import TransactionCase
|
|
|
|
|
|
class TestResCurrency(TransactionCase):
|
|
def test_view_company_rate_label(self):
|
|
"""Tests the label of the company_rate and inverse_company_rate fields
|
|
are well set according to the company currency in the currency form view and the currency rate list view.
|
|
e.g. in the currency rate list view of a company using EUR, the company_rate label must be `Unit per EUR`"""
|
|
company_foo, company_bar = self.env['res.company'].create([
|
|
{'name': 'foo', 'currency_id': self.env.ref('base.EUR').id},
|
|
{'name': 'bar', 'currency_id': self.env.ref('base.USD').id},
|
|
])
|
|
for company, expected_currency in [(company_foo, 'EUR'), (company_bar, 'USD')]:
|
|
for model, view_type in [('res.currency', 'form'), ('res.currency.rate', 'tree')]:
|
|
arch = self.env[model].with_company(company).get_view(view_type=view_type)['arch']
|
|
tree = etree.fromstring(arch)
|
|
node_company_rate = tree.xpath('//field[@name="company_rate"]')[0]
|
|
node_inverse_company_rate = tree.xpath('//field[@name="inverse_company_rate"]')[0]
|
|
self.assertEqual(node_company_rate.get('string'), f'Unit per {expected_currency}')
|
|
self.assertEqual(node_inverse_company_rate.get('string'), f'{expected_currency} per Unit')
|
|
|
|
def test_currency_cache(self):
|
|
currencyA, currencyB = self.env['res.currency'].create([{
|
|
'name': 'AAA',
|
|
'symbol': 'AAA',
|
|
'rate_ids': [Command.create({'name': '2010-10-10', 'rate': 1})]
|
|
}, {
|
|
'name': 'BBB',
|
|
'symbol': 'BBB',
|
|
'rate_ids': [
|
|
Command.create({'name': '2010-10-10', 'rate': 1}),
|
|
Command.create({'name': '2011-11-11', 'rate': 2}),
|
|
],
|
|
}])
|
|
|
|
self.assertEqual(currencyA._convert(
|
|
from_amount=100,
|
|
to_currency=currencyB,
|
|
company=self.env.company,
|
|
date='2010-10-10',
|
|
), 100)
|
|
|
|
# only one query is done when changing the convert params
|
|
with self.assertQueryCount(1):
|
|
self.assertEqual(currencyA._convert(
|
|
from_amount=100,
|
|
to_currency=currencyB,
|
|
company=self.env.company,
|
|
date='2011-11-11',
|
|
), 200)
|
|
|
|
# cache holds multiple values
|
|
with self.assertQueryCount(0):
|
|
self.assertEqual(currencyA._convert(
|
|
from_amount=100,
|
|
to_currency=currencyB,
|
|
company=self.env.company,
|
|
date='2010-10-10',
|
|
), 100)
|
|
self.assertEqual(currencyA._convert(
|
|
from_amount=100,
|
|
to_currency=currencyB,
|
|
company=self.env.company,
|
|
date='2011-11-11',
|
|
), 200)
|