Thibault Francois
226df213f2
This commit fix 3 problem Don't count studio field ------------------------ the commit https://github.com/odoo/odoo/commit/75b8c4eb1ed6e44f427886eea06ad216995e16c8 was supposed to stop counting count field generate by addins a smart button with studio. It works fine when base import module is not installed which is never the case. When base_import_module the field is counted as a field that belong to a imported module installed : studio_customization studio_customization should not be counted as an imported module installed Count Field with standard xml_id -------------------------------- With https://github.com/odoo/odoo/commit/9afce4805fc8bac45fdba817488aa867fddff69b Each manual can end up with an xml_id from a standard module: the original module of the model A standard module should never create a manual field so we can consider they should be counted unless they match the criteria of the first problem If a field has a standard module xml_id and no other the module should be odoo/studio and not the name of the standard module Make possible to exclude some db record from cloc ------------------------------------------------- It's possible to exclude some file in python module but it's not possible to exclude some field or SA in the database from the count Make it possible if they are link to an xml_id from the module __cloc_exclude__ The exclude record will be shown in cloc report with the verbose mode closes odoo/odoo#95028 X-original-commit: db52fb174461107e26b066147801f54a89d0dbf9 Related: odoo/enterprise#29007 Signed-off-by: Christophe Simonis <chs@odoo.com>
213 lines
8.5 KiB
Python
213 lines
8.5 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
import json
|
|
from io import BytesIO
|
|
from zipfile import ZipFile
|
|
|
|
from odoo.tools import cloc
|
|
from odoo.addons.base.tests import test_cloc
|
|
|
|
VALID_XML = """
|
|
<templates id="template" xml:space="preserve">
|
|
<t t-name="stock_barcode.LineComponent">
|
|
<div t-if="line.picking_id and line.picking_id.origin" name="origin">
|
|
<i class="fa fa-fw fa-file" />
|
|
<span t-esc="line.picking_id.origin" />
|
|
</div>
|
|
</t>
|
|
</templates>
|
|
"""
|
|
|
|
class TestClocFields(test_cloc.TestClocCustomization):
|
|
|
|
def create_studio_module(self):
|
|
# Studio module does not exist at this stage, so we simulate it
|
|
# Check for existing module in case the test run on an existing database
|
|
if not self.env['ir.module.module'].search([('name', '=', 'studio_customization')]):
|
|
self.env['ir.module.module'].create({
|
|
'author': 'Odoo',
|
|
'imported': True,
|
|
'latest_version': '13.0.1.0.0',
|
|
'name': 'studio_customization',
|
|
'state': 'installed',
|
|
'summary': 'Studio Customization',
|
|
})
|
|
|
|
|
|
def test_fields_from_import_module(self):
|
|
"""
|
|
Check that custom computed fields installed with an imported module
|
|
is counted as customization
|
|
"""
|
|
self.env['ir.module.module'].create({
|
|
'name': 'imported_module',
|
|
'state': 'installed',
|
|
'imported': True,
|
|
})
|
|
f1 = self.create_field('x_imported_field')
|
|
self.create_xml_id('imported_module', 'import_field', f1)
|
|
cl = cloc.Cloc()
|
|
cl.count_customization(self.env)
|
|
self.assertEqual(cl.code.get('imported_module', 0), 1, 'Count fields with xml_id of imported module')
|
|
|
|
def test_fields_from_studio(self):
|
|
self.create_studio_module()
|
|
f1 = self.create_field('x_field_count')
|
|
self.create_xml_id('studio_customization', 'field_count', f1)
|
|
cl = cloc.Cloc()
|
|
cl.count_customization(self.env)
|
|
self.assertEqual(cl.code.get('studio_customization', 0), 0, "Don't count field generated by studio")
|
|
f2 = self.create_field('x_studio_manual_field')
|
|
self.create_xml_id('studio_customization', 'manual_field', f2)
|
|
cl = cloc.Cloc()
|
|
cl.count_customization(self.env)
|
|
self.assertEqual(cl.code.get('studio_customization', 0), 1, "Count manual field created via studio")
|
|
|
|
def test_fields_module_name(self):
|
|
"""
|
|
Check that custom computed fields installed with an imported module
|
|
is counted as customization
|
|
"""
|
|
self.env['ir.module.module'].create({
|
|
'name': 'imported_module',
|
|
'state': 'installed',
|
|
'imported': True,
|
|
})
|
|
f1 = self.create_field('x_imported_field')
|
|
self.create_xml_id('imported_module', 'import_field', f1)
|
|
self.create_xml_id('__export__', 'import_field', f1)
|
|
|
|
sa = self.create_server_action("Test imported double xml_id")
|
|
self.create_xml_id("imported_module", "first", sa)
|
|
self.create_xml_id("__export__", "second", sa)
|
|
cl = cloc.Cloc()
|
|
cl.count_customization(self.env)
|
|
self.assertEqual(cl.code.get('imported_module', 0), 3)
|
|
|
|
def test_count_qweb_imported_module(self):
|
|
self.env['ir.module.module'].create({
|
|
'author': 'Odoo',
|
|
'imported': True,
|
|
'latest_version': '15.0.1.0.0',
|
|
'name': 'test_imported_module',
|
|
'state': 'installed',
|
|
'summary': 'Test imported module for cloc',
|
|
})
|
|
self.create_studio_module()
|
|
|
|
qweb_view = self.env['ir.ui.view'].create({
|
|
"name": "Qweb Test",
|
|
"type": "qweb",
|
|
"mode": "primary",
|
|
"arch_base": "<html>\n <body>\n <t t-out=\"Hello World\"/>\n </body>\n</html>",
|
|
})
|
|
self.create_xml_id('test_imported_module', "qweb_view_test", qweb_view)
|
|
|
|
# Add qweb view from non imported module
|
|
qweb_view = self.env['ir.ui.view'].create({
|
|
"name": "Qweb Test",
|
|
"type": "qweb",
|
|
"arch_base": "<html>\n <body>\n <t t-out=\"Hello World\"/>\n </body>\n</html>",
|
|
})
|
|
self.create_xml_id("studio_customization", "qweb_view_test", qweb_view)
|
|
|
|
# Add form view from module
|
|
form_view = self.env['ir.ui.view'].create({
|
|
"name": "Test partner",
|
|
"type": "form",
|
|
"model": "res.partner",
|
|
"arch_base": "<form>\n <field name=\"name\" \n invisible=\"1\" />\n</form>",
|
|
})
|
|
self.create_xml_id("test_imported_module", "form_view_test", form_view)
|
|
|
|
cl = cloc.Cloc()
|
|
cl.count_customization(self.env)
|
|
self.assertEqual(cl.code.get('test_imported_module', 0), 5, "Count only qweb view from imported module")
|
|
self.assertEqual(cl.code.get('studio_customization', 0), 0, "Do not count from studio_customization module")
|
|
|
|
def test_count_attachment_imported_module(self):
|
|
manifest_content = json.dumps({
|
|
'name': 'test_imported_module',
|
|
'description': 'Test',
|
|
'assets': {
|
|
'web.assets_backend': [
|
|
'test_imported_module/static/src/js/test.js',
|
|
'test_imported_module/static/src/css/test.scss',
|
|
]
|
|
},
|
|
'license': 'LGPL-3',
|
|
})
|
|
|
|
stream = BytesIO()
|
|
with ZipFile(stream, 'w') as archive:
|
|
archive.writestr('test_imported_module/__manifest__.py', manifest_content)
|
|
archive.writestr('test_imported_module/static/src/js/test.js', test_cloc.JS_TEST)
|
|
archive.writestr('test_imported_module/static/src/js/test.scss', test_cloc.SCSS_TEST)
|
|
archive.writestr('test_imported_module/static/src/js/test.xml', VALID_XML)
|
|
|
|
# Import test module
|
|
self.env['ir.module.module'].import_zipfile(stream)
|
|
cl = cloc.Cloc()
|
|
cl.count_customization(self.env)
|
|
self.assertEqual(cl.code.get('test_imported_module', 0), 35)
|
|
|
|
def test_exclude_qweb(self):
|
|
self.env['ir.module.module'].create({
|
|
'author': 'Odoo',
|
|
'imported': True,
|
|
'latest_version': '15.0.1.0.0',
|
|
'name': 'test_imported_module',
|
|
'state': 'installed',
|
|
'summary': 'Test imported module for cloc',
|
|
})
|
|
|
|
qweb_view = self.env['ir.ui.view'].create({
|
|
"name": "Qweb Test",
|
|
"type": "qweb",
|
|
"mode": "primary",
|
|
"arch_base": "<html>\n <body>\n <t t-out=\"Hello World\"/>\n </body>\n</html>",
|
|
})
|
|
self.create_xml_id('test_imported_module', "qweb_view_test", qweb_view)
|
|
self.create_xml_id('__cloc_exclude__', "qweb_view_test", qweb_view)
|
|
|
|
cl = cloc.Cloc()
|
|
cl.count_customization(self.env)
|
|
self.assertEqual(cl.code.get('test_imported_module', 0), 0, "Do not count view with cloc_exclude")
|
|
|
|
def test_exclude_attachment_imported_module(self):
|
|
manifest_content = json.dumps({
|
|
'name': 'test_imported_module',
|
|
'description': 'Test',
|
|
'assets': {
|
|
'web.assets_backend': [
|
|
'test_imported_module/static/src/js/test.js',
|
|
'test_imported_module/static/src/css/test.scss',
|
|
]
|
|
},
|
|
'license': 'LGPL-3',
|
|
})
|
|
|
|
stream = BytesIO()
|
|
with ZipFile(stream, 'w') as archive:
|
|
archive.writestr('test_imported_module/__manifest__.py', manifest_content)
|
|
archive.writestr('test_imported_module/static/src/js/test.js', test_cloc.JS_TEST)
|
|
archive.writestr('test_imported_module/static/src/js/test.scss', test_cloc.SCSS_TEST)
|
|
archive.writestr('test_imported_module/static/src/js/test.xml', VALID_XML)
|
|
|
|
id_names = [
|
|
'attachment_/test_imported_module/static/src/js/test_js',
|
|
'attachment_/test_imported_module/static/src/js/test_scss',
|
|
'attachment_/test_imported_module/static/src/js/test_xml',
|
|
]
|
|
|
|
# Import test module
|
|
self.env['ir.module.module'].import_zipfile(stream)
|
|
# Create exclude xml_id
|
|
for name in id_names:
|
|
rec = self.env.ref(f'test_imported_module.{name}')
|
|
self.create_xml_id('__cloc_exclude__', name, rec)
|
|
|
|
cl = cloc.Cloc()
|
|
cl.count_customization(self.env)
|
|
self.assertEqual(cl.code.get('test_imported_module', 0), 0)
|