dise
51f8d2a7e8
If a project had a single rating associated to its tasks, opening the customer rating view would create a traceback. This happened because both the mail.thread model and the rating.parent.mixin model have a rating_ids field, and project inherits from both of them (mail.thread on its own doesn't have it, but the rating mixin adds it). In the action_view_all_rating method, we try to access the first element of the rating_ids recordset, if the rating_count field is equal to 1. But since the rating_ids field belonged to the mail.thread mixin, and not to the rating.parent.mixin, there could be occurences where rating_count was equal to 1 while the recordset was actually empty ; accessing the first element of the recordset would then create a traceback. To fix this, the rating.parent.mixin model was put before the mail.thread model in the _inherit list, this way the rating_ids field from rating.parent.mixin has the priority. A test was also added to check if the rating_ids is working correctly. task-3360029 closes odoo/odoo#127243 X-original-commit: 1039c80a8ff5e219e9c2679505015288c8d8dd35 Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
245 lines
11 KiB
Python
245 lines
11 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
from lxml import etree
|
|
|
|
from odoo.tests import users
|
|
from odoo.tests.common import TransactionCase
|
|
from odoo.exceptions import UserError
|
|
|
|
|
|
class TestProjectCommon(TransactionCase):
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super(TestProjectCommon, cls).setUpClass()
|
|
|
|
user_group_employee = cls.env.ref('base.group_user')
|
|
user_group_project_user = cls.env.ref('project.group_project_user')
|
|
user_group_project_manager = cls.env.ref('project.group_project_manager')
|
|
|
|
cls.partner_1 = cls.env['res.partner'].create({
|
|
'name': 'Valid Lelitre',
|
|
'email': 'valid.lelitre@agrolait.com'})
|
|
cls.partner_2 = cls.env['res.partner'].create({
|
|
'name': 'Valid Poilvache',
|
|
'email': 'valid.other@gmail.com'})
|
|
cls.partner_3 = cls.env['res.partner'].create({
|
|
'name': 'Valid Poilboeuf',
|
|
'email': 'valid.poilboeuf@gmail.com'})
|
|
|
|
# Test users to use through the various tests
|
|
Users = cls.env['res.users'].with_context({'no_reset_password': True})
|
|
cls.user_public = Users.create({
|
|
'name': 'Bert Tartignole',
|
|
'login': 'bert',
|
|
'email': 'b.t@example.com',
|
|
'signature': 'SignBert',
|
|
'notification_type': 'email',
|
|
'groups_id': [(6, 0, [cls.env.ref('base.group_public').id])]})
|
|
cls.user_portal = Users.create({
|
|
'name': 'Chell Gladys',
|
|
'login': 'chell',
|
|
'email': 'chell@gladys.portal',
|
|
'signature': 'SignChell',
|
|
'notification_type': 'email',
|
|
'groups_id': [(6, 0, [cls.env.ref('base.group_portal').id])]})
|
|
cls.user_projectuser = Users.create({
|
|
'name': 'Armande ProjectUser',
|
|
'login': 'armandel',
|
|
'password': 'armandel',
|
|
'email': 'armande.projectuser@example.com',
|
|
'groups_id': [(6, 0, [user_group_employee.id, user_group_project_user.id])]
|
|
})
|
|
cls.user_projectmanager = Users.create({
|
|
'name': 'Bastien ProjectManager',
|
|
'login': 'bastien',
|
|
'email': 'bastien.projectmanager@example.com',
|
|
'groups_id': [(6, 0, [user_group_employee.id, user_group_project_manager.id])]})
|
|
|
|
# Test 'Pigs' project
|
|
cls.project_pigs = cls.env['project.project'].with_context({'mail_create_nolog': True}).create({
|
|
'name': 'Pigs',
|
|
'privacy_visibility': 'employees',
|
|
'alias_name': 'project+pigs',
|
|
'partner_id': cls.partner_1.id})
|
|
# Already-existing tasks in Pigs
|
|
cls.task_1 = cls.env['project.task'].with_context({'mail_create_nolog': True}).create({
|
|
'name': 'Pigs UserTask',
|
|
'user_ids': cls.user_projectuser,
|
|
'project_id': cls.project_pigs.id})
|
|
cls.task_2 = cls.env['project.task'].with_context({'mail_create_nolog': True}).create({
|
|
'name': 'Pigs ManagerTask',
|
|
'user_ids': cls.user_projectmanager,
|
|
'project_id': cls.project_pigs.id})
|
|
|
|
# Test 'Goats' project, same as 'Pigs', but with 2 stages
|
|
cls.project_goats = cls.env['project.project'].with_context({'mail_create_nolog': True}).create({
|
|
'name': 'Goats',
|
|
'privacy_visibility': 'followers',
|
|
'alias_name': 'project+goats',
|
|
'partner_id': cls.partner_1.id,
|
|
'type_ids': [
|
|
(0, 0, {
|
|
'name': 'New',
|
|
'sequence': 1,
|
|
}),
|
|
(0, 0, {
|
|
'name': 'Won',
|
|
'sequence': 10,
|
|
})]
|
|
})
|
|
|
|
def format_and_process(self, template, to='groups@example.com, other@gmail.com', subject='Frogs',
|
|
extra='', email_from='Sylvie Lelitre <test.sylvie.lelitre@agrolait.com>',
|
|
cc='', msg_id='<1198923581.41972151344608186760.JavaMail@agrolait.com>',
|
|
model=None, target_model='project.task', target_field='name'):
|
|
self.assertFalse(self.env[target_model].search([(target_field, '=', subject)]))
|
|
mail = template.format(to=to, subject=subject, cc=cc, extra=extra, email_from=email_from, msg_id=msg_id)
|
|
self.env['mail.thread'].message_process(model, mail)
|
|
return self.env[target_model].search([(target_field, '=', subject)])
|
|
|
|
|
|
class TestProjectBase(TestProjectCommon):
|
|
|
|
def test_delete_project_with_tasks(self):
|
|
"""Test all tasks linked to a project are removed when the user removes this project. """
|
|
task_type = self.env['project.task.type'].create({'name': 'Won', 'sequence': 1, 'fold': True})
|
|
project_unlink = self.env['project.project'].with_context({'mail_create_nolog': True}).create({
|
|
'name': 'rev',
|
|
'privacy_visibility': 'employees',
|
|
'alias_name': 'rev',
|
|
'partner_id': self.partner_1.id,
|
|
'type_ids': task_type,
|
|
})
|
|
|
|
self.env['project.task'].with_context({'mail_create_nolog': True}).create({
|
|
'name': 'Pigs UserTask',
|
|
'user_ids': self.user_projectuser,
|
|
'project_id': project_unlink.id,
|
|
'stage_id': task_type.id})
|
|
|
|
task_count = len(project_unlink.tasks)
|
|
self.assertEqual(task_count, 1, "The project should have 1 task")
|
|
|
|
project_unlink.unlink()
|
|
self.assertNotEqual(task_count, 0, "The all tasks linked to project should be deleted when user delete the project")
|
|
|
|
def test_auto_assign_stages_when_importing_tasks(self):
|
|
self.assertFalse(self.project_pigs.type_ids)
|
|
self.assertEqual(len(self.project_goats.type_ids), 2)
|
|
first_stage = self.project_goats.type_ids[0]
|
|
self.env['project.task']._load_records_create([{
|
|
'name': 'First Task',
|
|
'project_id': self.project_pigs.id,
|
|
'stage_id': first_stage.id,
|
|
}])
|
|
self.assertEqual(self.project_pigs.type_ids, first_stage)
|
|
self.env['project.task']._load_records_create([
|
|
{
|
|
'name': 'task',
|
|
'project_id': self.project_pigs.id,
|
|
'stage_id': stage.id,
|
|
} for stage in self.project_goats.type_ids
|
|
])
|
|
self.assertEqual(self.project_pigs.type_ids, self.project_goats.type_ids)
|
|
|
|
def test_filter_visibility_unread_messages(self):
|
|
"""Tests the visibility of the "Unread messages" filter in the project task search view
|
|
according to the notification type of the user.
|
|
A user with the email notification type must not see the Unread messages filter
|
|
A user with the inbox notification type must see the Unread messages filter"""
|
|
user1 = self.user_projectuser
|
|
user2 = self.user_projectuser.copy()
|
|
user1.notification_type = 'email'
|
|
user2.notification_type = 'inbox'
|
|
for user, filter_visible_expected in ((user1, False), (user2, True)):
|
|
Task = self.env['project.task'].with_user(user)
|
|
arch = Task.get_view(self.env.ref('project.view_task_search_form').id)['arch']
|
|
tree = etree.fromstring(arch)
|
|
self.assertEqual(bool(tree.xpath('//filter[@name="message_needaction"]')), filter_visible_expected)
|
|
|
|
@users('bastien')
|
|
def test_search_favorite_order(self):
|
|
""" Test the search method, ordering by favorite projects.
|
|
"""
|
|
self.project_goats.favorite_user_ids += self.user_projectmanager
|
|
self.env.cr.flush()
|
|
|
|
Project = self.env['project.project']
|
|
project_ids = [self.project_pigs.id, self.project_goats.id]
|
|
domain = [('id', 'in', project_ids)]
|
|
|
|
self.assertEqual(Project.search(domain, order='is_favorite desc')[0], self.project_goats)
|
|
self.assertEqual(Project.search(domain, order='is_favorite')[-1], self.project_goats)
|
|
|
|
self.assertTrue(self.project_pigs.id < self.project_goats.id)
|
|
self.assertEqual(Project.search(domain, order='id').ids, project_ids)
|
|
|
|
def test_change_project_or_partner_company(self):
|
|
""" Tests that it is impossible to change the company of a project
|
|
if the company of the partner is different and vice versa.
|
|
"""
|
|
company_1 = self.env.company
|
|
company_2 = self.env['res.company'].create({'name': 'Company 2'})
|
|
partner = self.env['res.partner'].create({
|
|
'name': 'Partner',
|
|
})
|
|
self.project_pigs.partner_id = partner
|
|
# Can change the company of a project if the company of the partner is not set
|
|
self.assertFalse(partner.company_id)
|
|
self.project_pigs.company_id = company_2
|
|
self.project_pigs.partner_id.company_id = company_2
|
|
|
|
with self.assertRaises(UserError):
|
|
# Cannot change the company of a partner if the company of the project is different
|
|
partner.company_id = company_1
|
|
|
|
with self.assertRaises(UserError):
|
|
# Cannot change the company of a project if the company of the partner is different
|
|
self.project_pigs.company_id = company_1
|
|
|
|
def test_search_project_root_id(self):
|
|
project = self.env['project.project'].create({
|
|
'name': 'Test project',
|
|
'allow_milestones': False,
|
|
})
|
|
ProjectTask = self.env['project.task']
|
|
parent = ProjectTask.create({
|
|
'name': 'Test task',
|
|
'project_id': project.id,
|
|
})
|
|
child = ProjectTask.create({
|
|
'name': 'Test subtask',
|
|
'parent_id': parent.id,
|
|
})
|
|
tasks = parent | child
|
|
|
|
other_projects = self.project_goats + self.project_pigs
|
|
|
|
self.assertFalse(child.project_id)
|
|
self.assertEqual(child.project_root_id, parent.project_id)
|
|
self.assertEqual(parent.project_root_id, parent.project_id)
|
|
self.assertEqual(ProjectTask.search([('project_root_id', '=', project.id)]), tasks)
|
|
self.assertEqual(ProjectTask.search([('project_root_id', 'in', project.ids)]), tasks)
|
|
self.assertEqual(ProjectTask.search([('project_root_id.allow_milestones', '=', False)]), tasks)
|
|
self.assertEqual(ProjectTask.search(['!', ('project_root_id.allow_milestones', '=', True)]), tasks)
|
|
self.assertEqual(ProjectTask.search([('project_root_id', '=?', project.id)]), tasks)
|
|
self.assertEqual(ProjectTask.search([('project_root_id', 'not in', other_projects.ids), ('id', 'in', tasks.ids)]), tasks)
|
|
self.assertEqual(ProjectTask.search([('project_root_id', '!=', self.project_pigs.id), ('id', 'in', tasks.ids)]), tasks)
|
|
|
|
def test_add_customer_rating_project(self):
|
|
""" Tests that the rating_ids field contains a rating once created
|
|
"""
|
|
rate = self.env['rating.rating'].create({
|
|
'res_id': self.task_1.id,
|
|
'parent_res_id': self.project_pigs.id,
|
|
'res_model_id': self.env['ir.model']._get('project.task').id,
|
|
'parent_res_model_id': self.env['ir.model']._get('project.project').id,
|
|
})
|
|
rating = 5
|
|
|
|
self.task_1.rating_apply(rating, token=rate.access_token)
|
|
|
|
self.project_pigs.rating_ids.invalidate_recordset()
|
|
self.assertEqual(len(self.project_pigs.rating_ids), 1, "There should be 1 rating linked to the project")
|