fw-bot
e72ae1aa0c
Before this commit, we can't use the Generate and Assign Serial Numbers on already existing move line. It always creates new one, even if the picking type use "Pre-fill Detailed Operations". Now, it will edit existing lines, except if we ask to generate more SN than we have unassigned move lines, or if the picking don't use the "Pre-fill Detailed Operations" option, in which cases it will still create new move line with the generated SN. Also, before this commit, paste a list of serial numbers to assign them on multiple move lines in once work only with creation of a new move line for each serial number. Now, it's also work with existing move lines. Finally, some code shared the same logic in `stock.move` in the move line onchange method and in the `_generate_serial_numbers` method. Moves this code in a new method, `_generate_serial_move_line_commands`, and call it in the two previous methods. task-2150561 closes odoo/odoo#42316 Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
353 lines
14 KiB
Python
353 lines
14 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo.exceptions import UserError, ValidationError
|
|
from odoo.tests.common import Form, SavepointCase
|
|
|
|
|
|
class StockGenerate(SavepointCase):
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super(StockGenerate, cls).setUpClass()
|
|
Product = cls.env['product.product']
|
|
cls.product_serial = Product.create({
|
|
'name': 'Tracked by SN',
|
|
'type': 'product',
|
|
'tracking': 'serial',
|
|
})
|
|
cls.uom_unit = cls.env.ref('uom.product_uom_unit')
|
|
|
|
cls.warehouse = cls.env['stock.warehouse'].create({
|
|
'name': 'Base Warehouse',
|
|
'reception_steps': 'one_step',
|
|
'delivery_steps': 'ship_only',
|
|
'code': 'BWH'
|
|
})
|
|
cls.location = cls.env['stock.location'].create({
|
|
'name': 'Room A',
|
|
'location_id': cls.warehouse.lot_stock_id.id,
|
|
})
|
|
cls.location_dest = cls.env['stock.location'].create({
|
|
'name': 'Room B',
|
|
'location_id': cls.warehouse.lot_stock_id.id,
|
|
})
|
|
|
|
cls.Wizard = cls.env['stock.assign.serial']
|
|
|
|
def get_new_move(self, nbre_of_lines):
|
|
move_lines_val = []
|
|
for i in range(nbre_of_lines):
|
|
move_lines_val.append({
|
|
'product_id': self.product_serial.id,
|
|
'product_uom_id': self.uom_unit.id,
|
|
'product_uom_qty': 1,
|
|
'location_id': self.location.id,
|
|
'location_dest_id': self.location_dest.id
|
|
})
|
|
return self.env['stock.move'].create({
|
|
'name': 'Move Test',
|
|
'product_id': self.product_serial.id,
|
|
'product_uom': self.uom_unit.id,
|
|
'location_id': self.location.id,
|
|
'location_dest_id': self.location_dest.id,
|
|
'move_line_ids': [(0, 0, line_vals) for line_vals in move_lines_val]
|
|
})
|
|
|
|
def test_generate_01_sn(self):
|
|
""" Creates a move with 5 move lines, then asks for generates 5 Serial
|
|
Numbers. Checks move has 5 new move lines with each a SN, and the 5
|
|
original move lines are still unchanged.
|
|
"""
|
|
nbre_of_lines = 5
|
|
move = self.get_new_move(nbre_of_lines)
|
|
|
|
form_wizard = Form(self.env['stock.assign.serial'].with_context(
|
|
default_move_id=move.id,
|
|
default_next_serial_number='001',
|
|
default_next_serial_count=nbre_of_lines,
|
|
))
|
|
wiz = form_wizard.save()
|
|
self.assertEqual(len(move.move_line_ids), nbre_of_lines)
|
|
wiz.generate_serial_numbers()
|
|
# Checks new move lines have the right SN
|
|
generated_numbers = ['001', '002', '003', '004', '005']
|
|
self.assertEqual(len(move.move_line_ids), nbre_of_lines + len(generated_numbers))
|
|
for move_line in move.move_line_nosuggest_ids:
|
|
# For a product tracked by SN, the `qty_done` is set on 1 when
|
|
# `lot_name` is set.
|
|
self.assertEqual(move_line.qty_done, 1)
|
|
self.assertEqual(move_line.lot_name, generated_numbers.pop(0))
|
|
# Checks pre-generated move lines didn't change
|
|
for move_line in (move.move_line_ids - move.move_line_nosuggest_ids):
|
|
self.assertEqual(move_line.qty_done, 0)
|
|
self.assertEqual(move_line.lot_name, False)
|
|
|
|
def test_generate_02_prefix_suffix(self):
|
|
""" Generates some Serial Numbers and checks the prefix and/or suffix
|
|
are correctly used.
|
|
"""
|
|
nbre_of_lines = 10
|
|
# Case #1: Prefix, no suffix
|
|
move = self.get_new_move(nbre_of_lines)
|
|
form_wizard = Form(self.env['stock.assign.serial'].with_context(
|
|
default_move_id=move.id,
|
|
default_next_serial_number='bilou-87',
|
|
default_next_serial_count=nbre_of_lines,
|
|
))
|
|
wiz = form_wizard.save()
|
|
wiz.generate_serial_numbers()
|
|
# Checks all move lines have the right SN
|
|
generated_numbers = [
|
|
'bilou-87', 'bilou-88', 'bilou-89', 'bilou-90', 'bilou-91',
|
|
'bilou-92', 'bilou-93', 'bilou-94', 'bilou-95', 'bilou-96'
|
|
]
|
|
for move_line in move.move_line_nosuggest_ids:
|
|
# For a product tracked by SN, the `qty_done` is set on 1 when
|
|
# `lot_name` is set.
|
|
self.assertEqual(move_line.qty_done, 1)
|
|
self.assertEqual(
|
|
move_line.lot_name,
|
|
generated_numbers.pop(0)
|
|
)
|
|
|
|
# Case #2: No prefix, suffix
|
|
move = self.get_new_move(nbre_of_lines)
|
|
form_wizard = Form(self.env['stock.assign.serial'].with_context(
|
|
default_move_id=move.id,
|
|
default_next_serial_number='005-ccc',
|
|
default_next_serial_count=nbre_of_lines,
|
|
))
|
|
wiz = form_wizard.save()
|
|
wiz.generate_serial_numbers()
|
|
# Checks all move lines have the right SN
|
|
generated_numbers = [
|
|
'005-ccc', '006-ccc', '007-ccc', '008-ccc', '009-ccc',
|
|
'010-ccc', '011-ccc', '012-ccc', '013-ccc', '014-ccc'
|
|
]
|
|
for move_line in move.move_line_nosuggest_ids:
|
|
# For a product tracked by SN, the `qty_done` is set on 1 when
|
|
# `lot_name` is set.
|
|
self.assertEqual(move_line.qty_done, 1)
|
|
self.assertEqual(
|
|
move_line.lot_name,
|
|
generated_numbers.pop(0)
|
|
)
|
|
|
|
# Case #3: Prefix + suffix
|
|
move = self.get_new_move(nbre_of_lines)
|
|
form_wizard = Form(self.env['stock.assign.serial'].with_context(
|
|
default_move_id=move.id,
|
|
default_next_serial_number='alpha-012-345-beta',
|
|
default_next_serial_count=nbre_of_lines,
|
|
))
|
|
wiz = form_wizard.save()
|
|
wiz.generate_serial_numbers()
|
|
# Checks all move lines have the right SN
|
|
generated_numbers = [
|
|
'alpha-012-345-beta', 'alpha-012-346-beta', 'alpha-012-347-beta',
|
|
'alpha-012-348-beta', 'alpha-012-349-beta', 'alpha-012-350-beta',
|
|
'alpha-012-351-beta', 'alpha-012-352-beta', 'alpha-012-353-beta',
|
|
'alpha-012-354-beta'
|
|
]
|
|
for move_line in move.move_line_nosuggest_ids:
|
|
# For a product tracked by SN, the `qty_done` is set on 1 when
|
|
# `lot_name` is set.
|
|
self.assertEqual(move_line.qty_done, 1)
|
|
self.assertEqual(
|
|
move_line.lot_name,
|
|
generated_numbers.pop(0)
|
|
)
|
|
|
|
def test_generate_03_raise_exception(self):
|
|
""" Tries to generate some SN but with invalid initial number.
|
|
"""
|
|
move = self.get_new_move(3)
|
|
form_wizard = Form(self.env['stock.assign.serial'].with_context(
|
|
default_move_id=move.id,
|
|
default_next_serial_number='code-xxx',
|
|
))
|
|
wiz = form_wizard.save()
|
|
with self.assertRaises(UserError):
|
|
wiz.generate_serial_numbers()
|
|
|
|
form_wizard.next_serial_count = 0
|
|
# Must raise an exception because `next_serial_count` must be greater than 0.
|
|
with self.assertRaises(ValidationError):
|
|
form_wizard.save()
|
|
|
|
def test_generate_04_generate_in_multiple_time(self):
|
|
""" Generates a Serial Number for each move lines (except the last one)
|
|
but with multiple assignments, and checks the generated Serial Numbers
|
|
are what we expect.
|
|
"""
|
|
nbre_of_lines = 10
|
|
move = self.get_new_move(nbre_of_lines)
|
|
|
|
form_wizard = Form(self.env['stock.assign.serial'].with_context(
|
|
default_move_id=move.id,
|
|
))
|
|
# First assignment
|
|
form_wizard.next_serial_count = 3
|
|
form_wizard.next_serial_number = '001'
|
|
wiz = form_wizard.save()
|
|
wiz.generate_serial_numbers()
|
|
# Second assignment
|
|
form_wizard.next_serial_count = 2
|
|
form_wizard.next_serial_number = 'bilou-64'
|
|
wiz = form_wizard.save()
|
|
wiz.generate_serial_numbers()
|
|
# Third assignment
|
|
form_wizard.next_serial_count = 4
|
|
form_wizard.next_serial_number = 'ro-1337-bot'
|
|
wiz = form_wizard.save()
|
|
wiz.generate_serial_numbers()
|
|
|
|
# Checks all move lines have the right SN
|
|
generated_numbers = [
|
|
# Correspond to the first assignment
|
|
'001', '002', '003',
|
|
# Correspond to the second assignment
|
|
'bilou-64', 'bilou-65',
|
|
# Correspond to the third assignment
|
|
'ro-1337-bot', 'ro-1338-bot', 'ro-1339-bot', 'ro-1340-bot',
|
|
]
|
|
self.assertEqual(len(move.move_line_ids), nbre_of_lines + len(generated_numbers))
|
|
self.assertEqual(len(move.move_line_nosuggest_ids), len(generated_numbers))
|
|
for move_line in move.move_line_nosuggest_ids:
|
|
self.assertEqual(move_line.qty_done, 1)
|
|
self.assertEqual(move_line.lot_name, generated_numbers.pop(0))
|
|
for move_line in (move.move_line_ids - move.move_line_nosuggest_ids):
|
|
self.assertEqual(move_line.qty_done, 0)
|
|
self.assertEqual(move_line.lot_name, False)
|
|
|
|
def test_generate_with_putaway(self):
|
|
""" Checks the `location_dest_id` of generated move lines is correclty
|
|
set in fonction of defined putaway rules.
|
|
"""
|
|
nbre_of_lines = 4
|
|
shelf_location = self.env['stock.location'].create({
|
|
'name': 'shelf1',
|
|
'usage': 'internal',
|
|
'location_id': self.location_dest.id,
|
|
})
|
|
|
|
# Checks a first time without putaway...
|
|
move = self.get_new_move(nbre_of_lines)
|
|
form_wizard = Form(self.env['stock.assign.serial'].with_context(
|
|
default_move_id=move.id,
|
|
))
|
|
form_wizard.next_serial_count = nbre_of_lines
|
|
form_wizard.next_serial_number = '001'
|
|
wiz = form_wizard.save()
|
|
wiz.generate_serial_numbers()
|
|
|
|
for move_line in move.move_line_nosuggest_ids:
|
|
self.assertEqual(move_line.qty_done, 1)
|
|
# The location dest must be the default one.
|
|
self.assertEqual(move_line.location_dest_id.id, self.location_dest.id)
|
|
|
|
# We need to activate multi-locations to use putaway rules.
|
|
grp_multi_loc = self.env.ref('stock.group_stock_multi_locations')
|
|
self.env.user.write({'groups_id': [(4, grp_multi_loc.id)]})
|
|
# Creates a putaway rule
|
|
putaway_product = self.env['stock.putaway.rule'].create({
|
|
'product_id': self.product_serial.id,
|
|
'location_in_id': self.location_dest.id,
|
|
'location_out_id': shelf_location.id,
|
|
})
|
|
|
|
# Checks now with putaway...
|
|
move = self.get_new_move(nbre_of_lines)
|
|
form_wizard = Form(self.env['stock.assign.serial'].with_context(
|
|
default_move_id=move.id,
|
|
))
|
|
form_wizard.next_serial_count = nbre_of_lines
|
|
form_wizard.next_serial_number = '001'
|
|
wiz = form_wizard.save()
|
|
wiz.generate_serial_numbers()
|
|
|
|
for move_line in move.move_line_nosuggest_ids:
|
|
self.assertEqual(move_line.qty_done, 1)
|
|
# The location dest must be now the one from the putaway.
|
|
self.assertEqual(move_line.location_dest_id.id, shelf_location.id)
|
|
def test_set_multiple_lot_name_01(self):
|
|
""" Sets five SN in one time in stock move view form, then checks move
|
|
has five new move lines with the right `lot_name`.
|
|
"""
|
|
nbre_of_lines = 10
|
|
picking_type = self.env['stock.picking.type'].search([
|
|
('use_create_lots', '=', True),
|
|
('warehouse_id', '=', self.warehouse.id)
|
|
])
|
|
move = self.get_new_move(nbre_of_lines)
|
|
move.picking_type_id = picking_type
|
|
# We must begin with a move with 10 move lines.
|
|
self.assertEqual(len(move.move_line_ids), nbre_of_lines)
|
|
|
|
value_list = [
|
|
'abc-235',
|
|
'abc-237',
|
|
'abc-238',
|
|
'abc-282',
|
|
'abc-301',
|
|
]
|
|
values = '\n'.join(value_list)
|
|
|
|
move_form = Form(move, view='stock.view_stock_move_nosuggest_operations')
|
|
with move_form.move_line_nosuggest_ids.new() as line:
|
|
line.lot_name = values
|
|
move = move_form.save()
|
|
|
|
# After we set multiple SN, we must have now 15 move lines.
|
|
self.assertEqual(len(move.move_line_ids), nbre_of_lines + len(value_list))
|
|
# Then we look each SN name is correct.
|
|
for move_line in move.move_line_nosuggest_ids:
|
|
self.assertEqual(move_line.lot_name, value_list.pop(0))
|
|
for move_line in (move.move_line_ids - move.move_line_nosuggest_ids):
|
|
self.assertEqual(move_line.lot_name, False)
|
|
|
|
def test_set_multiple_lot_name_02_empty_values(self):
|
|
""" Sets multiple values with some empty lines in one time, then checks
|
|
we haven't create useless move line and all move line's `lot_name` have
|
|
been correctly set.
|
|
"""
|
|
nbre_of_lines = 5
|
|
picking_type = self.env['stock.picking.type'].search([
|
|
('use_create_lots', '=', True),
|
|
('warehouse_id', '=', self.warehouse.id)
|
|
])
|
|
move = self.get_new_move(nbre_of_lines)
|
|
move.picking_type_id = picking_type
|
|
# We must begin with a move with five move lines.
|
|
self.assertEqual(len(move.move_line_ids), nbre_of_lines)
|
|
|
|
value_list = [
|
|
'',
|
|
'abc-235',
|
|
'',
|
|
'abc-237',
|
|
'',
|
|
'',
|
|
'abc-238',
|
|
'abc-282',
|
|
'abc-301',
|
|
'',
|
|
]
|
|
values = '\n'.join(value_list)
|
|
|
|
# Checks we have more values than move lines.
|
|
self.assertTrue(len(move.move_line_ids) < len(value_list))
|
|
move_form = Form(move, view='stock.view_stock_move_nosuggest_operations')
|
|
with move_form.move_line_nosuggest_ids.new() as line:
|
|
line.lot_name = values
|
|
move = move_form.save()
|
|
|
|
filtered_value_list = list(filter(lambda line: len(line), value_list))
|
|
# After we set multiple SN, we must have a line for each value.
|
|
self.assertEqual(len(move.move_line_ids), nbre_of_lines + len(filtered_value_list))
|
|
# Then we look each SN name is correct.
|
|
for move_line in move.move_line_nosuggest_ids:
|
|
self.assertEqual(move_line.lot_name, filtered_value_list.pop(0))
|
|
for move_line in (move.move_line_ids - move.move_line_nosuggest_ids):
|
|
self.assertEqual(move_line.lot_name, False)
|