Samuel Degueldre
2e81f53a2a
In #45174, the original_id field was added on ir.attachment, so that derived images in the web-editor (cropped, resized, optimized, ...) could keep a trace of the original, such that if the user wanted to revert it or change the crop/size/optimization parameter, we could do it from the original again so that for example the quality can be increased or the crop region made bigger. The addition of this self-referencing many2one from ir.attachment to itself however will cause DELETE queries on ir.attachment to do a sequential scan on the table to update potential records referencing the deleted record in their original_id field. As the ir.attachment table tends to be one of the biggest tables in production databases (millions of records), this scan can take multiple seconds per DELETE operation, and since attachments are used everywhere in odoo to represent files, DELETE operations on them are frequent. Adding an index on the original_id field should make these DELETE operations substantially faster (scaling with the log of the number of filled original_id fields, which will be very small, instead of scaling linearly with number of records) closes odoo/odoo#54676 X-original-commit: 2b5064a00b7a5c8dc66429869287386f244b1257 Signed-off-by: Olivier Dony (odo) <odo@openerp.com> Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
62 lines
2.6 KiB
Python
62 lines
2.6 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from werkzeug.urls import url_quote
|
|
|
|
from odoo import api, models, fields, tools
|
|
|
|
|
|
class IrAttachment(models.Model):
|
|
|
|
_inherit = "ir.attachment"
|
|
|
|
local_url = fields.Char("Attachment URL", compute='_compute_local_url')
|
|
image_src = fields.Char(compute='_compute_image_src')
|
|
image_width = fields.Integer(compute='_compute_image_size')
|
|
image_height = fields.Integer(compute='_compute_image_size')
|
|
original_id = fields.Many2one('ir.attachment', string="Original (unoptimized, unresized) attachment", index=True)
|
|
|
|
def _compute_local_url(self):
|
|
for attachment in self:
|
|
if attachment.url:
|
|
attachment.local_url = attachment.url
|
|
else:
|
|
attachment.local_url = '/web/image/%s?unique=%s' % (attachment.id, attachment.checksum)
|
|
|
|
@api.depends('mimetype', 'url', 'name')
|
|
def _compute_image_src(self):
|
|
for attachment in self:
|
|
# Only add a src for supported images
|
|
if attachment.mimetype not in ['image/gif', 'image/jpe', 'image/jpeg', 'image/jpg', 'image/gif', 'image/png', 'image/svg+xml']:
|
|
attachment.image_src = False
|
|
continue
|
|
|
|
if attachment.type == 'url':
|
|
attachment.image_src = attachment.url
|
|
else:
|
|
# Adding unique in URLs for cache-control
|
|
unique = attachment.checksum[:8]
|
|
if attachment.url:
|
|
# For attachments-by-url, unique is used as a cachebuster. They
|
|
# currently do not leverage max-age headers.
|
|
attachment.image_src = '%s?unique=%s' % (attachment.url, unique)
|
|
else:
|
|
name = url_quote(attachment.name)
|
|
attachment.image_src = '/web/image/%s-%s/%s' % (attachment.id, unique, name)
|
|
|
|
@api.depends('datas')
|
|
def _compute_image_size(self):
|
|
for attachment in self:
|
|
try:
|
|
image = tools.base64_to_image(attachment.datas)
|
|
attachment.image_width = image.width
|
|
attachment.image_height = image.height
|
|
except Exception:
|
|
attachment.image_width = 0
|
|
attachment.image_height = 0
|
|
|
|
def _get_media_info(self):
|
|
"""Return a dict with the values that we need on the media dialog."""
|
|
self.ensure_one()
|
|
return self._read_format(['id', 'name', 'description', 'mimetype', 'checksum', 'url', 'type', 'res_id', 'res_model', 'public', 'access_token', 'image_src', 'image_width', 'image_height', 'original_id'])[0]
|