Gorash
ba1a5509fa
In this viewtiverse, the heroes remove the context dependencies for `get_views`, from the views and python fields (such as domain). To reduce inconsistencies and the number of rpc. Current issues: * There may be inconsistencies in views at the JavaScript level. Some overrides modify the behavior of get_views or domains on fields via context keys, therefore by changing the action, the rendering may be different. However, these views are cached. However, the cache key (Javascript) does not reflect the entire context, and requires additional post-processing from the server. * Multiple rpc for the same rendering. get_views being dependent on the context, as soon as it changes, a new rpc is performed. In most cases, when JavaScript needs the same view, there is no change depending on the context, the rpc is useless. * Inconsistency when rendering subviews, some views could be different depending on the context, this context can be modified in the view itself via the context attributes. However, the JavaScript client does not redo an rpc for each change of these sub-contexts. Therefore the result may be inconsistent. Solution: Limit as much as possible the number of context keys provided when calling get_views, and use the context provided as a cache key. The authorized keys are 'lang' and '*_view_ref'. For the cache key, options are added in the get_views method. Instead of using the context, it is inserted into python expressions. This will be evaluated by JavaScript and thus avoids inconsistencies. task-3414108 task-3414068 closes odoo/odoo#135145 Related: odoo/enterprise#47584 Signed-off-by: Raphael Collet <rco@odoo.com>
55 lines
1.9 KiB
Python
55 lines
1.9 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from odoo import api, fields, models
|
|
|
|
|
|
class Board(models.AbstractModel):
|
|
_name = 'board.board'
|
|
_description = "Board"
|
|
_auto = False
|
|
|
|
# This is necessary for when the web client opens a dashboard. Technically
|
|
# speaking, the dashboard is a form view, and opening it makes the client
|
|
# initialize a dummy record by invoking onchange(). And the latter requires
|
|
# an 'id' field to work properly...
|
|
id = fields.Id()
|
|
|
|
@api.model_create_multi
|
|
def create(self, vals_list):
|
|
return self
|
|
|
|
@api.model
|
|
def get_view(self, view_id=None, view_type='form', **options):
|
|
"""
|
|
Overrides orm field_view_get.
|
|
@return: Dictionary of Fields, arch and toolbar.
|
|
"""
|
|
|
|
res = super().get_view(view_id, view_type, **options)
|
|
|
|
custom_view = self.env['ir.ui.view.custom'].sudo().search([('user_id', '=', self.env.uid), ('ref_id', '=', view_id)], limit=1)
|
|
if custom_view:
|
|
res.update({'custom_view_id': custom_view.id,
|
|
'arch': custom_view.arch})
|
|
res['arch'] = self._arch_preprocessing(res['arch'])
|
|
return res
|
|
|
|
@api.model
|
|
def _arch_preprocessing(self, arch):
|
|
from lxml import etree
|
|
|
|
def remove_unauthorized_children(node):
|
|
for child in node.iterchildren():
|
|
if child.tag == 'action' and child.get('invisible'):
|
|
node.remove(child)
|
|
else:
|
|
remove_unauthorized_children(child)
|
|
return node
|
|
|
|
archnode = etree.fromstring(arch)
|
|
# add the js_class 'board' on the fly to force the webclient to
|
|
# instantiate a BoardView instead of FormView
|
|
archnode.set('js_class', 'board')
|
|
return etree.tostring(remove_unauthorized_children(archnode), pretty_print=True, encoding='unicode')
|