Aaron Bohy
31fcd5a0f1
Before this commit, it might happen that, in some situations, with several tabs opened, the CrossTabBus called the longpolling route repeatedly, thus slowing down the server, and freezing the webclient. The issue was tricky to reproduce. It was a race-condition that could occur when several tabs performed simultanous calls to addChannel, while being unloaded or becoming mastertab in the meantime (e.g. when opening/closing/refreshing several tabs simultaneously). This issue has been introduced by [1] which by mistake (probably) made each tab calling itself the localStorage to update the list of channels when it was notified that the list of channels in the localStorage just changed. So if several tabs had a slightly different list of channels at a given moment (e.g. at startup), it might happen that they in turn, undo what another tab just put in the localStorage, and thus produced an infinite loop of localStorage writes and longpolling request aborts/calls. The issue could be reproduced with the OCA module [2], which performs several addChannel at webclient startup. This commit restores this part of the code as it was initially written in [3]. Closes #69067 opw~2502799 maybe opw~2451865 as well [1] https://github.com/odoo/odoo/commit/6448420 [2] https://odoo-community.org/shop/product/web-notify-2670#attr=10773 [3] https://github.com/odoo/odoo/commit/38581f67236377daa767ca2216529a26b8708b00#diff-f6eccad21ae3543606ab8f97b8b097d015412caeaee2bf8cc928eb3ccabac9f5R149 closes odoo/odoo#69777 X-original-commit: a52aa41d04330efb81090409ec7fbcbbedaca317 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com> Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>