oco-odoo
eaf5d86fe7
https://github.com/odoo/odoo/pull/68253 fixed a bug in check_vat that caused it not to run any check when called on a partner with no country. However, doing this caused another issue because of an ORM limitation: when writing vat and country_id with a single write() on the res.company, two distinct write are triggered on the related res.partner, one for each field. Both those write trigger the check_vat constraint. Depending on the order in which the keys of the dictionnary passed to res.company's write were ordered, country_id could or could not be written before vat. If vat was written first and did not start with a country code, the write() on res.partner failed the constraint, because country_id wasn't set yet. This was wrong, but used to pass as there was no country_id on the partner, before https://github.com/odoo/odoo/pull/68253 fixed that. To circumvent the issue, we now allow entering any vat number without performing any check if it does not start with a country code and no country_id is set on the partner. closes odoo/odoo#69243 X-original-commit: 7036b671228fdb5986b4f62a610a2e4d4132b8b1 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com> Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
96 lines
3.9 KiB
Python
96 lines
3.9 KiB
Python
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
from odoo.tests.common import TransactionCase, tagged
|
|
from odoo.exceptions import ValidationError
|
|
from unittest.mock import patch
|
|
|
|
import stdnum.eu.vat
|
|
|
|
|
|
class TestStructure(TransactionCase):
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
def check_vies(vat_number):
|
|
return {'valid': vat_number == 'BE0477472701'}
|
|
|
|
super().setUpClass()
|
|
cls.env.user.company_id.vat_check_vies = False
|
|
cls._vies_check_func = check_vies
|
|
|
|
def test_peru_ruc_format(self):
|
|
"""Only values that has the length of 11 will be checked as RUC, that's what we are proving. The second part
|
|
will check for a valid ruc and there will be no problem at all.
|
|
"""
|
|
partner = self.env['res.partner'].create({'name': "Dummy partner", 'country_id': self.env.ref('base.pe').id})
|
|
|
|
with self.assertRaises(ValidationError):
|
|
partner.vat = '11111111111'
|
|
partner.vat = '20507822470'
|
|
|
|
def test_vat_country_difference(self):
|
|
"""Test the validation when country code is different from vat code"""
|
|
partner = self.env['res.partner'].create({
|
|
'name': "Test",
|
|
'country_id': self.env.ref('base.mx').id,
|
|
'vat': 'RORO790707I47',
|
|
})
|
|
self.assertEqual(partner.vat, 'RORO790707I47', "Partner VAT should not be altered")
|
|
|
|
def test_parent_validation(self):
|
|
"""Test the validation with company and contact"""
|
|
|
|
# set an invalid vat number
|
|
self.env.user.company_id.vat_check_vies = False
|
|
company = self.env["res.partner"].create({
|
|
"name": "World Company",
|
|
"country_id": self.env.ref("base.be").id,
|
|
"vat": "ATU12345675",
|
|
"company_type": "company",
|
|
})
|
|
contact = self.env["res.partner"].create({
|
|
"name": "Sylvestre",
|
|
"parent_id": company.id,
|
|
"company_type": "person",
|
|
})
|
|
|
|
# reactivate it and correct the vat number
|
|
with patch('odoo.addons.base_vat.models.res_partner.check_vies', type(self)._vies_check_func):
|
|
self.env.user.company_id.vat_check_vies = True
|
|
with self.assertRaises(ValidationError), self.env.cr.savepoint():
|
|
company.vat = "BE0987654321" # VIES refused, don't fallback on other check
|
|
company.vat = "BE0477472701"
|
|
|
|
def test_vat_syntactic_validation(self):
|
|
""" Tests VAT validation (both successes and failures), with the different country
|
|
detection cases possible.
|
|
"""
|
|
test_partner = self.env['res.partner'].create({'name': "John Dex"})
|
|
|
|
# VAT starting with country code: use the starting country code
|
|
test_partner.write({'vat': 'BE0477472701', 'country_id': self.env.ref('base.fr').id})
|
|
test_partner.write({'vat': 'BE0477472701', 'country_id': None})
|
|
|
|
with self.assertRaises(ValidationError):
|
|
test_partner.write({'vat': 'BE42', 'country_id': self.env.ref('base.fr').id})
|
|
|
|
with self.assertRaises(ValidationError):
|
|
test_partner.write({'vat': 'BE42', 'country_id': None})
|
|
|
|
# No country code in VAT: use the partner's country
|
|
test_partner.write({'vat': '0477472701', 'country_id': self.env.ref('base.be').id})
|
|
|
|
with self.assertRaises(ValidationError):
|
|
test_partner.write({'vat': '42', 'country_id': self.env.ref('base.be').id})
|
|
|
|
# If no country can be guessed: VAT number should always be considered valid
|
|
# (for technical reasons due to ORM and res.company making related fields towards res.partner for country_id and vat)
|
|
test_partner.write({'vat': '0477472701', 'country_id': None})
|
|
|
|
|
|
@tagged('-standard', 'external')
|
|
class TestStructureVIES(TestStructure):
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super().setUpClass()
|
|
cls.env.user.company_id.vat_check_vies = True
|
|
cls._vies_check_func = stdnum.eu.vat.check_vies
|