Julien Castiaux
ab4000fb3c
TL;DR: remember `osv` and `except_orm` ? You can forget about them. * Deprecated `except_orm` dropped. * `UserError` elevated as super type of all user-related errors. * Unused `DeferredException` dropped. * Unused `QWebException` dropped (real one is in `qweb.py`). * `MailDeliveryException` made a python exception. * `name` legacy exception attribute made an alias of the python standard `args[0]` attribute and deprecated. * `value` legacy exception attribute dropped. * `exception_type` RPC error response key dropped. * Deprecated `osv` module dropped. * `--osv-memory-age-limit` cli option made an alias of `--transient-age-limit` and deprecated. The `odoo.exceptions.Warning` have long been a deprecated alias to `UserError`. It is going to be removed in a future version but first we explicitly deprecate it with a warning. The `odoo.exceptions.DeferredException` was a very old internal exception, it has been removed without deprecation notice as it is never raised. The `odoo.exceptions.except_orm` has been a deprecated exception type with deprecation warning for 5 years, it has been removed in favor of UserError which becomes the super class of all user-related errors. The `odoo.base.models.ir_mail_server.MailDeliveryException` was inheriting `except_orm`. As it is not related to a user error but is more of a problem an admin much take care of, the exception has been made a Python error. The `exception_type` JSON key in RPC error responses was holding an hardcoded value derived from the exception type. Its usage has been dropped in favor of the `name` JSON key that holds the precise exception name. Again as it was hardly used in the source code (beside the crash manager) it has been dropped without deprecation warning. Since we are here trying to clean odoo custom exceptions, we are also deprecating the `name` exception attribute in favor of the more standard `args[0]` attribute. The `name` (along with `value`) were two attributes used to raise `except_orm` exceptions before the introduction of `UserError`, `AccessError` and related exceptions. The `name` attribute, at the time, was holding the exception type/title. Nowadays it contains the error message. The `value` attribute, at the time, was holding the error message. Nowadays it is no more used. The `osv` module contains very old deprecated aliases. There is no simple way to log a deprecation warning for osv, osv_memory and osv_abstract but as they have not been in use for ages, they have been removed too. To be consistent, the `--osv-memory-age-limit` cli option has been made a deprecated alias to the `--transient-age-limit`. closes odoo/odoo#45723 Task: 2187728 Related: odoo/enterprise#9162 Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
47 lines
1.3 KiB
Python
47 lines
1.3 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
""" Tests for the configuration file/command-line arguments. """
|
|
|
|
# This test should be run from its directory.
|
|
|
|
# TODO A configmanager object cannot parse multiple times a config file
|
|
# and/or the command line, preventing to 'reload' a configuration.
|
|
|
|
import os
|
|
|
|
from . import config
|
|
|
|
config_file_00 = os.path.join(os.path.dirname(__file__),'test-config-values-00.conf')
|
|
|
|
# 1. No config file, no command-line arguments (a.k.a. default values)
|
|
|
|
conf = config.configmanager()
|
|
conf.parse_config()
|
|
|
|
assert conf['transient_age_limit'] == 1.0
|
|
assert os.path.join(conf['root_path'], 'addons') == conf['addons_path']
|
|
|
|
# 2. No config file, some command-line arguments
|
|
|
|
conf = config.configmanager()
|
|
# mess with the optparse.Option definition to allow an invalid path
|
|
conf.casts['addons_path'].action = 'store'
|
|
conf.parse_config(['--addons-path=/xyz/dont-exist', '--transient-age-limit=2.3'])
|
|
|
|
assert conf['transient_age_limit'] == 2.3
|
|
assert conf['addons_path'] == '/xyz/dont-exist'
|
|
|
|
# 3. Config file, no command-line arguments
|
|
|
|
conf = config.configmanager()
|
|
conf.parse_config(['-c', config_file_00])
|
|
|
|
assert conf['transient_age_limit'] == 3.4
|
|
|
|
# 4. Config file, and command-line arguments
|
|
|
|
conf = config.configmanager()
|
|
conf.parse_config(['-c', config_file_00, '--transient-age-limit=2.3'])
|
|
|
|
assert conf['transient_age_limit'] == 2.3
|