TL;DR: remember `osv` and `except_orm` ? You can forget about them. * Deprecated `except_orm` dropped. * `UserError` elevated as super type of all user-related errors. * Unused `DeferredException` dropped. * Unused `QWebException` dropped (real one is in `qweb.py`). * `MailDeliveryException` made a python exception. * `name` legacy exception attribute made an alias of the python standard `args[0]` attribute and deprecated. * `value` legacy exception attribute dropped. * `exception_type` RPC error response key dropped. * Deprecated `osv` module dropped. * `--osv-memory-age-limit` cli option made an alias of `--transient-age-limit` and deprecated. The `odoo.exceptions.Warning` have long been a deprecated alias to `UserError`. It is going to be removed in a future version but first we explicitly deprecate it with a warning. The `odoo.exceptions.DeferredException` was a very old internal exception, it has been removed without deprecation notice as it is never raised. The `odoo.exceptions.except_orm` has been a deprecated exception type with deprecation warning for 5 years, it has been removed in favor of UserError which becomes the super class of all user-related errors. The `odoo.base.models.ir_mail_server.MailDeliveryException` was inheriting `except_orm`. As it is not related to a user error but is more of a problem an admin much take care of, the exception has been made a Python error. The `exception_type` JSON key in RPC error responses was holding an hardcoded value derived from the exception type. Its usage has been dropped in favor of the `name` JSON key that holds the precise exception name. Again as it was hardly used in the source code (beside the crash manager) it has been dropped without deprecation warning. Since we are here trying to clean odoo custom exceptions, we are also deprecating the `name` exception attribute in favor of the more standard `args[0]` attribute. The `name` (along with `value`) were two attributes used to raise `except_orm` exceptions before the introduction of `UserError`, `AccessError` and related exceptions. The `name` attribute, at the time, was holding the exception type/title. Nowadays it contains the error message. The `value` attribute, at the time, was holding the error message. Nowadays it is no more used. The `osv` module contains very old deprecated aliases. There is no simple way to log a deprecation warning for osv, osv_memory and osv_abstract but as they have not been in use for ages, they have been removed too. To be consistent, the `--osv-memory-age-limit` cli option has been made a deprecated alias to the `--transient-age-limit`. closes odoo/odoo#45723 Task: 2187728 Related: odoo/enterprise#9162 Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
129 lines
3.3 KiB
Python
129 lines
3.3 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
"""The Odoo Exceptions module defines a few core exception types.
|
|
|
|
Those types are understood by the RPC layer.
|
|
Any other exception type bubbling until the RPC layer will be
|
|
treated as a 'Server error'.
|
|
|
|
.. note::
|
|
If you consider introducing new exceptions,
|
|
check out the :mod:`odoo.addons.test_exceptions` module.
|
|
"""
|
|
|
|
import logging
|
|
import warnings
|
|
|
|
_logger = logging.getLogger(__name__)
|
|
|
|
|
|
class UserError(Exception):
|
|
"""Generic error managed by the client.
|
|
|
|
Typically when the user tries to do something that has no sense given the current
|
|
state of a record. Semantically comparable to the generic 400 HTTP status codes.
|
|
"""
|
|
|
|
def __init__(self, message):
|
|
"""
|
|
:param message: exception message and frontend modal content
|
|
"""
|
|
super().__init__(message)
|
|
|
|
@property
|
|
def name(self):
|
|
warnings.warn(
|
|
"UserError attribute 'name' is a deprecated alias to args[0]",
|
|
DeprecationWarning)
|
|
return self.args[0]
|
|
|
|
|
|
# deprecated due to collision with builtins, kept for compatibility
|
|
class Warning(UserError):
|
|
def __init__(self, *args, **kwargs):
|
|
warnings.warn(
|
|
"Warning is a deprecated alias to UserError and is going to be "
|
|
"removed in a future version.",
|
|
DeprecationWarning)
|
|
super().__init__(*args, **kwargs)
|
|
|
|
|
|
class RedirectWarning(Exception):
|
|
""" Warning with a possibility to redirect the user instead of simply
|
|
displaying the warning message.
|
|
|
|
:param str message: exception message and frontend modal content
|
|
:param int action_id: id of the action where to perform the redirection
|
|
:param str button_text: text to put on the button that will trigger
|
|
the redirection.
|
|
"""
|
|
def __init__(self, message, action, button_text):
|
|
super().__init__(message, action, button_text)
|
|
|
|
# using this RedirectWarning won't crash if used as an UserError
|
|
@property
|
|
def name(self):
|
|
warnings.warn(
|
|
"RedirectWarning attribute 'name' is a deprecated alias to args[0]",
|
|
DeprecationWarning)
|
|
return self.args[0]
|
|
|
|
|
|
class AccessDenied(UserError):
|
|
"""Login/password error.
|
|
|
|
.. note::
|
|
|
|
No traceback.
|
|
|
|
.. admonition:: Example
|
|
|
|
When you try to log with a wrong password.
|
|
"""
|
|
|
|
def __init__(self, message="Access Denied"):
|
|
super().__init__(message)
|
|
self.with_traceback(None)
|
|
self.__cause__ = None
|
|
self.traceback = ('', '', '')
|
|
|
|
|
|
class AccessError(UserError):
|
|
"""Access rights error.
|
|
|
|
.. admonition:: Example
|
|
|
|
When you try to read a record that you are not allowed to.
|
|
"""
|
|
|
|
|
|
class CacheMiss(KeyError):
|
|
"""Missing value(s) in cache.
|
|
|
|
.. admonition:: Example
|
|
|
|
When you try to read a value in a flushed cache.
|
|
"""
|
|
|
|
def __init__(self, record, field):
|
|
super().__init__("%r.%s" % (record, field.name))
|
|
|
|
|
|
class MissingError(UserError):
|
|
"""Missing record(s).
|
|
|
|
.. admonition:: Example
|
|
|
|
When you try to write on a deleted record.
|
|
"""
|
|
|
|
|
|
class ValidationError(UserError):
|
|
"""Violation of python constraints.
|
|
|
|
.. admonition:: Example
|
|
|
|
When you try to create a new user with a login which already exist in the db.
|
|
"""
|