Julien Castiaux
ab4000fb3c
TL;DR: remember `osv` and `except_orm` ? You can forget about them. * Deprecated `except_orm` dropped. * `UserError` elevated as super type of all user-related errors. * Unused `DeferredException` dropped. * Unused `QWebException` dropped (real one is in `qweb.py`). * `MailDeliveryException` made a python exception. * `name` legacy exception attribute made an alias of the python standard `args[0]` attribute and deprecated. * `value` legacy exception attribute dropped. * `exception_type` RPC error response key dropped. * Deprecated `osv` module dropped. * `--osv-memory-age-limit` cli option made an alias of `--transient-age-limit` and deprecated. The `odoo.exceptions.Warning` have long been a deprecated alias to `UserError`. It is going to be removed in a future version but first we explicitly deprecate it with a warning. The `odoo.exceptions.DeferredException` was a very old internal exception, it has been removed without deprecation notice as it is never raised. The `odoo.exceptions.except_orm` has been a deprecated exception type with deprecation warning for 5 years, it has been removed in favor of UserError which becomes the super class of all user-related errors. The `odoo.base.models.ir_mail_server.MailDeliveryException` was inheriting `except_orm`. As it is not related to a user error but is more of a problem an admin much take care of, the exception has been made a Python error. The `exception_type` JSON key in RPC error responses was holding an hardcoded value derived from the exception type. Its usage has been dropped in favor of the `name` JSON key that holds the precise exception name. Again as it was hardly used in the source code (beside the crash manager) it has been dropped without deprecation warning. Since we are here trying to clean odoo custom exceptions, we are also deprecating the `name` exception attribute in favor of the more standard `args[0]` attribute. The `name` (along with `value`) were two attributes used to raise `except_orm` exceptions before the introduction of `UserError`, `AccessError` and related exceptions. The `name` attribute, at the time, was holding the exception type/title. Nowadays it contains the error message. The `value` attribute, at the time, was holding the error message. Nowadays it is no more used. The `osv` module contains very old deprecated aliases. There is no simple way to log a deprecation warning for osv, osv_memory and osv_abstract but as they have not been in use for ages, they have been removed too. To be consistent, the `--osv-memory-age-limit` cli option has been made a deprecated alias to the `--transient-age-limit`. closes odoo/odoo#45723 Task: 2187728 Related: odoo/enterprise#9162 Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
90 lines
4.0 KiB
Python
90 lines
4.0 KiB
Python
# -*- coding: utf-8 -*-
|
|
import pprint
|
|
import logging
|
|
from werkzeug import urls, utils
|
|
|
|
from odoo import http, _
|
|
from odoo.http import request
|
|
from odoo.exceptions import ValidationError, UserError
|
|
|
|
_logger = logging.getLogger(__name__)
|
|
|
|
|
|
class AuthorizeController(http.Controller):
|
|
_return_url = '/payment/authorize/return/'
|
|
_cancel_url = '/payment/authorize/cancel/'
|
|
|
|
@http.route([
|
|
'/payment/authorize/return/',
|
|
'/payment/authorize/cancel/',
|
|
], type='http', auth='public', csrf=False)
|
|
def authorize_form_feedback(self, **post):
|
|
_logger.info('Authorize: entering form_feedback with post data %s', pprint.pformat(post))
|
|
if post:
|
|
request.env['payment.transaction'].sudo().form_feedback(post, 'authorize')
|
|
base_url = request.env['ir.config_parameter'].sudo().get_param('web.base.url')
|
|
# Authorize.Net is expecting a response to the POST sent by their server.
|
|
# This response is in the form of a URL that Authorize.Net will pass on to the
|
|
# client's browser to redirect them to the desired location need javascript.
|
|
return request.render('payment_authorize.payment_authorize_redirect', {
|
|
'return_url': urls.url_join(base_url, "/payment/process")
|
|
})
|
|
|
|
@http.route(['/payment/authorize/s2s/create_json_3ds'], type='json', auth='public', csrf=False)
|
|
def authorize_s2s_create_json_3ds(self, verify_validity=False, **kwargs):
|
|
token = False
|
|
acquirer = request.env['payment.acquirer'].browse(int(kwargs.get('acquirer_id')))
|
|
|
|
try:
|
|
if not kwargs.get('partner_id'):
|
|
kwargs = dict(kwargs, partner_id=request.env.user.partner_id.id)
|
|
token = acquirer.s2s_process(kwargs)
|
|
except ValidationError as e:
|
|
message = e.args[0]
|
|
if isinstance(message, dict) and 'missing_fields' in message:
|
|
if request.env.user._is_public():
|
|
message = _("Please sign in to complete the payment.")
|
|
# update message if portal mode = b2b
|
|
if request.env['ir.config_parameter'].sudo().get_param('auth_signup.allow_uninvited', 'False').lower() == 'false':
|
|
message += _(" If you don't have any account, ask your salesperson to grant you a portal access. ")
|
|
else:
|
|
msg = _("The transaction cannot be processed because some contact details are missing or invalid: ")
|
|
message = msg + ', '.join(message['missing_fields']) + '. '
|
|
message += _("Please complete your profile. ")
|
|
|
|
return {
|
|
'error': message
|
|
}
|
|
except UserError as e:
|
|
return {
|
|
'error': e.args[0],
|
|
}
|
|
|
|
if not token:
|
|
res = {
|
|
'result': False,
|
|
}
|
|
return res
|
|
|
|
res = {
|
|
'result': True,
|
|
'id': token.id,
|
|
'short_name': token.short_name,
|
|
'3d_secure': False,
|
|
'verified': True, #Authorize.net does a transaction type of Authorization Only
|
|
#As Authorize.net already verify this card, we do not verify this card again.
|
|
}
|
|
#token.validate() don't work with Authorize.net.
|
|
#Payments made via Authorize.net are settled and allowed to be refunded only on the next day.
|
|
#https://account.authorize.net/help/Miscellaneous/FAQ/Frequently_Asked_Questions.htm#Refund
|
|
#<quote>The original transaction that you wish to refund must have a status of Settled Successfully.
|
|
#You cannot issue refunds against unsettled, voided, declined or errored transactions.</quote>
|
|
return res
|
|
|
|
@http.route(['/payment/authorize/s2s/create'], type='http', auth='public')
|
|
def authorize_s2s_create(self, **post):
|
|
acquirer_id = int(post.get('acquirer_id'))
|
|
acquirer = request.env['payment.acquirer'].browse(acquirer_id)
|
|
acquirer.s2s_process(post)
|
|
return utils.redirect("/payment/process")
|