Romain Derie
f51a53e6ee
`s_map` snippet is calling maps.google.com which might be the reason this tour experience some race condition when trying to drag and drop the `s_newsletter_subscribe_form` (which happen after the `s_map` snippet was dropped). When the race condition happen, we can see on the screenshot that the snippet was drag & dropped into the footer instead of the `s_text_image` inside the `#wrap` as it should be (see comment on first step of the test). The reason the snippet is not dropped where it should be is because the `s_map` was not removed as it should have been (seeing the screenshot), so the page was scrolled and the footer became the first available and visible `o_editable`. The `s_map` snippet is probably still in the DOM (despite a step is in charge of removing it) because it is recreated after the google maps server reply, which sometimes is probably taking an unexpected long time. Anyway, external services should never be called during tests, removing the snippet from the tour is an "easy" first step to try to fix the race condition. closes odoo/odoo#79120 X-original-commit: 37c9ae2c3b228e5abbe5bdb84df2c381d9f2fcb3 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
31 lines
1.4 KiB
Python
31 lines
1.4 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from lxml import html
|
|
|
|
import odoo
|
|
import odoo.tests
|
|
from odoo.addons.website.tools import MockRequest
|
|
|
|
|
|
@odoo.tests.common.tagged('post_install', '-at_install', 'website_snippets')
|
|
class TestSnippets(odoo.tests.HttpCase):
|
|
|
|
def test_01_empty_parents_autoremove(self):
|
|
self.start_tour("/?enable_editor=1", "snippet_empty_parent_autoremove", login='admin')
|
|
|
|
def test_02_default_shape_gets_palette_colors(self):
|
|
self.start_tour("/?enable_editor=1", "default_shape_gets_palette_colors", login='admin')
|
|
|
|
def test_03_snippets_all_drag_and_drop(self):
|
|
with MockRequest(self.env, website=self.env['website'].browse(1)):
|
|
snippets_template = self.env['ir.ui.view'].render_public_asset('website.snippets')
|
|
html_template = html.fromstring(snippets_template)
|
|
data_snippet_els = html_template.xpath("//*[@class='o_panel' and not(contains(@class, 'd-none'))]//*[@data-snippet]")
|
|
blacklist = [
|
|
's_facebook_page', # avoid call to external services (facebook.com)
|
|
's_map', # avoid call to maps.google.com
|
|
]
|
|
snippets_names = ','.join([el.attrib['data-snippet'] for el in data_snippet_els if el.attrib['data-snippet'] not in blacklist])
|
|
self.start_tour("/?enable_editor=1&snippets_names=%s" % snippets_names, "snippets_all_drag_and_drop", login='admin', timeout=300)
|